0019155: Buffer too small to concatenate strings in section "Create default Cash entry" in c_order_post1

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0019155

Openbravo ERP

07. Sales management

public

2011-11-23 16:58

2011-12-15 13:46

Reporter

VictorVillar

Assigned To

umartirena

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

2.50MP35

Target Version

2.50MP37

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

OBPS

Web browser

Modules

Core

Support ticket

13250

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0019155: Buffer too small to concatenate strings in section "Create default Cash entry" in c_order_post1

Description

In the section "Create default Cash entry" there is a concatenation and the variable v_DocumentNo is too small (200), in the function c_order_post1, when you post a Sales Order

Steps To Reproduce

When you post a Sales Order, it happens the following concatenation:
C_ORDER.DOCUMENTNO||' - '||C_BPARTNER.NAME||' - '||C_ORDER.GRANDTOTAL
and it stores in v_DocumentNo

We can see in PL/SQL c_order_post1 the definition of the variable:
v_DocumentNo VARCHAR (200)
and the section "Create default Cash entry" has the following code:

/**************************************************************************
  * Create default Cash entry
  *************************************************************************/
  DECLARE
    v_PaymentRule VARCHAR(60) ;
    CUR_CB RECORD;
    v_debtPaymentID VARCHAR(32); --OBTG:varchar2--
    v_totalCash NUMERIC;
  v_CB_Curr VARCHAR(32); --OBTG:varchar2--
  BEGIN
    /* ALO
    */
    UPDATE C_DEBT_PAYMENT SET IsValid='Y' WHERE C_Order_ID=v_Record_ID;
    SELECT C_ORDER.PAYMENTRULE,
      C_ORDER.DOCUMENTNO||' - '||C_BPARTNER.NAME||' - '||C_ORDER.GRANDTOTAL,
      C_ORDER.GRANDTOTAL,
      C_ORDER.M_WAREHOUSE_ID
    INTO v_PaymentRule,
      v_DocumentNo,
      v_GrandTotal,
      v_M_Warehouse_ID
    FROM C_ORDER,
      C_BPARTNER
    WHERE C_ORDER.C_BPARTNER_ID=C_BPARTNER.C_BPARTNER_ID
      AND C_ORDER_ID=v_Record_ID;
    SELECT MAX(NAME)
    INTO v_WarehouseName
    FROM M_WAREHOUSE
    WHERE M_WAREHOUSE_ID=v_M_Warehouse_ID;

Proposed Solution

It should be fix with the next statement:
substr(C_ORDER.DOCUMENTNO||' - '||C_BPARTNER.NAME||' - '||C_ORDER.GRANDTOTAL||' ...',1,200)

Additional Information