Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019112ModulesCuaderno 43public2011-11-18 13:372011-12-01 10:01
Reportermaite 
Assigned Tomirurita 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0019112: Improve algorithm to match business partner when importing cuaderno 43 bank file
DescriptionImprove algorithm to match business partner when importing cuaderno 43 bank file. As bank statement files received are quite different, actual method is too generic
Steps To Reproduce0. install cuaderno 43 module and apply dataset
1. import Bank statement in Financial Account and realize that business partner does not match
Proposed SolutionImprove the algorithm for matching business partner.
Use both concepts fields (concept1 and concept2) of the Cuaderno 43 to do the matching.
Probably the string should be clean, removing for example multiple spaces, numbers and other special characters.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0019149 closed mirurita Improve algorithm to match business partner when importing cuaderno 43 bank file 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-11-18 13:37maiteNew Issue
2011-11-18 13:37maiteAssigned To => eduardo_Argal
2011-11-18 13:37maiteIssue Monitored: networkb
2011-11-23 13:12miruritaNote Added: 0043104
2011-11-23 13:12miruritaProposed Solution updated
2011-11-23 13:14miruritaIssue cloned0019149
2011-11-23 13:15miruritaRelationship addedrelated to 0019149
2011-11-23 16:39hgbotCheckin
2011-11-23 16:39hgbotNote Added: 0043118
2011-11-23 16:40miruritaAssigned Toeduardo_Argal => mirurita
2011-11-23 17:33hgbotCheckin
2011-11-23 17:33hgbotNote Added: 0043121
2011-11-23 17:33hgbotStatusnew => resolved
2011-11-23 17:33hgbotResolutionopen => fixed
2011-11-23 17:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/01090a96c0dbefc157987318e750986313eebc4d [^]
2011-11-23 18:52hgbotCheckin
2011-11-23 18:52hgbotNote Added: 0043132
2011-11-23 19:10miruritaNote Added: 0043133
2011-11-25 16:20hudsonbotCheckin
2011-11-25 16:20hudsonbotNote Added: 0043342
2011-12-01 10:01eduardo_ArgalNote Added: 0043623
2011-12-01 10:01eduardo_ArgalStatusresolved => closed

Notes
(0043104)
mirurita   
2011-11-23 13:12   
SOLUTION

Cuaderno 43
-----------
  + concept1 and concept2 are used to generate business partner name. (before only concept2 was used). Resultant string is as well filtered to avoid multiple spaces, numbers and special characters (any character not included in abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ)
  + description field in the bank statement line is populated with concept1 and concept2 (not filtered, as they appear in the file).

APRM
----
  + Match Statement popup: matched business partners appear in bold. When the bank statement line has a business partner the business partner will be presented in bold.
  + Matching algorithm for business partners has been improved:
    1) Find a match in previous bank statement for the same financial account.
    2) Try a full match by name
    3) New function to obtain closest match: first filter business partners which name contains one of the tokens and second filter this list with Levenshtein algorithm.
  + Some more constraints added to hql queries (organization validation and financial account validation).
(0043118)
hgbot   
2011-11-23 16:39   
Repository: erp/pmods/org.openbravo.module.cuaderno43.es
Changeset: 4969ef4a81b245b7971ed95ead04e0adfe021568
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Wed Nov 23 16:38:33 2011 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.cuaderno43.es/rev/4969ef4a81b245b7971ed95ead04e0adfe021568 [^]

Related to issue 19112, issue 19149: Improve algorithm to match business partner when importing cuaderno43

---
M src/org/openbravo/module/cuaderno43/es/utility/Cuaderno43.java
---
(0043121)
hgbot   
2011-11-23 17:33   
Repository: erp/devel/pi
Changeset: 01090a96c0dbefc157987318e750986313eebc4d
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Wed Nov 23 17:32:01 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/01090a96c0dbefc157987318e750986313eebc4d [^]

Fixes issue 19112: Improve algorithm to match business partner when importing cuaderno43

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransactionGrid.srpt
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransactionGrid.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0043132)
hgbot   
2011-11-23 18:52   
Repository: erp/pmods/org.openbravo.module.cuaderno43.es
Changeset: fe48cf7d8a24f667d157462c89597774bdf81257
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Wed Nov 23 18:52:34 2011 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.cuaderno43.es/rev/fe48cf7d8a24f667d157462c89597774bdf81257 [^]

Related to issue 19112: if any exception occur trying to clean return input string

---
M src/org/openbravo/module/cuaderno43/es/utility/Cuaderno43.java
---
(0043133)
mirurita   
2011-11-23 19:10   
TESTING PLAN
Expected result in the following cases is to have as business partner name concept1 and concept2 fields concatenated, filtering out multiple spaces, numbers and special characters (any character not included in abcdefghijklmnnopqrstuvwxyzABCDEFGHIJKLMNÑOPQRSTUVWXYZ)

Import a c43 file:
- concept1 and concept2 field not empty.
- concept1 field empty and concept2 field not empty.
- concept1 field not empty and concept2 field empty.
- concept1 field not empty and concept2 field empty.
- concept1 or concept2 having numbers.
- concept1 or concept2 having any special character.
- concept1 or concept2 having multiple spaces.
(0043342)
hudsonbot   
2011-11-25 16:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/98907f0c5af2 [^]

Maturity status: Test
(0043623)
eduardo_Argal   
2011-12-01 10:01   
Tested and working. A fix was required and applied:
19192: Bank Statement Import does not find Business partner information from previous bank statement files.

Mikel please close it
;)