Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019086Openbravo ERPA. Platformpublic2011-11-16 17:302011-11-22 13:15
Reportermirurita 
Assigned Tomtaal 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP5 
Target Version3.0MP5.1Fixed in Version3.0MP5.1 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket13268
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019086: Selectors in APRM manual windows does not filter when you start typing (they show all records)
DescriptionNew selectors in APRM manual windows does not filter when you start typing.
Does not matter what you type, they show all records.

Filtering when you open selector window is working fine.
Steps To Reproduce1) Go to Financial Account window
2) Select any financial account and click on Add Transaction button
3) Click on Add Payment In/Out button
4) Type 'dummy' and realize that all the business parnters are shown.
Proposed Solution
Additional Information
TagsRegression
Relationships
related to defect 00189013.0MP5 closed mtaal Improve default view loading 
Attached Filespng Selector not filtering.png (46,871) 2011-11-16 17:30
https://issues.openbravo.com/file_download.php?file_id=4754&type=bug
png

? 19086.export (1,391) 2011-11-17 17:06
https://issues.openbravo.com/file_download.php?file_id=4757&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-11-16 17:30miruritaNew Issue
2011-11-16 17:30miruritaAssigned To => alostale
2011-11-16 17:30miruritaFile Added: Selector not filtering.png
2011-11-16 17:30miruritaModules => Core
2011-11-16 17:30miruritaOBNetwork customer => Yes
2011-11-16 17:30miruritaSupport ticket => 13268
2011-11-16 17:32miruritaSeveritycritical => major
2011-11-17 08:27alostaleNote Added: 0042904
2011-11-17 08:27alostaleStatusnew => closed
2011-11-17 08:27alostaleResolutionopen => out of date
2011-11-17 09:34miruritaNote Added: 0042905
2011-11-17 09:34miruritaStatusclosed => new
2011-11-17 09:34miruritaResolutionout of date => open
2011-11-17 11:17shuehnerTarget Version => 3.0MP5.1
2011-11-17 11:19shuehnerTag Attached: Regression
2011-11-17 11:30miruritaNote Added: 0042921
2011-11-17 11:50iperdomoRelationship addedrelated to 0018841
2011-11-17 11:53iperdomoRelationship deletedrelated to 0018841
2011-11-17 11:55iperdomoRelationship addedrelated to 0018901
2011-11-17 11:58iperdomoNote Added: 0042923
2011-11-17 12:13miruritaAssigned Toalostale => mtaal
2011-11-17 17:06mtaalFile Added: 19086.export
2011-11-22 12:54shuehnerStatusnew => scheduled
2011-11-22 12:54shuehnerfix_in_branch => pi
2011-11-22 12:55shuehnerNote Added: 0043074
2011-11-22 12:55shuehnerStatusscheduled => resolved
2011-11-22 12:55shuehnerFixed in Version => 3.0MP5.1
2011-11-22 12:55shuehnerFixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/3fe117772a75 [^]
2011-11-22 12:55shuehnerResolutionopen => fixed
2011-11-22 13:15marvintmNote Added: 0043075
2011-11-22 13:15marvintmStatusresolved => closed

Notes
(0042904)
alostale   
2011-11-17 08:27   
Working fine in current pi@a1a097a6f0d2
(0042905)
mirurita   
2011-11-17 09:34   
The problem is in 3.0MP5
(0042921)
mirurita   
2011-11-17 11:30   
The problem is in modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js

if you do a reversal diff and apply in a MP5 it works
hg diff -r 3.0MP5:3.0MP4 modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js

here the revisions
https://code.openbravo.com/erp/devel/pi/log/1f040a883f1c/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js [^]
(0042923)
iperdomo   
2011-11-17 11:58   
The real problem is the compareAdvancedCriteria function in isc.DataSource object. In the upgrade Isomorphic introduced a problem, and mtaal try to workaround it with this changeset:
https://code.openbravo.com/erp/devel/pi/diff/395cc1ac0987/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js [^]

This causes the problem. The function was rolled back in issue 0018841
(0043074)
shuehner   
2011-11-22 12:55   
Marking as resolved.
Change was only needed in MP5.1 branch and not in pi (As issue did not happen in pi at time of fix, as change causing it was reverted there already).

https://code.openbravo.com/erp/devel/pi/rev/3fe117772a75 [^]
Author Martin Taal <martin.taal@openbravo.com>
    Thu Nov 17 17:05:37 2011 +0100 (4 days ago)
Fixes issue 19086: Selectors in APRM manual windows does not filter when you start typing (they show all records)
(0043075)
marvintm   
2011-11-22 13:15   
Reviewed the diff to search for possible regressions after the change. Mikel checked that the functionality itself worked correctly.