Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0019059Openbravo ERPZ. Otherspublic2011-11-14 10:152011-12-02 14:39
dmiguelez 
dmiguelez 
immediatecriticalalways
closedfixed 
20Community Appliance
 
 
Google Chrome
Core
No
0019059: Issue 0018796: try-api fails. Requesting API change.
Due to this issue,

- https://issues.openbravo.com/view.php?id=18796 [^]

I have to make an this API change:

https://code.openbravo.com/erp/devel/try/rev/af91c513ad44 [^]

I have pushed the change to try and this is the failure:

http://builds.openbravo.com/view/try/job/try-api/529/console [^]

- The change is the following:
The ReportGeneralLedgerJournalDetail was executing inside ReportGeneralLedgerJournal process.

- The change is needed due to the following reason:
In 3.0 this forces you to re-open ReportGeneralLedgerJournal after opening the Detail process if you want to execute ReportGeneralLedgerJournal again because there is not backwards button.

- The risk of this api change is very low because of the following reason:
The Detail's mapping is deleted in ReportGeneralLedgerJournal's process and a new mapping is created in ReportGeneralLedgerJournalDetail's process. The only risk is if someone is developing a module that opens tabs and uses the old mapping for the ReportGeneralLedgerJournalDetail. This is very unlikely to happen.
None
No tags attached.
Issue History
2011-11-14 10:15dmiguelezNew Issue
2011-11-14 10:15dmiguelezAssigned To => iciordia
2011-11-14 10:15dmiguelezWeb browser => Google Chrome
2011-11-14 10:15dmiguelezModules => Core
2011-11-14 12:41iciordiaNote Added: 0042810
2011-11-14 12:41iciordiaAssigned Toiciordia => dmiguelez
2011-11-15 16:00hgbotCheckin
2011-11-15 16:00hgbotNote Added: 0042838
2011-11-15 16:00hgbotStatusnew => resolved
2011-11-15 16:00hgbotResolutionopen => fixed
2011-11-15 16:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/06f744fa2469998a3876a0c1e2c6bcded53dae79 [^]
2011-11-23 16:39dmiguelezNote Added: 0043120
2011-12-02 14:39miruritaNote Added: 0043695
2011-12-02 14:39miruritaStatusresolved => closed

Notes
(0042810)
iciordia   
2011-11-14 12:41   
Approved. Ismael
(0042838)
hgbot   
2011-11-15 16:00   
Repository: erp/devel/api-checks
Changeset: 06f744fa2469998a3876a0c1e2c6bcded53dae79
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Mon Nov 14 13:16:13 2011 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/06f744fa2469998a3876a0c1e2c6bcded53dae79 [^]

Fixed issue 0019059: Issue 0018796: try-api fails. Requesting API change.

---
M model/src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M model/src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---
(0043120)
dmiguelez   
2011-11-23 16:39   
Testing plan

No testing plan required.

Low regression risk.
(0043695)
mirurita   
2011-12-02 14:39   
Very low risk api change approved by Isma.