Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019052Openbravo ERP08. Project and service managementpublic2011-11-11 12:492015-02-04 20:35
ReporterRenateNieuwkoop 
Assigned Toreinaldoguerra 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned Toumartirena
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket33258
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019052: Create AP Expense Invoices error is unclear
DescriptionWhen you execute the Create AP Expense Invoices process, the employee related to the expense needs to be set up with the information in the Vendor tab in the Business Partner screen:
- The purchase pricelist
- The PO Payment Method
- The PO Payment Terms
- The PO Financial Account

When there is no price list, the error message says that there is no price list associated to the employee, so that is great.

However, when the other information is missing, the process just errors without indicating what the problem is.
Steps To ReproduceEnter some expenses for David McHill and process them
David McHill hasn't got the vendor info set up
so go to the Create AP Expense Invoices and try to process it for David McHill
you get an error about the price list
Go to David McHill in the business partner screen and add the purchase pricelist in the vendor tab (nothing else)
No try to process the Create AP Expense Invoices again. The general error occurs.

when you fill out the PO Payment Terms in the BP screen and try to process the Create AP Expense Invoice, again the general error occurs

In the end when you enter all (Purchase Price List, PO Payment Method, PO Payment Terms, PO Financial Account), the Purchase Invoice is created correctly.
Proposed SolutionImprove the error messages
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng IssueErrorCreateAPInvoice.png (27,409) 2011-11-11 12:49
https://issues.openbravo.com/file_download.php?file_id=4747&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-11-11 12:49RenateNieuwkoopNew Issue
2011-11-11 12:49RenateNieuwkoopAssigned To => jonalegriaesarte
2011-11-11 12:49RenateNieuwkoopFile Added: IssueErrorCreateAPInvoice.png
2011-11-11 12:49RenateNieuwkoopModules => Core
2011-11-11 12:49RenateNieuwkoopOBNetwork customer => No
2012-09-13 10:43jonalegriaesarteAssigned Tojonalegriaesarte => dmiguelez
2014-12-24 17:07ngarciaOBNetwork customerNo => Yes
2014-12-24 17:07ngarciaSupport ticket => 33258
2014-12-24 17:07ngarciaResolution time => 1422313200
2014-12-24 17:07ngarciaTriggers an Emergency Pack => No
2014-12-24 17:07ngarciaAssigned Todmiguelez => AtulOpenbravo
2014-12-24 17:07ngarciaPrioritynormal => urgent
2014-12-24 17:07ngarciaSeverityminor => major
2014-12-24 17:07ngarciaReproducibilityhave not tried => always
2014-12-24 17:07ngarciaTypedesign defect => defect
2014-12-24 17:07ngarciaversion3.0MP4.1 =>
2014-12-24 17:08ngarciaIssue Monitored: networkb
2015-01-28 15:59reinaldoguerraAssigned ToAtulOpenbravo => reinaldoguerra
2015-01-28 15:59reinaldoguerraStatusnew => scheduled
2015-01-29 00:36reinaldoguerraNote Added: 0073875
2015-02-02 17:14hgbotCheckin
2015-02-02 17:14hgbotNote Added: 0073995
2015-02-02 17:14hgbotStatusscheduled => resolved
2015-02-02 17:14hgbotResolutionopen => fixed
2015-02-02 17:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0cfbfb5b1bd2048f9b4eac0c09e537f900b8a651 [^]
2015-02-02 17:14umartirenaReview Assigned To => umartirena
2015-02-02 17:14umartirenaNote Added: 0073996
2015-02-02 17:14umartirenaStatusresolved => closed
2015-02-02 17:14umartirenaFixed in Version => pi
2015-02-04 20:35hudsonbotCheckin
2015-02-04 20:35hudsonbotNote Added: 0074208

Notes
(0073875)
reinaldoguerra   
2015-01-29 00:36   
Test plan used:
1- Login into Openbravo ERP.
2- Go to Product window and create a new record for "F&B España, S.A" as Organization and "Expense type" as Product Type.
3- Go to price list and create two records setting "Tarifa Bebidas Alegres" and "Tarifa de ventas" as Price List Version.
4- Go to Business Partner window and check that employee named "Javier Martín" hasn't got the vendor info set up
5- Go to Expense Sheet window and create a new header for
   Organization: F&B España, S.A.
   Employee: Javier Martín
   Report Date: today
6- Go to lines tab and create a new record selecting created product previously, do not check "Time Sheet" flag.
7- Process the expense
8- Go to Create AP Expense Invoices window and select as filters:
   Employee: Javier Martín
   From, to, and invoiced dates: Today
9- Click on Process button and realize that a "not defined a pricelist" error is shown
10- Go back to "Javier Martín" business partner vendor tab, check Vendor flag, and select a price list, save it
11- Click on Process button again and realize that a "not defined a payment method" error is shown
12- Go back to "Javier Martín" business partner vendor tab, and select a payment method, save it
13- Click on Process button again and realize that a "not defined a payment term" error is shown
14- Go back to "Javier Martín" business partner vendor tab, and select a payment term, save it
15- Click on Process button again and realize that a new purchase invoice is created successfuly. Also note that all error message were shown in a clear way.
(0073995)
hgbot   
2015-02-02 17:14   
Repository: erp/devel/pi
Changeset: 0cfbfb5b1bd2048f9b4eac0c09e537f900b8a651
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Wed Jan 28 18:31:08 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/0cfbfb5b1bd2048f9b4eac0c09e537f900b8a651 [^]

Fixed bug 19052: Create AP Expense Invoices error is unclear.

The Create AP Expense Invoices manual window's class, was changed to process also error message catched by the exception: "PayementMethodNotdefined".
Now all possible exceptions when creating invoices from expenses are processed, and error messages are shown in a clear way.

---
M src/org/openbravo/erpCommon/ad_process/ExpenseAPInvoice.java
---
(0073996)
umartirena   
2015-02-02 17:14   
Code Review + Testing OK
(0074208)
hudsonbot   
2015-02-04 20:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f36c91d0ad63 [^]
Maturity status: Test