Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018938Openbravo ERPB. User interfacepublic2011-10-30 00:012012-09-28 14:39
Reporterpjuvara 
Assigned Todbaz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionUbuntu 11.10
Product Version3.0MP4.1 
Target VersionFixed in Version3.0MP16 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018938: Keyboard shortcut conflict in Ubuntu Unity prevents moving to parent tab with keyboard
DescriptionAlt-shift-arrow up in Unity (the Ubuntu interface starting from 11.04) causes a zoom out on the desktop and conflicts with the Openbravo shortcut to move to the parent tab.
Steps To ReproduceSee attachment
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files? out.ogv (3,078,816) 2011-10-30 00:01
https://issues.openbravo.com/file_download.php?file_id=4690&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-10-30 00:01pjuvaraNew Issue
2011-10-30 00:01pjuvaraAssigned To => dbaz
2011-10-30 00:01pjuvaraFile Added: out.ogv
2011-10-30 00:01pjuvaraWeb browser => Google Chrome
2011-10-30 00:01pjuvaraModules => Core
2011-10-30 00:01pjuvaraOBNetwork customer => No
2011-10-30 00:01pjuvaraWeb browserGoogle Chrome => Google Chrome
2011-10-30 00:01pjuvaraversion => 3.0MP4.1
2012-09-04 17:09AugustoMauchWeb browserGoogle Chrome => Google Chrome
2012-09-04 17:09AugustoMauchNote Added: 0051828
2012-09-04 17:09AugustoMauchTypedefect => design defect
2012-09-04 17:28AugustoMauchAssigned Todbaz => rgoris
2012-09-17 12:07rgorisNote Added: 0052161
2012-09-17 12:07rgorisStatusnew => feedback
2012-09-17 12:07rgorisAssigned Torgoris => pjuvara
2012-09-17 12:34AugustoMauchNote Added: 0052162
2012-09-17 13:37pjuvaraNote Added: 0052167
2012-09-17 13:37pjuvaraAssigned Topjuvara => AugustoMauch
2012-09-17 13:37pjuvaraStatusfeedback => new
2012-09-17 13:39AugustoMauchNote Added: 0052168
2012-09-20 15:51rgorisNote Added: 0052261
2012-09-25 16:52dbazAssigned ToAugustoMauch => dbaz
2012-09-25 16:54dbazClosed by => AugustoMauch
2012-09-25 16:54dbazWeb browserGoogle Chrome => Google Chrome
2012-09-25 16:54dbazIssue Monitored: AugustoMauch
2012-09-25 16:57hgbotCheckin
2012-09-25 16:57hgbotNote Added: 0052590
2012-09-25 16:57hgbotStatusnew => resolved
2012-09-25 16:57hgbotResolutionopen => fixed
2012-09-25 16:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/48b1f1c225ec3fcf8e057769cb317a553bac3d0b [^]
2012-09-26 17:37AugustoMauchNote Added: 0052802
2012-09-26 17:37AugustoMauchStatusresolved => closed
2012-09-26 17:37AugustoMauchFixed in Version => 3.0MP16
2012-09-28 14:39hudsonbotCheckin
2012-09-28 14:39hudsonbotNote Added: 0052901

Notes
(0051828)
AugustoMauch   
2012-09-04 17:09   
This issue can not be solved until a new shortcut is defined for moving among tabs.
(0052161)
rgoris   
2012-09-17 12:07   
Paolo, Augusto, could you try CTRL+SPACE+ArrowUp (or down) in your OS while looking at Openbravo 3 grid-grid, grid-form, form-grid and form-form views in a few browsers? On paper, it should not cause any conflicts. Only on Mac OSX it selects a row (ticks a box) but we can probably disable this.
(0052162)
AugustoMauch   
2012-09-17 12:34   
Hi Rob,

Ctrl+Space+Arrow up or Arrow down does not have any conflict in Chrome or Firefox in Ubuntu. Problem is, the left and right arrows are being used in both browsers to move the horizontal scrollbar
(0052167)
pjuvara   
2012-09-17 13:37   
In my environment (Ubuntu 12.04 with Google Chrome), CTRL+SPACE+ArrowUp/Down does not create any conflict.
(0052168)
AugustoMauch   
2012-09-17 13:39   
Shall we use CTRL+SPACE+ArrowUp/Down to move among tabs vertically if we can't use CTRL+SPACE+ArrowLeft/Right to move horizontally?
(0052261)
rgoris   
2012-09-20 15:51   
Augusto: Yes. I tested it in OB3 grids and (you are right about the horizontal slider bar scrolling) the horizontal scrolling also occurs just by using the left and right arrow keys. So no conflict or regression here.

To be consistent, we must implement all four new keyboard shortcuts (up, down, sibling left and sibling right). Ideally, we add the new keyboard shortcuts on top of the old ones, not too annoy current users and to leave the door open to roll back, if we still happen to find unknown conflicts.

Updated:

https://docs.google.com/a/openbravo.com/spreadsheet/ccc?key=0AscCzhu_uHnCdFlJSkMxQTRoNHdYUE1PNDBYRDY1YUE&authkey=CPjuiJsF&authkey=CPjuiJsF#gid=0 [^]
(0052590)
hgbot   
2012-09-25 16:57   
Repository: erp/devel/pi
Changeset: 48b1f1c225ec3fcf8e057769cb317a553bac3d0b
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Sep 25 16:56:41 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/48b1f1c225ec3fcf8e057769cb317a553bac3d0b [^]

Fixed issue 18938: Added Ctrl+Space+Arrow [KS] to navigate between tabs

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_PREFERENCE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-tab.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-keyboard-manager.js
---
(0052802)
AugustoMauch   
2012-09-26 17:37   
Code reviewed and verified in pi@8a0aed9bd90d
(0052901)
hudsonbot   
2012-09-28 14:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6d2f8cffd4b1 [^]

Maturity status: Test