Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018914Openbravo ERPZ. Otherspublic2011-10-27 18:532011-11-04 13:58
Reportermaite 
Assigned Tomirurita 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP5Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018914: Bank statements in draft status should not be considered by "Match Statement" nor "Reconcile" process
Description* Bank statements in draft status should not be considered by "Match Statement" nor "Reconcile" process.
* Calculation of Reconciliation Ending Balance amount should not consider Bank statements in draft status
Steps To Reproduce1. Create one bank statement with one line of 50 euros IN. Process
2. Create different bank statement with one line of 30 euros IN. NOT process
3. From financial Account, press "Match statement". Realize that both lines appear in pop-up
4. "Add" transaction to reconcile just 50 euros line. Process.
5. Go to Reconciliation and realize that "Ending Balance" is also considering 30 euros line
Proposed Solution* To fix calculation ending balance problem following changes are required:
method "getReconciliationEndingBalance" in file MatchTransactionDao.java should add:
obcBsl.add(Restrictions.eq("bs." + FIN_BankStatement.PROPERTY_ACTIVE,
                      true));
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0018933 closed mirurita Bank statements in draft status should not be considered by "Match Statement" nor "Reconcile" process 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-10-27 18:53maiteNew Issue
2011-10-27 18:53maiteAssigned To => jonalegriaesarte
2011-10-27 18:53maiteModules => Advanced Payables and Receivables Mngmt
2011-10-27 18:53maiteResolution time => 1321052400
2011-10-27 18:54maiteIssue Monitored: networkb
2011-10-29 16:34miruritaAssigned Tojonalegriaesarte => mirurita
2011-10-29 16:34miruritaStatusnew => scheduled
2011-10-29 16:34miruritafix_in_branch => pi
2011-10-29 16:35miruritaTarget Version => 3.0MP5
2011-10-29 16:35miruritafix_in_branchpi =>
2011-10-29 17:18hgbotCheckin
2011-10-29 17:18hgbotNote Added: 0042325
2011-10-29 17:18hgbotStatusscheduled => resolved
2011-10-29 17:18hgbotResolutionopen => fixed
2011-10-29 17:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5a31fb989bafb74ba7e4aeae162da82750956dc6 [^]
2011-11-02 11:51hgbotCheckin
2011-11-02 11:51hgbotNote Added: 0042440
2011-11-02 18:13maiteNote Added: 0042469
2011-11-02 18:13maiteStatusresolved => closed
2011-11-04 13:58hudsonbotCheckin
2011-11-04 13:58hudsonbotNote Added: 0042601
2011-11-04 13:58hudsonbotCheckin
2011-11-04 13:58hudsonbotNote Added: 0042619

Notes
(0042325)
hgbot   
2011-10-29 17:18   
Repository: erp/devel/pi
Changeset: 5a31fb989bafb74ba7e4aeae162da82750956dc6
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Sat Oct 29 17:11:20 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5a31fb989bafb74ba7e4aeae162da82750956dc6 [^]

Fixes issue 18914. Fixes issue 18923. Ignore draft bank statement lines in reconciliation process

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/MatchTransaction.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_reports/ReportReconciliation.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_reports/UnreconciledBankStatement.jrxml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/MatchTransactionDao.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/TransactionsDao.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_BankStatementProcess.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0042440)
hgbot   
2011-11-02 11:51   
Repository: erp/devel/pi
Changeset: 1e7e89b0e2ebc38097dc991000e3c5e935a5ee9c
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Wed Nov 02 11:48:14 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1e7e89b0e2ebc38097dc991000e3c5e935a5ee9c [^]

Related to issue 18914: matchBusinessPartnerByName only in processed bankstatements

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0042469)
maite   
2011-11-02 18:13   
verified
(0042601)
hudsonbot   
2011-11-04 13:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test
(0042619)
hudsonbot   
2011-11-04 13:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test