Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018792Openbravo ERPA. Platformpublic2011-10-17 17:492011-11-04 13:56
Reportermtaal 
Assigned Tomirurita 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP5Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018792: Advanced payment javascript uses undeclared variables
DescriptionIn javascript all variables need to be declared in the top of the function. In the advanced payment module there are several usages of variables which have not been declared.
See below for the list of issues found in the advanced payment module.
Note that there are some cases where an incorrect warning is displayed: window, document, alert and calls to global functions are incorrectly listed also. Please ignore those.

To recheck after your changes run the following script:modules/org.openbravo.client.kernel/jslint/jscheck
Steps To ReproduceIssues:



jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-utilities.js:32:7:'post' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-utilities.js:35:83:'post' is not defined.

jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:44:24:'getGlobalDecSeparator' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:45:26:'getGlobalGroupSeparator' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:46:25:'getGlobalGroupInterval' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:48:23:'formatNameToMask' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:51:25:'returnMaskChange' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:53:44:'getDefaultMaskNumeric' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:57:21:'getElementsByName' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:59:5:'displayLogicElement' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:61:18:'getElementsByName' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:63:5:'displayLogicElement' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:82:10:'returnFormattedNumber' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:118:26:'getDefaultMaskNumeric' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:121:20:'getGlobalDecSeparator' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:124:22:'getGlobalGroupSeparator' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:127:21:'getGlobalGroupInterval' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:130:13:'returnFormattedToCalc' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:133:13:'returnFormattedToCalc' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:139:14:'roundNumber' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:144:14:'returnCalcToFormatted' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:157:13:'returnFormattedToCalc' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:162:14:'returnCalcToFormatted' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:288:5:'setWindowElementFocus' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:289:5:'showJSMessage' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:293:5:'setWindowElementFocus' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:294:5:'showJSMessage' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:299:1:'setWindowElementFocus' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:300:1:'showJSMessage' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:304:5:'setWindowElementFocus' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:305:5:'showJSMessage' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:335:3:'displayLogicElement' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:336:3:'displayLogicElement' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:337:3:'displayLogicElement' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:338:3:'displayLogicElement' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:339:3:'displayLogicElement' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:340:3:'displayLogicElement' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:402:7:'setWindowElementFocus' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:404:7:'initialize_MessageBox' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:422:9:'setWindowElementFocus' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:424:9:'initialize_MessageBox' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:489:7:'updateData' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:504:13:'updateData' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:512:13:'updateData' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:568:5:'updateData' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:576:7:'updateData' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:605:5:'showJSMessage' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:610:5:'setWindowElementFocus' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:611:5:'showJSMessage' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:625:9:'showJSMessage' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:644:7:'showJSMessage' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:708:6:'top' is not defined.
jslint:./modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js:708:6:Too many errors. (96% scanned).
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00187813.0MP5 closed mtaal Javascript: local vars are not declared 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-10-17 17:49mtaalNew Issue
2011-10-17 17:49mtaalAssigned To => gorkaion
2011-10-17 17:49mtaalModules => Core
2011-10-17 17:49mtaalOBNetwork customer => No
2011-10-17 17:50mtaalRelationship addedrelated to 0018781
2011-10-18 09:44iperdomoStatusnew => scheduled
2011-10-18 09:44iperdomoAssigned Togorkaion => mirurita
2011-10-18 09:44iperdomofix_in_branch => pi
2011-10-18 10:20miruritaRelationship addedrelated to 0018797
2011-10-18 10:21miruritaRelationship deletedrelated to 0018797
2011-10-18 11:59iperdomoNote Added: 0041877
2011-10-24 12:01hgbotCheckin
2011-10-24 12:01hgbotNote Added: 0042056
2011-10-24 12:01hgbotStatusscheduled => resolved
2011-10-24 12:01hgbotResolutionopen => fixed
2011-10-24 12:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2dfdc1649f36ab21804474fdd1bf6964b8d9b1dc [^]
2011-10-31 17:38iperdomoNote Added: 0042422
2011-10-31 17:38iperdomoStatusresolved => closed
2011-11-04 13:56hudsonbotCheckin
2011-11-04 13:56hudsonbotNote Added: 0042550

Notes
(0041877)
iperdomo   
2011-10-18 11:59   
Hi,

In the FIN_Utilities.js there are references to global functions defined in web/js/utils.js

You can annotate your .js file defining which are the globals *always* available to your script. Check jslint documentation: http://www.jslint.com/lint.html#global [^]

Example:
/*global showJSMessage: false, displayLogicElement: false*/
(0042056)
hgbot   
2011-10-24 12:01   
Repository: erp/devel/pi
Changeset: 2dfdc1649f36ab21804474fdd1bf6964b8d9b1dc
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Mon Oct 24 11:59:47 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2dfdc1649f36ab21804474fdd1bf6964b8d9b1dc [^]

Fixes issue 18792: Advanced payment javascript uses undeclared variables

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-utilities.js
---
(0042422)
iperdomo   
2011-10-31 17:38   
Tested on pi @ rev b2c924670350
(0042550)
hudsonbot   
2011-11-04 13:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test