Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0018769 | Openbravo ERP | 07. Sales management | public | 2011-10-13 11:03 | 2011-10-18 17:26 |
|
| Reporter | maite | |
| Assigned To | dbaz | |
| Priority | immediate | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0MP5 | Fixed in Version | 3.0MP5 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0018769: Not possible to work with more than 3 decimals in Openbravo3 prices |
| Description | If you configure your application to work with 7 decimals in price fields(changing Format.xml and currency precision) when selecting product in Sales Invoice line, for example, price is rounded to 3 |
| Steps To Reproduce | 1. Change Format.xml to set 7 decimal places in fields priceInform, priceRelation and priceEdition
2. Logged as System administrator modify Price Precision of EUR to 7
3. Compile using ant smartbuild to persist Format changes
4. Define price: 1.1234567 for any product
5. Create Sales invoice for any BP and add line for this product. Realize that price is rounded to 1.123
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2011-10-13 11:03 | maite | New Issue | |
| 2011-10-13 11:03 | maite | Assigned To | => jonalegriaesarte |
| 2011-10-13 11:03 | maite | Modules | => Core |
| 2011-10-13 11:05 | jonalegriaesarte | Assigned To | jonalegriaesarte => iperdomo |
| 2011-10-13 12:14 | jonalegriaesarte | Assigned To | iperdomo => alostale |
| 2011-10-13 12:24 | alostale | Assigned To | alostale => dbaz |
| 2011-10-13 14:09 | dmitry_mezentsev | Target Version | => 3.0MP4 |
| 2011-10-13 15:27 | dbaz | Note Added: 0041804 | |
| 2011-10-13 15:40 | shuehner | Issue Monitored: shuehner | |
| 2011-10-13 20:10 | hgbot | Checkin | |
| 2011-10-13 20:10 | hgbot | Note Added: 0041815 | |
| 2011-10-13 20:10 | hgbot | Status | new => resolved |
| 2011-10-13 20:10 | hgbot | Resolution | open => fixed |
| 2011-10-13 20:10 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/173a7e064616bc945a73c15521529e12d4ccbeae [^] |
| 2011-10-13 20:18 | dmitry_mezentsev | Note Added: 0041816 | |
| 2011-10-14 10:14 | hgbot | Checkin | |
| 2011-10-14 10:14 | hgbot | Note Added: 0041824 | |
| 2011-10-14 11:56 | shuehner | Target Version | 3.0MP4 => 3.0MP5 |
| 2011-10-17 22:05 | dbaz | Note Added: 0041866 | |
| 2011-10-17 22:05 | dbaz | Status | resolved => closed |
| 2011-10-17 22:05 | dbaz | Fixed in Version | => 3.0MP5 |
| 2011-10-18 17:26 | hudsonbot | Checkin | |
| 2011-10-18 17:26 | hudsonbot | Note Added: 0041902 | |
| 2011-10-18 17:26 | hudsonbot | Checkin | |
| 2011-10-18 17:26 | hudsonbot | Note Added: 0041903 | |
|
Notes |
|
|
(0041804)
|
|
dbaz
|
|
2011-10-13 15:27
|
|
The problem is in SL_Invoice_Amt.java callout executed when the focus blurs the input.
The parameter strPricePrecision used to calculate the new value, always takes '2' value, and then in
priceActual = (!Utility.isBigDecimal(strPriceActual) ? ZERO : (new BigDecimal(strPriceActual)))
.setScale(PricePrecision, BigDecimal.ROUND_HALF_UP);
the value is wrongly rounded |
|
|
|
(0041815)
|
|
hgbot
|
|
2011-10-13 20:10
|
|
Repository: erp/devel/pi
Changeset: 173a7e064616bc945a73c15521529e12d4ccbeae
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Oct 13 20:08:55 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/173a7e064616bc945a73c15521529e12d4ccbeae [^]
Fixed issue 18769. Several changes have been made:
- The selector fields will now include information related to number format if they are linked to a field in the form.
- In the client, this information will be used to format the values of the out fields in case it is included. If it's not included, the only formatting done will be the replacement of the decimal separator so that callouts receive the number amount correctly.
- Callouts will no longer be able to call themselves by modifying a column which is associated with the same callout.
---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorComponent.java
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/templates/selector.ftl
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
|
|
|
|
|
Issue is fixed but won´t be included in MP4 because it has a very risky part and needs some maturing prior it.
For the instances affected by this issue I propose to use generated by CI obx (to verify it in fields) until this fix is included into the next MP - MP5. |
|
|
|
(0041824)
|
|
hgbot
|
|
2011-10-14 10:14
|
|
Repository: erp/devel/pi
Changeset: 6e4192b18a24101ec91a525fec88fea07605466e
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Oct 14 10:13:41 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6e4192b18a24101ec91a525fec88fea07605466e [^]
Related to issue 18769. Default grouping/decimal separator and grouping size will be used.
---
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/SelectorComponent.java
M modules/org.openbravo.userinterface.selector/src/org/openbravo/userinterface/selector/templates/selector.ftl
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
|
|
|
|
(0041866)
|
|
dbaz
|
|
2011-10-17 22:05
|
|
Solved by marvintm
Closed by me (dbaz) |
|
|
|
|
|
|
|
|
|