|
Notes |
|
|
(0041821)
|
|
rgoris
|
|
2011-10-14 09:36
|
|
|
Agree with Dmitry. Although technically creating a new form does not have any data to be canceled yet (as no fields have been filled in yet), for the user canceling means "abort my current action and go back to where i came from". Pressing the Cancel button to kill a new form is very obvious behavior that must be supported. |
|
|
|
(0041822)
|
|
rgoris
|
|
2011-10-14 09:53
|
|
So here is the proposed solution
1) let Cancel button kill the new window
2) keep Close button as it is now (kills the new window)
3) let Save&Close button also kill the new window (note that only the little X should be enabled, not the floppy disk icon)
4) Disable the Save button (until something really has changed in the form) |
|
|
|
|
Rob,
Sorry, don´t fully understand you.
>1) let Cancel button kill the new window
>3) let Save&Close button also kill the new window (note that only the little X should be enabled, not the floppy disk icon)
In this case we will have 2 buttons enabled for doing the same? Why? Why couldn't we let Save&Close button to work like it is now but just not show it (as you mentioned) if there are no changes in the form? |
|
|
|
(0041828)
|
|
rgoris
|
|
2011-10-14 10:43
|
|
Dmitry, the button Save&Close has two appearances: save&close (both floppy and x are enabled) and close (only the x is enabled, see image attached).
In the x-only case it does the same as the big X (close button) in the top right of a window. Right now, this also kills a new window, which is good. So the little x should do the same.
Also, as YOU told me you always clicked the save&close button, we´ll have one more happy user :-) |
|
|
|
|
> Also, as YOU told me you always clicked the save&close button, we´ll have one more happy user :-)
I was primarily clicking on it because Cancel button was not there. If Cancel is there and Save&Close is disabled :-) - I would not.
But what is strange for me as I mentioned above is to have 2 active buttons just near to each other (Save&Close and Cancel) that do the same. For me not very clean but won´t fight for this. |
|
|
|
(0041833)
|
|
rgoris
|
|
2011-10-14 11:43
|
|
Could be but does not do any harm.
More important is that the big X (top right of window) and the small x (toolbar button)always do the same. |
|
|
|
|
>1) let Cancel button kill the new window
>3) let Save&Close button also kill the new window (note that only the little X should be enabled, not the floppy disk icon)
Did not want to continue but has just came across the case where it does not work OK.
There are some forms which after pressing new contain all the required info to be saved without the need to enter info (ex, Financial Account - Payment Method tab).
In this case Cancel as killing such form - makes sense, but Save&Close button will undermine its own meaning if it also kills it. So we should take this case into account in deciding where Save - cancels and where Save - saves :-). |
|
|
|
(0041993)
|
|
mtaal
|
|
2011-10-23 00:13
|
|
Rob,
Any final comments on this one?
gr. Martin |
|
|
|
(0042070)
|
|
rgoris
|
|
2011-10-24 15:57
|
|
Dmitry/Martin
Save&Close button can have two states:
1) It saves and closes (this is when both floppy disk and x are enabled in the button graphic)
2) It only closes (this is when only the x is enabled in the button graphic) because there is nothing to save (no changes). This does exactly the same as the Close button (X).
So in case of Financial Account - Payment Method tab (new record that has all the necessary field values at the start) the Save&Close button will be a real Save&Close button (with both floppy and x enabled in the graphic). To cancel you would click the Cancel button (or the big X close button top right). To save&close you would click the save&close button.
Note that clicking the big close (X) in the top right of the form works as follows: it always saves & closes UNLESS no changes have taken place: in this case it kills the window. |
|
|
|
(0042084)
|
|
mtaal
|
|
2011-10-25 10:23
|
|
Changes to do:
- save button should be disabled if there are no changes
- save-close should be in close status if there are no changes
- cancel should be enabled if there are no changes, in this case it should abort the form. |
|
|
|
(0042125)
|
|
hgbot
|
|
2011-10-26 19:36
|
|
Repository: erp/devel/pi
Changeset: f9b05776d6570f5074ff4e112b27ed44bf0f1969
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Oct 26 19:33:38 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f9b05776d6570f5074ff4e112b27ed44bf0f1969 [^]
Fixes issue 18761: There is no way to cancel new record in the form view using menu buttons
Changed when the cancel button is enabled (always in form mode) with different behavior
Only enable save if all required fields have been set and there are no errors in the form
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-statusbar.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
|
|
|
|
(0042419)
|
|
rgoris
|
|
2011-10-31 17:26
|
|
Just tested on live builds pi and we´re almost there. Only (- save-close should be in close status if there are no changes) is not entirely doing what it should.
If you click the little x it should do the same as the big X (close the form even though it cant be saved) |
|
|
|
(0042433)
|
|
hgbot
|
|
2011-11-02 10:26
|
|
Repository: erp/devel/pi
Changeset: 7445c86c656d83ff4075353bccfe10826442eabb
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Nov 02 10:25:34 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7445c86c656d83ff4075353bccfe10826442eabb [^]
Related to issue 18761: There is no way to cancel new record in the form view using menu buttons
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
|
|
|
|
|
I see a problem with these changes: there are windows in which even if no change was done by the user after creating a record, the current values are correct.
In this case, the system behaves inconsistently. For example, in the Sales Invoice Lines tab, you can create lines without specifying anything. If you create a new line and then click on the close button, the line will not be saved. However, if you create the line, then change the quantity from 1 to 2, and then click on close, the line will be saved.
This is not consistent in my opinion. |
|
|
|
(0042448)
|
|
rgoris
|
|
2011-11-02 13:38
|
|
marvintm: if you create a new record and the defaults are good (to be saved) and you hit the save&close button, then it will be saved. Note that the button will both have the floppy (save) and the x (close) enabled.
So, summarizing
If the form can´t be saved: only close (only little x enabled)
If the form can be saved: save&close (both little x and floppy enabled)
If only the little x of the save&close button is enabled, then its behavior is exactly the same as when clikcing the big X close button in the top right. |
|
|
|
(0042450)
|
|
rgoris
|
2011-11-02 13:40
(edited on: 2011-11-02 13:41) |
|
see attached images for the difference. In the last case (close) it should do the same as the close (big X) in the top right of the form, which is abort/cancel, return to grid without creating anything
|
|
|
|
|
I didn't explain myself well enough. After the changes Martin did, the following happens:
- If you create a Sales Invoice Line in form view, and immediately click on the gray "x" button (the one shown in the first screenshot), the line is _not_ saved
- If you create a Sales Invoice Line in form view, change the quantity to 2, and click on the gray "x" button, the line IS saved.
This behaviour complies with the description Martin wrote in the comment 0042084, but in my opinion is clearly inconsistent, because the line was perfectly correct in both cases, and therefore it should have been saved in both. |
|
|
|
(0042456)
|
|
rgoris
|
|
2011-11-02 17:03
|
|
Correct but this has is related to the behavior of the form-close (big gray X) button and not the little x.
The little x now tries to save, this is not good. So first let´s fix this behavior (last image). The little X must cancel/abort the form creation.
The other case you mention can be fixed later, can you open a separate issue for that? |
|
|
|
|
|
|
|
|
|
1034311.png (84,311) 2011-10-11 18:27