Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018667Openbravo ERPA. Platformpublic2011-10-02 23:552011-11-12 16:00
Reporterrgoris 
Assigned Tomtaal 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP5Fixed in Version3.0MP5 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018667: Provide a reset-to-defaults for Personalized Forms
DescriptionForm personalization should offer the possibility to reset to defaults. This prevents the user from "messing it up without escape".
Steps To Reproducena
Proposed SolutionAdd button (orange process button) with "Restore Defaults".

Fields visibility and position now restore to defaults in the preview and lists.

No need for confirmation message as the form is not saved at this point (Cancel button can be pressed still to undo the restoring).

After a save the restore to defaults is final.
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0019035 acknowledged dbaz [KS] "Restore Defaults" form layoutter top right button can not be executed using keyboard shortcuts 
related to defect 0039269 acknowledged Triage Platform Base Form Personalization > Restore Defaults button does not work properly in some tabs 
Attached Filespng restore-defaults.png (93,810) 2011-10-02 23:55
https://issues.openbravo.com/file_download.php?file_id=4614&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-10-02 23:55rgorisNew Issue
2011-10-02 23:55rgorisAssigned To => mtaal
2011-10-02 23:55rgorisFile Added: restore-defaults.png
2011-10-02 23:55rgorisModules => Core
2011-10-23 00:17mtaalNote Added: 0041994
2011-10-23 00:17mtaalStatusnew => feedback
2011-10-24 15:36rgorisNote Added: 0042067
2011-10-24 15:38mtaalNote Added: 0042068
2011-10-27 10:19hgbotCheckin
2011-10-27 10:19hgbotNote Added: 0042134
2011-10-27 10:24mtaalStatusfeedback => scheduled
2011-10-27 10:24mtaalfix_in_branch => pi
2011-10-27 10:24mtaalStatusscheduled => resolved
2011-10-27 10:24mtaalFixed in Version => 3.0MP5
2011-10-27 10:24mtaalFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/cf2f8d1806afb5ae6b9858c6d4086047af8b646a [^]
2011-10-27 10:24mtaalResolutionopen => fixed
2011-11-02 12:09rgorisNote Added: 0042441
2011-11-02 12:09rgorisStatusresolved => new
2011-11-02 12:09rgorisResolutionfixed => open
2011-11-02 12:09rgorisFixed in Version3.0MP5 =>
2011-11-04 07:33hgbotCheckin
2011-11-04 07:33hgbotNote Added: 0042520
2011-11-04 13:35hgbotCheckin
2011-11-04 13:35hgbotNote Added: 0042542
2011-11-04 13:35hgbotStatusnew => resolved
2011-11-04 13:35hgbotResolutionopen => fixed
2011-11-04 13:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/cf2f8d1806afb5ae6b9858c6d4086047af8b646a [^] => http://code.openbravo.com/erp/devel/pi/rev/dc20400319104e9a231995896684e6cf4b1f70bd [^]
2011-11-04 13:57hudsonbotCheckin
2011-11-04 13:57hudsonbotNote Added: 0042576
2011-11-07 13:07rgorisNote Added: 0042654
2011-11-07 13:07rgorisStatusresolved => new
2011-11-07 13:07rgorisResolutionfixed => open
2011-11-08 20:44hgbotCheckin
2011-11-08 20:44hgbotNote Added: 0042681
2011-11-08 20:44hgbotStatusnew => resolved
2011-11-08 20:44hgbotResolutionopen => fixed
2011-11-08 20:44hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/dc20400319104e9a231995896684e6cf4b1f70bd [^] => http://code.openbravo.com/erp/devel/pi/rev/1816a1d26f54d85eaa1320faa4a383b94b032703 [^]
2011-11-09 10:15rgorisStatusresolved => closed
2011-11-10 01:28dbazRelationship addedrelated to 0019035
2011-11-12 15:47hgbotCheckin
2011-11-12 15:47hgbotNote Added: 0042760
2011-11-12 15:47hgbotCheckin
2011-11-12 15:47hgbotNote Added: 0042761
2011-11-12 15:47hgbotStatusclosed => resolved
2011-11-12 15:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/1816a1d26f54d85eaa1320faa4a383b94b032703 [^] => http://code.openbravo.com/erp/devel/pi/rev/394c05cf56536efcd78c4c5067bd35cdbaef9649 [^]
2011-11-12 15:47hgbotCheckin
2011-11-12 15:47hgbotNote Added: 0042764
2011-11-12 15:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/394c05cf56536efcd78c4c5067bd35cdbaef9649 [^] => http://code.openbravo.com/erp/devel/pi/rev/d644e677acda72abeaefdadaf6a23c2e68cdfda6 [^]
2011-11-12 15:48hudsonbotCheckin
2011-11-12 15:48hudsonbotNote Added: 0042771
2011-11-12 15:48hudsonbotCheckin
2011-11-12 15:48hudsonbotNote Added: 0042772
2011-11-12 15:48hudsonbotCheckin
2011-11-12 15:48hudsonbotNote Added: 0042785
2011-11-12 16:00shuehnerNote Added: 0042795
2011-11-12 16:00shuehnerStatusresolved => closed
2011-11-12 16:00shuehnerFixed in Version => 3.0MP5
2018-09-11 18:36caristuRelationship addedrelated to 0039269

Notes
(0041994)
mtaal   
2011-10-23 00:17   
Hi Rob,
Can you attach a png for the button and also the texts to use for the hover over the button?

gr. Martin
(0042067)
rgoris   
2011-10-24 15:36   
MArtin

This needs to be a regular orange process button. Would it be possible to use that type of button? So no need for graphical button.
(0042068)
mtaal   
2011-10-24 15:38   
Ha ok, see it now...
gr. Martin
(0042134)
hgbot   
2011-10-27 10:19   
Repository: erp/devel/pi
Changeset: cf2f8d1806afb5ae6b9858c6d4086047af8b646a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Oct 27 10:18:51 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cf2f8d1806afb5ae6b9858c6d4086047af8b646a [^]

Fixues issue 18667: Provide a reset-to-defaults for Personalized Forms

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views-toolbar.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js
---
(0042441)
rgoris   
2011-11-02 12:09   
As discussed, a few things remaining: add a view "Standard View" to the views list (bottom of top half) that is active by default when no other view is defined. This view cannot be overwritten and is always available. In the unlikely scenario that a user creates an additional view with the same name, there will be two views with the name "Standard View" then, dont bother building a check. The standard view (the real one) can never be deleted so does not appear in the delete view list, nor does it appear in the save as list.

Also:
en nog wat...in de form builder
[12:01:17 PM] Rob Goris: als je restore defaults indrukt
[12:02:02 PM] Rob Goris: dan restored ie hem wel. Maar hij wordt later niet gesaved...
[12:02:21 PM] Martin Taal: dus als je save indrukt ben je hem kwijt?
[12:02:35 PM] Rob Goris: probleem is dat ie geen save knop laat zien als je gerestored hebt
[12:03:23 PM] Rob Goris: hmmm. nu wel...wacht
[12:05:03 PM] Rob Goris: ja hier is het scenario: Sales Invoice > Form Builder > Move Organization naar statusbar sectie
[12:05:46 PM] Rob Goris: Save
[12:05:50 PM] Rob Goris: en Restore Default
(0042520)
hgbot   
2011-11-04 07:33   
Repository: erp/devel/pi
Changeset: d82869324dad50de6d2993a756d12b7eb8bd876b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Nov 04 07:33:29 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d82869324dad50de6d2993a756d12b7eb8bd876b [^]

Related to issue 18667: Provide a reset-to-defaults for Personalized Forms

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalization-treegrid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js
---
(0042542)
hgbot   
2011-11-04 13:35   
Repository: erp/devel/pi
Changeset: dc20400319104e9a231995896684e6cf4b1f70bd
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Nov 04 13:34:40 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/dc20400319104e9a231995896684e6cf4b1f70bd [^]

Fixes issue 18667: Provide a reset-to-defaults for Personalized Forms

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views-toolbar.js
---
(0042576)
hudsonbot   
2011-11-04 13:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test
(0042654)
rgoris   
2011-11-07 13:07   
Still not: Restore does not restore after a save. Try these steps:

Sales Invoice, form customization
Move field Organization to Status bar section
Save
Press Restore Defaults button
Nothing happens, organization field is not placed back in original section (only the status bar section collapses)
(0042681)
hgbot   
2011-11-08 20:44   
Repository: erp/devel/pi
Changeset: 1816a1d26f54d85eaa1320faa4a383b94b032703
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Nov 08 13:25:13 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1816a1d26f54d85eaa1320faa4a383b94b032703 [^]

Fixes issue 18667: Provide a reset-to-defaults for Personalized Forms

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js
---
(0042760)
hgbot   
2011-11-12 15:47   
Repository: erp/devel/pi
Changeset: 6989fea2297b42cf551c747645cfb264f9453f67
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Nov 04 07:33:29 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6989fea2297b42cf551c747645cfb264f9453f67 [^]

Related to issue 18667: Provide a reset-to-defaults for Personalized Forms

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalization-treegrid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js
---
(0042761)
hgbot   
2011-11-12 15:47   
Repository: erp/devel/pi
Changeset: 394c05cf56536efcd78c4c5067bd35cdbaef9649
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Nov 04 13:34:40 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/394c05cf56536efcd78c4c5067bd35cdbaef9649 [^]

Fixes issue 18667: Provide a reset-to-defaults for Personalized Forms

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views-toolbar.js
---
(0042764)
hgbot   
2011-11-12 15:47   
Repository: erp/devel/pi
Changeset: d644e677acda72abeaefdadaf6a23c2e68cdfda6
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Nov 08 13:25:13 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d644e677acda72abeaefdadaf6a23c2e68cdfda6 [^]

Fixes issue 18667: Provide a reset-to-defaults for Personalized Forms

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js
---
(0042771)
hudsonbot   
2011-11-12 15:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9752fe729257 [^]

Maturity status: Test
(0042772)
hudsonbot   
2011-11-12 15:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9752fe729257 [^]

Maturity status: Test
(0042785)
hudsonbot   
2011-11-12 15:48   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9752fe729257 [^]

Maturity status: Test
(0042795)
shuehner   
2011-11-12 16:00   
re-closing: has been reopened only because of code-line merge during mp5 release.