Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018640Openbravo ERP09. Financial managementpublic2011-09-28 16:022011-11-04 13:57
Reportermirurita 
Assigned Tomirurita 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018640: Invoice's Reference for Payment Description configured at org level not taking in account sales/purchase flows
Description'Invoice's Reference for Payment Description' is configured at organization level.
It allows to select whether the invoice document number or supplier reference number will be used for creating the payment description.
It is used also when generating the bank instructions when processing the remittance.

If you select for example 'Supplier reference' for a specific organization when you create a payment using this organization this payment will include the supplier reference although you are in sales flow.

Related issues: 17756, 18579, 17991
Steps To Reproduce1) Go to Organization window and select F&B US, Inc.
2) Go to Information tab
3) Select in Invoice's Reference for Payment Description combo Supplier reference and save.
4) Create a new Sales Invoice for F&B US, Inc. organization.
5) Create a Cuaderno 19 remittance.
6) Include previously created invoice.
7) Process the remittance (no grouping).
8) See created line in Instructions tab

Realize that for a sales invoice the reference number is used in the description.

does not make sense in sales flow.
Proposed SolutionTwo possible solutions:
1) Create separate fields in Organization || Information tab: one for sales an other for purchase.
2) Assume that in sales flow that always the Document Number is the 'reference' which drives the flow. Change FIN_Utility.getDesiredDocumentNo method.
If we go for the second option, I think the label of the field should change: 'Purchase Invoice's Reference for Payment Description'
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0018896 closed mirurita Invoice's Reference for Payment Description configured at org level not taking in account sales/purchase flows 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-09-28 16:02miruritaNew Issue
2011-09-28 16:02miruritaAssigned To => vmromanos
2011-09-28 16:02miruritaModules => Advanced Payables and Receivables Mngmt
2011-09-28 16:21miruritaProposed Solution updated
2011-09-28 16:32miruritaResolution time => 1320102000
2011-10-25 09:59jonalegriaesarteAssigned Tovmromanos => mirurita
2011-10-27 12:06hgbotCheckin
2011-10-27 12:06hgbotNote Added: 0042147
2011-10-27 12:06hgbotStatusnew => resolved
2011-10-27 12:06hgbotResolutionopen => fixed
2011-10-27 12:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0dea693db7648a85859ae1bc3d859a06e68b633e [^]
2011-10-27 12:08miruritaStatusresolved => new
2011-10-27 12:08miruritaResolutionfixed => open
2011-10-27 12:08miruritaStatusnew => scheduled
2011-10-27 12:08miruritafix_in_branch => pi
2011-10-27 12:08miruritaStatusscheduled => resolved
2011-10-27 12:08miruritaResolutionopen => fixed
2011-11-04 12:35maiteNote Added: 0042536
2011-11-04 12:35maiteStatusresolved => closed
2011-11-04 13:57hudsonbotCheckin
2011-11-04 13:57hudsonbotNote Added: 0042580

Notes
(0042147)
hgbot   
2011-10-27 12:06   
Repository: erp/devel/pi
Changeset: 0dea693db7648a85859ae1bc3d859a06e68b633e
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Thu Oct 27 12:04:26 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0dea693db7648a85859ae1bc3d859a06e68b633e [^]

Fixes issue 18640: Invoice's Reference for Payment Description problem.
Invoice's Reference for Payment Description configured at org level not taking in account sales/purchase flows.
If you select for example 'Supplier reference' for a specific organization when you create a payment using this
organization this payment will include the supplier reference although you are in sales flow.
Fix: Assume that in sales flow that always the Document Number is the 'reference' which drives the flow.
Label changed to Purchase Invoice's Reference for Payment Description

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_ELEMENT.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
---
(0042536)
maite   
2011-11-04 12:35   
verified
(0042580)
hudsonbot   
2011-11-04 13:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test