Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018592Openbravo ERPA. Platformpublic2011-09-22 14:542011-10-12 02:01
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP4Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018592: Yes/No filter combo shows double values after filtering
DescriptionSee the attached screenshot
Steps To Reproduce1) go to module window
2) scroll to the 'in development' column
3) filter on Yes
4) re-open the filter combo, multiple Yes entries are shown
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot-15.png (15,996) 2011-09-22 14:54
https://issues.openbravo.com/file_download.php?file_id=4590&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-09-22 14:54mtaalNew Issue
2011-09-22 14:54mtaalAssigned To => mtaal
2011-09-22 14:54mtaalFile Added: Screenshot-15.png
2011-09-22 14:54mtaalModules => Core
2011-09-23 07:44hgbotCheckin
2011-09-23 07:44hgbotNote Added: 0041248
2011-09-23 07:44hgbotStatusnew => resolved
2011-09-23 07:44hgbotResolutionopen => fixed
2011-09-23 07:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8bed3d97fec0fe1150874f173b44e659d58dec20 [^]
2011-10-03 11:57marvintmNote Added: 0041450
2011-10-03 11:57marvintmStatusresolved => new
2011-10-03 11:57marvintmResolutionfixed => open
2011-10-04 11:33hgbotCheckin
2011-10-04 11:33hgbotNote Added: 0041484
2011-10-04 11:33hgbotStatusnew => resolved
2011-10-04 11:33hgbotResolutionopen => fixed
2011-10-04 11:33hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/8bed3d97fec0fe1150874f173b44e659d58dec20 [^] => http://code.openbravo.com/erp/devel/pi/rev/935c3e3fe26d9b73af3b3d5a717a50f2421092f6 [^]
2011-10-04 16:18marvintmStatusresolved => closed
2011-10-12 01:59hudsonbotCheckin
2011-10-12 01:59hudsonbotNote Added: 0041699
2011-10-12 02:01hudsonbotCheckin
2011-10-12 02:01hudsonbotNote Added: 0041750

Notes
(0041248)
hgbot   
2011-09-23 07:44   
Repository: erp/devel/pi
Changeset: 8bed3d97fec0fe1150874f173b44e659d58dec20
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 23 07:43:45 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8bed3d97fec0fe1150874f173b44e659d58dec20 [^]

Fixes issue 18592: Yes/No filter combo shows double values after filtering
Correctly translate string values to booleans

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list-filter.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-yesno.js
---
(0041450)
marvintm   
2011-10-03 11:57   
When you pick 'Yes', the grid is filtered by that value (correct(). However, if you click once on the filter combo again, even if you don't select anything, the filtered value is cleared, and the grid is again shown unfiltered.

I think this is wrong, the filter shouldn't change if you only open the combo, and moreover, if after clicking on the combo to open it, you click outside the combo, the filter should remain as it was before you opened the combo. The filter should only change if you select one of the values in the combo.
(0041484)
hgbot   
2011-10-04 11:33   
Repository: erp/devel/pi
Changeset: 935c3e3fe26d9b73af3b3d5a717a50f2421092f6
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Oct 04 11:33:18 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/935c3e3fe26d9b73af3b3d5a717a50f2421092f6 [^]

Fixes issue 18592: Yes/No filter combo shows double values after filtering
AddUnknownValues is set to false, need to override implement isUnknownValue method in that case

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-yesno.js
---
(0041699)
hudsonbot   
2011-10-12 01:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041750)
hudsonbot   
2011-10-12 02:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test