Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018587Openbravo ERPA. Platformpublic2011-09-21 19:362011-10-12 02:00
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP4Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018587: Changes/improvement saved and named views
Description1) get rid of the orange border in the popup menu in chrome, set outline: none on the style of the body of the flyout. Is the same as this issue:
https://issues.openbravo.com/view.php?id=18501 [^]

2) Store collapsed/expanded sections on form level

3) only enable saved view for premium/professional

4) include the user level in the combobox when saving a view (currently the user level is there but it is shown with displayvalue empty), see attached screenshot
REMARK MT:
Regarding your last email about adding 'User' to the combo, I need to think about that. These combos are *only* shown when you are the administrator, normal users will never see them.

5) Generic:
- Filter criteria are not saved: The first and biggest usability issue is that when a view is saved, and later called upon, it is not clear what the filter criteria were. Can you save them along with the view and reprint them as you retrieve the view? So if you use the filter Quote in the transaction document column filter, then show it at all times.
- The hover text is too long which distracts too much (this is a problem with most buttons as we want to be too precise). Rewrite it to "Save view" as this is all the user needs to know at this point. Hover texts are hints, not user manuals...

5) Flyout menu:
- Use a check mark to indictate the active view. Avoid asterisk symbols as this is used to indicate a New status (form, shortcuts, quickmenu)
- Styling: attached a polished version

6) Save view dialog:
- Replace label View* with Save as* in the Save View dialog. Save as... is a well know pattern
- Only show the Value field when there is a levels selected. For most users Level/Value is something they will never use and too much information only confuses them
- Rename Default View to Set as Default
- Enable keyboard shorcuts. Hitting Enter after having entered a view name must work.
- The confirmation message "The view state has been saved." is not necessary. Saving is what the user wanted and is supposed to succeed without outcome confirmation
- The confirmation message "The view has been deleted." is not necessary. Deleting is what the user wanted and is supposed to succeed without outcome confirmation
- More space between the buttons and place them a bit lower

7) Delete view dialog:
- More space between the buttons and place them a bit lower
- Show the currently active view as the default value in the dropdown menu (it is very likely that the user intends to delete that one)

8) Set default view:
- More space between the buttons and place them a bit lower
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng orange_border.png (7,530) 2011-09-21 19:36
https://issues.openbravo.com/file_download.php?file_id=4585&type=bug
png

png flyout_styling.png (14,134) 2011-09-21 19:36
https://issues.openbravo.com/file_download.php?file_id=4586&type=bug
png

png ActiveViewIcon.png (147) 2011-09-21 19:36
https://issues.openbravo.com/file_download.php?file_id=4587&type=bug
png

png IncludeUserLevel.png (20,705) 2011-09-21 19:36
https://issues.openbravo.com/file_download.php?file_id=4588&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-09-21 19:36mtaalNew Issue
2011-09-21 19:36mtaalAssigned To => mtaal
2011-09-21 19:36mtaalFile Added: orange_border.png
2011-09-21 19:36mtaalModules => Core
2011-09-21 19:36mtaalFile Added: flyout_styling.png
2011-09-21 19:36mtaalFile Added: ActiveViewIcon.png
2011-09-21 19:36mtaalFile Added: IncludeUserLevel.png
2011-09-28 16:37hgbotCheckin
2011-09-28 16:37hgbotNote Added: 0041348
2011-09-28 16:48hgbotCheckin
2011-09-28 16:48hgbotNote Added: 0041350
2011-09-28 17:40hgbotCheckin
2011-09-28 17:40hgbotNote Added: 0041357
2011-09-30 13:21hgbotCheckin
2011-09-30 13:21hgbotNote Added: 0041410
2011-09-30 13:21hgbotCheckin
2011-09-30 13:21hgbotNote Added: 0041411
2011-09-30 13:21hgbotCheckin
2011-09-30 13:21hgbotNote Added: 0041412
2011-09-30 13:21hgbotCheckin
2011-09-30 13:21hgbotNote Added: 0041413
2011-09-30 13:21hgbotCheckin
2011-09-30 13:21hgbotNote Added: 0041414
2011-09-30 13:21hgbotCheckin
2011-09-30 13:21hgbotNote Added: 0041415
2011-09-30 13:21hgbotCheckin
2011-09-30 13:21hgbotNote Added: 0041416
2011-09-30 13:21hgbotCheckin
2011-09-30 13:21hgbotNote Added: 0041417
2011-09-30 13:21hgbotCheckin
2011-09-30 13:21hgbotNote Added: 0041418
2011-09-30 13:21hgbotStatusnew => resolved
2011-09-30 13:21hgbotResolutionopen => fixed
2011-09-30 13:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/804dae13b1c7bb6c05dac0c55dc2f87ffbceccfe [^]
2011-09-30 14:31rgorisStatusresolved => closed
2011-10-12 01:59hudsonbotCheckin
2011-10-12 01:59hudsonbotNote Added: 0041723
2011-10-12 01:59hudsonbotCheckin
2011-10-12 01:59hudsonbotNote Added: 0041724
2011-10-12 01:59hudsonbotCheckin
2011-10-12 01:59hudsonbotNote Added: 0041727
2011-10-12 01:59hudsonbotCheckin
2011-10-12 01:59hudsonbotNote Added: 0041732
2011-10-12 01:59hudsonbotCheckin
2011-10-12 01:59hudsonbotNote Added: 0041733
2011-10-12 01:59hudsonbotCheckin
2011-10-12 01:59hudsonbotNote Added: 0041734
2011-10-12 01:59hudsonbotCheckin
2011-10-12 01:59hudsonbotNote Added: 0041735
2011-10-12 01:59hudsonbotCheckin
2011-10-12 01:59hudsonbotNote Added: 0041736
2011-10-12 02:00hudsonbotCheckin
2011-10-12 02:00hudsonbotNote Added: 0041737
2011-10-12 02:00hudsonbotCheckin
2011-10-12 02:00hudsonbotNote Added: 0041738
2011-10-12 02:00hudsonbotCheckin
2011-10-12 02:00hudsonbotNote Added: 0041739
2011-10-12 02:00hudsonbotCheckin
2011-10-12 02:00hudsonbotNote Added: 0041740

Notes
(0041348)
hgbot   
2011-09-28 16:37   
Repository: erp/devel/pi
Changeset: be2d028b01bca56d088b80509ff60dab8718f3b5
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 28 16:36:34 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/be2d028b01bca56d088b80509ff60dab8718f3b5 [^]

Related to issue 18587: Changes/improvement saved and named views
Form layout changes are now also saved

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js
---
(0041350)
hgbot   
2011-09-28 16:48   
Repository: erp/devel/pi
Changeset: c3d7071d4d691bb7f25f99056acd4158e1a46e0c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 28 16:48:16 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c3d7071d4d691bb7f25f99056acd4158e1a46e0c [^]

Related to issue 18587: Changes/improvement saved and named views
Moved check on prof edition to utility
Moved styling info to styling js

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views-toolbar.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form-toolbar-button.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-personalization-styles.js
---
(0041357)
hgbot   
2011-09-28 17:40   
Repository: erp/devel/pi
Changeset: 50d7044397a51bde083aefc1e9ab8fc642017264
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Sep 28 17:40:28 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/50d7044397a51bde083aefc1e9ab8fc642017264 [^]

Related to issue 18587: Changes/improvement saved and named views
Prevent empty menu for community instance

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views-toolbar.js
---
(0041410)
hgbot   
2011-09-30 13:21   
Repository: erp/devel/pi
Changeset: 511718c694780eb327c92f8998958dc7257b1a5f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 30 13:12:37 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/511718c694780eb327c92f8998958dc7257b1a5f [^]

Related to issue 18587: Changes/improvement saved and named views
Changed styling of hover over pull down menu

---
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-personalization-styles.css
---
(0041411)
hgbot   
2011-09-30 13:21   
Repository: erp/devel/pi
Changeset: d064a9711b5c81ac9ed08b57b831c9c6a9029651
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 30 13:13:09 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d064a9711b5c81ac9ed08b57b831c9c6a9029651 [^]

Related to issue 18587: Changes/improvement saved and named views
Shortened hover texts

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
---
(0041412)
hgbot   
2011-09-30 13:21   
Repository: erp/devel/pi
Changeset: 5483e06909d7ffa71637c24e18ece18d52662e38
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 30 13:13:35 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5483e06909d7ffa71637c24e18ece18d52662e38 [^]

Related to issue 18587: Changes/improvement saved and named views
Prevent NPE

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/personalization/PersonalizationActionHandler.java
---
(0041413)
hgbot   
2011-09-30 13:21   
Repository: erp/devel/pi
Changeset: b8baeaa8bccd8d46966b3fbcd98af7c4ac796e9a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 30 13:14:58 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b8baeaa8bccd8d46966b3fbcd98af7c4ac796e9a [^]

Related to issue 18587: Changes/improvement saved and named views
Solve hide of filter criteria in specific case when saved view with filter is the default

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0041414)
hgbot   
2011-09-30 13:21   
Repository: erp/devel/pi
Changeset: 31d2fe0477101020f92907e2bd9e4f4142ef7d73
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 30 13:15:34 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/31d2fe0477101020f92907e2bd9e4f4142ef7d73 [^]

Related to issue 18587: Changes/improvement saved and named views
Prevent starred wrench icon

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form-toolbar-button.js
---
(0041415)
hgbot   
2011-09-30 13:21   
Repository: erp/devel/pi
Changeset: 229973b433bd5156fb8049f64f3f33b399f67da0
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 30 13:17:17 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/229973b433bd5156fb8049f64f3f33b399f67da0 [^]

Related to issue 18587: Changes/improvement saved and named views
Also save expanded/collapsed state of a section

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalization-treegrid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js
---
(0041416)
hgbot   
2011-09-30 13:21   
Repository: erp/devel/pi
Changeset: f0f7d260a6715e924bf3cc9a129ea112c93a44a5
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 30 13:19:02 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f0f7d260a6715e924bf3cc9a129ea112c93a44a5 [^]

Related to issue 18587: Changes/improvement saved and named views
Only disable button if preference set, no views available and user is not an admin

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views-toolbar.js
---
(0041417)
hgbot   
2011-09-30 13:21   
Repository: erp/devel/pi
Changeset: 515bf7b7dcc64d8bb6be39702754eae894fd3ffb
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 30 13:20:05 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/515bf7b7dcc64d8bb6be39702754eae894fd3ffb [^]

Related to issue 18587: Changes/improvement saved and named views
Save also expanded/collapsed state

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalization.js
---
(0041418)
hgbot   
2011-09-30 13:21   
Repository: erp/devel/pi
Changeset: 804dae13b1c7bb6c05dac0c55dc2f87ffbceccfe
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 30 13:20:27 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/804dae13b1c7bb6c05dac0c55dc2f87ffbceccfe [^]

Fixes issue 18587: Changes/improvement saved and named views

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-manage-views-popups.js
---
(0041723)
hudsonbot   
2011-10-12 01:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041724)
hudsonbot   
2011-10-12 01:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041727)
hudsonbot   
2011-10-12 01:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041732)
hudsonbot   
2011-10-12 01:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041733)
hudsonbot   
2011-10-12 01:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041734)
hudsonbot   
2011-10-12 01:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041735)
hudsonbot   
2011-10-12 01:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041736)
hudsonbot   
2011-10-12 01:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041737)
hudsonbot   
2011-10-12 02:00   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041738)
hudsonbot   
2011-10-12 02:00   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041739)
hudsonbot   
2011-10-12 02:00   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041740)
hudsonbot   
2011-10-12 02:00   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test