Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018504Openbravo ERPB. User interfacepublic2011-09-12 15:462012-04-02 06:11
Reporterpsanjuan 
Assigned Toalostale 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 8.04.1
Product Versionpi 
Target VersionFixed in Version3.0MP10 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserInternet Explorer
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018504: Application Dictionary - Some windows are added to Roles when it shouldn't
DescriptionApplication Dictionary - Reference
Application dictionary - Navigation bar components
Application dictionary - View implementation

1. Windows should not be added to the newly role when performing Initial Client Setup
2. The same when creating a role which is not marked as manual

It seems there is a problem with the definition of the tables
Steps To Reproduce1. Execute initial client setup. Notice that these three windows are added to the newly role. THIS IS WRONG
2. Create a role with the flag Manual not marked. Notice that when saving the record these three windows are added to the role
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng 18504_1.png (63,151) 2011-09-12 15:53
https://issues.openbravo.com/file_download.php?file_id=4534&type=bug
png

png 18504_2.png (53,367) 2011-09-12 15:53
https://issues.openbravo.com/file_download.php?file_id=4535&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-09-12 15:46psanjuanNew Issue
2011-09-12 15:46psanjuanAssigned To => dbaz
2011-09-12 15:46psanjuanWeb browser => Internet Explorer
2011-09-12 15:46psanjuanModules => Core
2011-09-12 15:50psanjuanWeb browserInternet Explorer => Internet Explorer
2011-09-12 15:50psanjuanSummaryApplication Dictionary - Reference window should be removed for the Admin user => Application Dictionary - Reference window should be removed for the "Admin" users but for System Admin user.
2011-09-12 15:50psanjuanDescription Updatedbug_revision_view_page.php?rev_id=2691#r2691
2011-09-12 15:50psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=2693#r2693
2011-09-12 15:53psanjuanFile Added: 18504_1.png
2011-09-12 15:53psanjuanFile Added: 18504_2.png
2011-09-22 13:32iperdomoRelationship addedduplicate of 0018324
2011-09-22 13:32iperdomoStatusnew => closed
2011-09-22 13:32iperdomoResolutionopen => duplicate
2012-03-23 12:16psarobeRelationship deleted0018324
2012-03-23 12:17psarobeAssigned Todbaz => alostale
2012-03-23 12:17psarobeStatusclosed => new
2012-03-23 12:17psarobeResolutionduplicate => open
2012-03-23 12:22psarobeWeb browserInternet Explorer => Internet Explorer
2012-03-23 12:22psarobePriorityhigh => urgent
2012-03-23 12:22psarobeStatusnew => scheduled
2012-03-23 12:22psarobeversion => pi
2012-03-23 12:22psarobeTarget Version3.0MP6 =>
2012-03-23 12:22psarobeDescription Updatedbug_revision_view_page.php?rev_id=3298#r3298
2012-03-23 12:22psarobeSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3299#r3299
2012-03-23 12:23psarobeWeb browserInternet Explorer => Internet Explorer
2012-03-23 12:23psarobeSummaryApplication Dictionary - Reference window should be removed for the "Admin" users but for System Admin user. => Application Dictionary - Some windows are added to Roles when it shouldn't
2012-03-23 14:27alostaleNote Added: 0046690
2012-03-23 14:28hgbotCheckin
2012-03-23 14:28hgbotNote Added: 0046691
2012-03-23 14:28hgbotStatusscheduled => resolved
2012-03-23 14:28hgbotResolutionopen => fixed
2012-03-23 14:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5acb2f2f35054e9f8d22f8f1954243c342d896b5 [^]
2012-03-28 17:39guilleaerNote Added: 0046852
2012-03-28 17:39guilleaerStatusresolved => closed
2012-03-28 17:39guilleaerFixed in Version => 3.0MP10
2012-04-02 06:11hudsonbotCheckin
2012-04-02 06:11hudsonbotNote Added: 0047215

Notes
(0046690)
alostale   
2012-03-23 14:27   
Changed the logic to assign windows on role creation to work in the same way update access does. Role creation granted access to all windows having at least one tab with a table of the same level as the new role, whereas update access process takes into account only the level of the first tab of the window.

After this fix update access process and role creation should grant access to the same windows.

This fix adds no risk because it makes trigger to work in the same way as update access process does.


Test plan:
 -Verify steps to reproduce are fixed
 -Verify role creation and update access grant same access:
   -Crate automatic roles for each of the possible levels
   -List the granted windows
   -Delete all granted windows and execute update access process
   -Check the granted windows now are the same as before deleting
(0046691)
hgbot   
2012-03-23 14:28   
Repository: erp/devel/pi
Changeset: 5acb2f2f35054e9f8d22f8f1954243c342d896b5
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 23 14:22:43 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5acb2f2f35054e9f8d22f8f1954243c342d896b5 [^]

fixed bug 18504: Some windows are added to Roles when it shouldn't

 Changed the logic to assign windows on role creation to work in the same
 way update access does. Role creation granted access to all windows having
 at least one tab with a table of the same level as the new role, whereas
 update access process takes into account only the level of the first tab
 of the window.

---
M src-db/database/model/triggers/AD_ROLE_TRG.xml
---
(0046852)
guilleaer   
2012-03-28 17:39   
Code reviewed and tested using oracle and postgresql in pi@5438f39cd047
(0047215)
hudsonbot   
2012-04-02 06:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test