Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0018501Openbravo ERPB. User interfacepublic2011-09-12 12:142011-12-13 16:43
dbaz 
dbaz 
urgentmajoralways
closedfixed 
5
 
3.0MP7 
Google Chrome
Core
No
0018501: New orange lines appears when the grid/form has the focus
Only in Google Chrome.

New orange lines appears when the grid/form has the focus but there is no focused input.

Also in "Workspace" tab button when is selected, in "User Options" -> "Organization" combo when is opened.

See attached screenshots.

It seems that recent SC update has activated some kind of outline CSS property for these elements.

Something like

input:focus {
  outline: none;
}

but applied to these components (they are not inputs) could be needed
Go to any form/grid and ensure that no input is focused.
No tags attached.
png Top-Right in Form.png (146,499) 2011-09-12 12:14
https://issues.openbravo.com/file_download.php?file_id=4532&type=bug
png

png In the middle of the Grid.png (146,540) 2011-09-12 12:15
https://issues.openbravo.com/file_download.php?file_id=4533&type=bug
png
Issue History
2011-09-12 12:14dbazNew Issue
2011-09-12 12:14dbazAssigned To => mtaal
2011-09-12 12:14dbazFile Added: Top-Right in Form.png
2011-09-12 12:14dbazModules => Core
2011-09-12 12:15dbazFile Added: In the middle of the Grid.png
2011-09-13 15:29dbazWeb browser => Google Chrome
2011-09-13 15:29dbazDescription Updatedbug_revision_view_page.php?rev_id=2699#r2699
2011-09-20 12:01hgbotCheckin
2011-09-20 12:01hgbotNote Added: 0041124
2011-09-20 14:37mtaalNote Added: 0041134
2011-09-23 07:19hgbotCheckin
2011-09-23 07:19hgbotNote Added: 0041246
2011-09-23 07:20mtaalNote Added: 0041247
2011-09-23 07:20mtaalWeb browserGoogle Chrome => Google Chrome
2011-09-23 07:20mtaalTarget Version3.0MP4 => 3.0MP5
2011-09-28 17:42mtaalWeb browserGoogle Chrome => Google Chrome
2011-09-28 17:42mtaalAssigned Tomtaal => dbaz
2011-09-28 17:42mtaalTarget Version3.0MP5 =>
2011-10-12 01:58hudsonbotCheckin
2011-10-12 01:58hudsonbotNote Added: 0041685
2011-10-12 01:59hudsonbotCheckin
2011-10-12 01:59hudsonbotNote Added: 0041698
2011-12-08 02:32dbazNote Added: 0043742
2011-12-09 11:43hgbotCheckin
2011-12-09 11:43hgbotNote Added: 0043758
2011-12-09 11:43hgbotStatusnew => resolved
2011-12-09 11:43hgbotResolutionopen => fixed
2011-12-09 11:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/048096c51f60b0959c141d8016f0356051f512f6 [^]
2011-12-09 12:21rgorisNote Added: 0043764
2011-12-12 10:05mtaalNote Added: 0043777
2011-12-12 10:05mtaalStatusresolved => closed
2011-12-12 10:05mtaalFixed in Version => 3.0MP7
2011-12-13 16:43hudsonbotCheckin
2011-12-13 16:43hudsonbotNote Added: 0043831

Notes
(0041124)
hgbot   
2011-09-20 12:01   
Repository: erp/devel/pi
Changeset: 70f36f70757925dfcfcb5ab49723598856052dec
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Sep 20 11:59:59 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/70f36f70757925dfcfcb5ab49723598856052dec [^]

Related to issue 18501: New orange lines appears when the grid/form has the focus
Prevent outline from showing in Chrome

---
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-form-styles.css
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-grid-styles.css
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-tab-styles.css
---
(0041134)
mtaal   
2011-09-20 14:37   
Solved for the grid and form, need to be solved for comboboxes also, is related to this question on the smartclient forum:
http://forums.smartclient.com/showthread.php?t=18855 [^]
(0041246)
hgbot   
2011-09-23 07:19   
Repository: erp/devel/pi
Changeset: 4a26324524c5ddf7a894110d8950ed52b0e774bd
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 23 07:19:08 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4a26324524c5ddf7a894110d8950ed52b0e774bd [^]

Related to issue 18501: New orange lines appears when the grid/form has the focus
Workaround for MP4, can be solved when upgrading SC in a next MP

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-user-profile-widget.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-form-styles.css
---
(0041247)
mtaal   
2011-09-23 07:20   
Workaround for MP4, need to upgrade SC after 1 October (as they say they will solve it then).

SC will happen again in MP5 probably. At that time remove workaround and test issue.
(0041685)
hudsonbot   
2011-10-12 01:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041698)
hudsonbot   
2011-10-12 01:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0043742)
dbaz   
2011-12-08 02:32   
Notice that IE dotted outlines can NOT be removed, since, by the moment, we use IE7 emulation.

Removing dotted outlines in IE7 requires deep js DOM manipulation using "hideFocus" attribute (unthinkable to apply using the Smartclient environment).

Once HTML5 tag attribute be in place and we get rid of IE7 emulation, it will be fixed.
(0043758)
hgbot   
2011-12-09 11:43   
Repository: erp/devel/pi
Changeset: 048096c51f60b0959c141d8016f0356051f512f6
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Thu Dec 08 02:35:24 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/048096c51f60b0959c141d8016f0356051f512f6 [^]

Fixed issue 18501: Removed orange outlines added by Chrome to focused items

---
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-application-styles.css
---
(0043764)
rgoris   
2011-12-09 12:21   
tested and works fine
(0043777)
mtaal   
2011-12-12 10:05   
Reviewed
(0043831)
hudsonbot   
2011-12-13 16:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8a06361cc265 [^]

Maturity status: Test