Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0018467Openbravo ERPA. Platformpublic2011-09-08 10:162011-09-30 16:19
mtaal 
mtaal 
normalminorhave not tried
closedfixed 
5
 
3.0MP4 
Core
No
0018467: API change for performance improvements (int-api/2364)
In reference to: http://builds.openbravo.com/job/int-api/2364/console [^]

Currently the generation of field definitions, used in the form/grid in the UI, is spread over several classes with duplicate code. The result is that also too much javascript is generated. There are clear and easy performance benefits to improve this. For improving this the idea is to centralize the generation of field definitions and only send one set of fields per tab, from the server to the client.

The above proposal means that code needs to be moved/combined which is now present in several classes and will mean an api change.

The change that anyone has ever extended or directly used this api is practically zero. The components in questions are used from Openbravo templates, it does not at all make sense for a third party to directly call these components.

So the risk of this change is (imv) very very small.

The api change is in the classes in the org.openbravo.client.application.window package.
.
No tags attached.
related to defect 00184703.0MP4 closed mtaal Performance: generate smaller javascript for a window, improve view generation performance 
Issue History
2011-09-08 10:16mtaalNew Issue
2011-09-08 10:16mtaalAssigned To => iciordia
2011-09-08 10:16mtaalModules => Core
2011-09-08 21:22iciordiaNote Added: 0040825
2011-09-08 21:23iciordiaAssigned Toiciordia => mtaal
2011-09-11 02:15hgbotCheckin
2011-09-11 02:15hgbotNote Added: 0040853
2011-09-11 02:15hgbotStatusnew => resolved
2011-09-11 02:15hgbotResolutionopen => fixed
2011-09-11 02:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/c3545d1b4beefd42ae93143cf80607c73f78fea3 [^]
2011-09-11 14:36hgbotCheckin
2011-09-11 14:36hgbotNote Added: 0040891
2011-09-11 14:41shuehnerNote Added: 0040892
2011-09-11 14:41shuehnerStatusresolved => new
2011-09-11 14:41shuehnerResolutionfixed => open
2011-09-11 15:51shuehnerSummaryAPI change for performance improvements => API change for performance improvements (int-api/2364)
2011-09-11 15:51shuehnerDescription Updatedbug_revision_view_page.php?rev_id=2681#r2681
2011-09-11 15:56shuehnerRelationship addedrelated to 0018470
2011-09-11 16:05hgbotCheckin
2011-09-11 16:05hgbotNote Added: 0040895
2011-09-11 16:05hgbotStatusnew => resolved
2011-09-11 16:05hgbotResolutionopen => fixed
2011-09-11 16:05hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/api-checks/rev/c3545d1b4beefd42ae93143cf80607c73f78fea3 [^] => http://code.openbravo.com/erp/devel/api-checks/rev/953ab4795e17daf3eb6568a945e38fe8ce921697 [^]
2011-09-30 16:19iperdomoStatusresolved => closed

Notes
(0040825)
iciordia   
2011-09-08 21:22   
Appoved. Ismael
(0040853)
hgbot   
2011-09-11 02:15   
Repository: erp/devel/api-checks
Changeset: c3545d1b4beefd42ae93143cf80607c73f78fea3
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Sep 11 02:14:22 2011 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/c3545d1b4beefd42ae93143cf80607c73f78fea3 [^]

Fixes issue 18467: API change for performance improvements

---
M java/reference/java.japi.gz
---
(0040891)
hgbot   
2011-09-11 14:36   
Repository: erp/devel/api-checks
Changeset: a8d5eb06df60cc8142e8d7f437c73a5218c199fb
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Sep 11 14:34:47 2011 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/a8d5eb06df60cc8142e8d7f437c73a5218c199fb [^]

Backed out changeset c3545d1b4bee
Issue 18467 backed out as was created in unclean local environment.

---
M java/reference/java.japi.gz
---
(0040892)
shuehner   
2011-09-11 14:41   
Reopened as inital commit needed to be backed out (done in unclean local environment).
(0040895)
hgbot   
2011-09-11 16:05   
Repository: erp/devel/api-checks
Changeset: 953ab4795e17daf3eb6568a945e38fe8ce921697
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Sep 11 16:04:18 2011 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/953ab4795e17daf3eb6568a945e38fe8ce921697 [^]

Fixed 18467: Re-ack api changes triggered by view generation perf work

---
M java/reference/java.japi.gz
M model/modules/org.openbravo.client.application/src-db/database/sourcedata/OBCLKER_TEMPLATE_DEPENDENCY.xml
---