Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018454Openbravo ERPA. Platformpublic2011-09-07 13:472011-11-04 13:56
Reporterrgoris 
Assigned Tomtaal 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP5Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018454: [Processes & Pickers] Process buttons are visible even when not actionable
DescriptionProcess buttons should only be made visible when they can actually be used successfully. This is not the case, they are shown for incomplete forms and using them leads to errors.
Steps To ReproduceCreate a new sales invoice.
Press COMPLETE button.
Watch error festival.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0017328 new Triage Platform Base [Processes & Pickers] Combination Process Buttons + Lose Process Windows 
has duplicate feature request 00184553.0MP5 closed mtaal Replace all error messages with in-window messages 
related to defect 00193823.0MP8 closed alostale The flag "Trigger Autosave" is not being considered 
Attached Filespng ProcessButtonsNot.PNG (71,506) 2011-09-07 13:47
https://issues.openbravo.com/file_download.php?file_id=4521&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-09-07 13:47rgorisNew Issue
2011-09-07 13:47rgorisAssigned To => alostale
2011-09-07 13:47rgorisFile Added: ProcessButtonsNot.PNG
2011-09-07 13:47rgorisModules => Core
2011-09-27 13:03alostaleTarget Version3.0MP4 => 3.0MP5
2011-10-10 19:14rgorisStatusnew => scheduled
2011-10-10 19:14rgorisfix_in_branch => pi
2011-10-10 19:38rgorisRelationship addedrelated to 0017328
2011-10-10 19:42rgorisAssigned Toalostale => mtaal
2011-10-14 09:31rgorisfix_in_branchpi =>
2011-10-14 09:31rgorisSummaryProcess buttons are visible even when not actionable => [Processes & Pickers] Process buttons are visible even when not actionable
2011-10-17 13:28rgorisRelationship addedrelated to 0018455
2011-10-23 00:00mtaalRelationship replacedhas duplicate 0018455
2011-10-23 00:04mtaalNote Added: 0041991
2011-10-26 20:03hgbotCheckin
2011-10-26 20:03hgbotNote Added: 0042127
2011-10-26 20:03hgbotStatusscheduled => resolved
2011-10-26 20:03hgbotResolutionopen => fixed
2011-10-26 20:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/14583e731ec17d7ddb96557e0cd369ad88613a74 [^]
2011-11-02 11:45rgorisNote Added: 0042439
2011-11-02 11:45rgorisStatusresolved => closed
2011-11-04 13:56hudsonbotCheckin
2011-11-04 13:56hudsonbotNote Added: 0042572
2011-12-28 12:21jecharriRelationship addedrelated to 0019382

Notes
(0041991)
mtaal   
2011-10-23 00:04   
The validation of the form happens when clicking the process button and not earlier.

What possibly could be done is show the buttons when all required fields have a value and not earlier.

At least a failing save should prevent the popup from actually happening.

gr. Martin
(0042127)
hgbot   
2011-10-26 20:03   
Repository: erp/devel/pi
Changeset: 14583e731ec17d7ddb96557e0cd369ad88613a74
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Oct 26 20:03:26 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/14583e731ec17d7ddb96557e0cd369ad88613a74 [^]

Fixes issue 18454: [Processes & Pickers] Process buttons are visible even when not actionable

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0042439)
rgoris   
2011-11-02 11:45   
great solution
(0042572)
hudsonbot   
2011-11-04 13:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test