Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018436Openbravo ERPA. Platformpublic2011-09-06 08:562011-09-21 18:30
Reporteralostale 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version2.50MP24 
Target Version2.50MP34Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018436: 2.50 grid, cursors in Oracle are not reused
DescriptionIn 2.50 grid using Oracle as DB, the generated SQL includes in the query string the pagination paramenters instead of being prepared statement paremeters. This causes many different cursors creation each time scroll is done in any grid making thus them not reusable.
Steps To ReproduceHaving a big amount of records and in a complex tab first time data is requested the query is slow. If the cursor is properly reused next time, the query should be faster.
Proposed SolutionPartially rollback issue 0009641 for the Oracle query generation.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0018585 closed alostale Grid shows a Javascript error alert when you scroll down to the last record 
blocks defect 0018435 closed alostale 2.50 grid, cursors in Oracle are not reused 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-09-06 08:57alostaleTypedefect => backport
2011-09-06 08:57alostalefix_in_branch => 2.50
2011-09-06 09:43hgbotCheckin
2011-09-06 09:43hgbotNote Added: 0040756
2011-09-06 09:43hgbotStatusscheduled => resolved
2011-09-06 09:43hgbotResolutionopen => fixed
2011-09-06 09:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.50/rev/4b2156ebe0dade865b1286fe0e6f624d700ed8ce [^]
2011-09-21 12:05marvintmAssigned Toalostale => marvintm
2011-09-21 12:05marvintmNote Added: 0041190
2011-09-21 12:05marvintmStatusresolved => new
2011-09-21 12:05marvintmResolutionfixed => open
2011-09-21 18:22marvintmStatusnew => scheduled
2011-09-21 18:22marvintmfix_in_branch2.50 => pi
2011-09-21 18:30marvintmRelationship addedrelated to 0018585
2011-09-21 18:30marvintmNote Added: 0041203
2011-09-21 18:30marvintmStatusscheduled => resolved
2011-09-21 18:30marvintmResolutionopen => fixed
2011-09-21 18:30marvintmStatusresolved => closed

Notes
(0040756)
hgbot   
2011-09-06 09:43   
Repository: erp/stable/2.50
Changeset: 4b2156ebe0dade865b1286fe0e6f624d700ed8ce
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Sep 06 09:42:13 2011 +0200
URL: http://code.openbravo.com/erp/stable/2.50/rev/4b2156ebe0dade865b1286fe0e6f624d700ed8ce [^]

fixed bug 18436: 2.50 grid, cursors in Oracle are not reused
  Using prepared statement parameter for grid limits in Oracle

---
M src/org/openbravo/erpCommon/utility/TableSQLData.java
---
(0041190)
marvintm   
2011-09-21 12:05   
Now when you scroll down in the grid to the lowest row, a Java exception happens and a JS alert is shown:

Missing IN or OUT parameter at index:: 9
(0041203)
marvintm   
2011-09-21 18:30   
This issue was correctly fixed. The problem found is a completely different thing, explained in issue 18585. The fix done for this issue works, and resolves the performance problem described.