Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018410Openbravo ERPA. Platformpublic2011-09-01 13:532011-10-12 01:59
Reporteriperdomo 
Assigned Toiperdomo 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.36-gentoo-r5
Product Version 
Target Version3.0MP4Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018410: Refactor AuthenticationManager and related classes
DescriptionThe AuthenticationManager requires refactoring. There are mixed roles between LoginHandler and DefaultAuthenticationManager class
Steps To ReproduceCheck the following code
* AuthenticationManger
* LoginHandler
* DefaultAuthenticationManager
* AutologonAuthenticationManager
Proposed SolutionThe AuthenticationManager should be an abstract class with methods to be 'overridden' by module's subclasses
Additional Information
TagsNo tags attached.
Relationships
related to defect 00184923.0MP4 closed iperdomo AutheticationManager refactor (API change) int-api Build 2361 
related to defect 00153593.0MP4 closed iperdomo The getServletContext() method in KernelServlet breaks the AutologonAuthenticationManager 
related to defect 00185053.0MP4 closed marvintm Multipart forms seems to be broken after AuthenticationManager refactor 
Attached Filesdiff 18410.diff (52,898) 2011-09-01 14:10
https://issues.openbravo.com/file_download.php?file_id=4506&type=bug
diff 18410b.diff (5,189) 2011-09-01 14:11
https://issues.openbravo.com/file_download.php?file_id=4507&type=bug
diff 18410c.diff (2,467) 2011-09-01 14:11
https://issues.openbravo.com/file_download.php?file_id=4508&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-09-01 13:53iperdomoNew Issue
2011-09-01 13:53iperdomoAssigned To => iperdomo
2011-09-01 13:53iperdomoWeb browser => Google Chrome
2011-09-01 13:53iperdomoModules => Core
2011-09-01 13:53iperdomoStatusnew => acknowledged
2011-09-01 14:10iperdomoFile Added: 18410.diff
2011-09-01 14:11iperdomoFile Added: 18410b.diff
2011-09-01 14:11iperdomoFile Added: 18410c.diff
2011-09-05 09:22iperdomoRelationship addedrelated to 0015359
2011-09-09 13:23iperdomoStatusacknowledged => scheduled
2011-09-09 13:23iperdomofix_in_branch => pi
2011-09-09 13:41hgbotCheckin
2011-09-09 13:41hgbotNote Added: 0040837
2011-09-09 13:41hgbotStatusscheduled => resolved
2011-09-09 13:41hgbotResolutionopen => fixed
2011-09-09 13:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3d63eb9bc45080a496799a0efcccb82bcb04c4f2 [^]
2011-09-09 13:42hgbotCheckin
2011-09-09 13:42hgbotNote Added: 0040839
2011-09-09 13:42hgbotCheckin
2011-09-09 13:42hgbotNote Added: 0040840
2011-09-09 18:28hgbotCheckin
2011-09-09 18:28hgbotNote Added: 0040851
2011-09-09 18:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/3d63eb9bc45080a496799a0efcccb82bcb04c4f2 [^] => http://code.openbravo.com/erp/devel/pi/rev/51081d7a2152e037de334ef2e2ae28c382efb83a [^]
2011-09-11 16:09hgbotCheckin
2011-09-11 16:09hgbotNote Added: 0040896
2011-09-11 16:09hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/51081d7a2152e037de334ef2e2ae28c382efb83a [^] => http://code.openbravo.com/erp/devel/pi/rev/2b257cd7a6479c5383bb2a19cda6a0a4ed75cc13 [^]
2011-09-12 16:33iperdomoRelationship addedrelated to 0018505
2011-09-28 11:41hgbotCheckin
2011-09-28 11:41hgbotNote Added: 0041338
2011-09-30 17:38shuehnerRelationship addedrelated to 0018492
2011-10-03 11:49marvintmStatusresolved => closed
2011-10-12 01:56hudsonbotCheckin
2011-10-12 01:56hudsonbotNote Added: 0041607
2011-10-12 01:57hudsonbotCheckin
2011-10-12 01:57hudsonbotNote Added: 0041611
2011-10-12 01:57hudsonbotCheckin
2011-10-12 01:57hudsonbotNote Added: 0041649
2011-10-12 01:59hudsonbotCheckin
2011-10-12 01:59hudsonbotNote Added: 0041722

Notes
(0040837)
hgbot   
2011-09-09 13:41   
Repository: erp/devel/pi
Changeset: 3d63eb9bc45080a496799a0efcccb82bcb04c4f2
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Sep 09 13:40:25 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3d63eb9bc45080a496799a0efcccb82bcb04c4f2 [^]

Fixes issue 18410 and fixes issue 15359: AuthenticationManager refactor
- Refactor AuthenticationManager, change from Interface to Abstract class.
- The AuthManager custom implementations need to implement doAuthenticate and
  doLogout
- Move code from LoginHandler to DefaultAuthenticationManager

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelServlet.java
M modules/org.openbravo.service.integration.google/src/org/openbravo/service/integration/google/GoogleAuthServlet.java
M src/index.jsp
M src/org/openbravo/authentication/AuthenticationException.java
M src/org/openbravo/authentication/AuthenticationManager.java
M src/org/openbravo/authentication/basic/AutologonAuthenticationManager.java
M src/org/openbravo/authentication/basic/DefaultAuthenticationManager.java
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/base/secureApp/LoginHandler.java
M src/org/openbravo/base/secureApp/LoginUtils.java
---
(0040839)
hgbot   
2011-09-09 13:42   
Repository: erp/mods/org.openbravo.authentication.lam
Changeset: acfa0f199dadbd03c42291e51d3286df9fc47414
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Sep 09 13:41:45 2011 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.authentication.lam/rev/acfa0f199dadbd03c42291e51d3286df9fc47414 [^]

Related to issue 18410: AuthenticationManager changes

---
M src/org/openbravo/authentication/lam/LamAuthenticationManager.java
---
(0040840)
hgbot   
2011-09-09 13:42   
Repository: erp/mods/org.openbravo.demo.loginpage
Changeset: 20c46f5127b97dc3adecaf66bdc017a048d77683
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Sep 09 13:42:31 2011 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.demo.loginpage/rev/20c46f5127b97dc3adecaf66bdc017a048d77683 [^]

Related to issue 18410: AuthenticationManager changes

---
M src/org/openbravo/demo/loginpage/authentication/DemoAuthenticationManager.java
---
(0040851)
hgbot   
2011-09-09 18:28   
Repository: erp/devel/pi
Changeset: 51081d7a2152e037de334ef2e2ae28c382efb83a
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri Sep 09 18:28:27 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/51081d7a2152e037de334ef2e2ae28c382efb83a [^]

Fixes issue 18410: User Servlet API instead of VariablesBase
- when using vars to set an session variable it modifies the attribute and
  changes it to UPPERCASE. Too many places expect #Authenticated_user instead
  of #AUTHENTICATED_USER

---
M modules/org.openbravo.service.integration.google/src/org/openbravo/service/integration/google/GoogleAuthServlet.java
---
(0040896)
hgbot   
2011-09-11 16:09   
Repository: erp/devel/pi
Changeset: 2b257cd7a6479c5383bb2a19cda6a0a4ed75cc13
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sun Sep 11 16:08:32 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2b257cd7a6479c5383bb2a19cda6a0a4ed75cc13 [^]

Fixed 18410. Small improvements to error handling
- Fix typo in error message in HttpSecureAppServlet
- Sync load auth-manager loading code from HSAS -> LoginHandler
  - use DefaultAuthManager if class not defined (to be exact also if property
    defined but with empty value)
  - Sync error message to advise admin on what to check

---
M src/org/openbravo/base/secureApp/HttpSecureAppServlet.java
M src/org/openbravo/base/secureApp/LoginHandler.java
---
(0041338)
hgbot   
2011-09-28 11:41   
Repository: erp/devel/pi
Changeset: a84388fda4d429dd251950ff073ed3b58497a5b2
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Sep 28 11:40:43 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a84388fda4d429dd251950ff073ed3b58497a5b2 [^]

Issue 18410: Small code improvements
- Added javadoc to doAuthenticate and doLogout methods
- Removed unused private methods

---
M src/org/openbravo/authentication/AuthenticationManager.java
---
(0041607)
hudsonbot   
2011-10-12 01:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041611)
hudsonbot   
2011-10-12 01:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041649)
hudsonbot   
2011-10-12 01:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041722)
hudsonbot   
2011-10-12 01:59   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test