Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018387Localization Pack: SpainInvoice Register Bookpublic2011-08-30 15:452011-09-20 12:53
Reporterpsanjuan 
Assigned Tovmromanos 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 8.04.1
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0018387: Purchase and Sales Invoice Book should properly manage Reverse Purchase/Sales invoices
DescriptionPurchase and Sales Invoice Book should properly manage Reverse Purchase/Sales invoices.
These are new documents which should be properly manage by the Invoices Books.

This issue depends on 18386 issue related to Books setup. Once the setup is right for these new documents type, the books should properly manage as described in this issue.
Steps To ReproduceNavigate to Purchase Invoice and create a new purchase invoice (Transaction Document = AP Invoice).
Complete and Post.
Create a new purchase invoice (Transaction Document = Reverse Puchase Invoice) in order to partially reverse the purchase invoice previously created. Link the reverse invoice to the invoice being reversed in the Reversed Invoice tab.
Complete and Post.
Launch the Received Invoice Book and realize that the first invoice is properly shown but the second one is not.
Proposed SolutionThe reversed purchase invoice is not properly shown because:
- all the amounts but the tax rate should have negative amounts (same behaviour as negative AP Invoice and AP Credit Memo)
- and the "Tax Book Key" must always be "D". See image attached

same applies to reversed sales invoice. These ones are not properly managed because:
- all the amounts but the tax rate should be negative amounts (same behaviour as negative AR Invoice and AR Credit Memo).
- and the "Tax Book Key" must always be "D".
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0018386 closed vmromanos Localization Pack: Spain This module should include purchase/sales tax rates linked to either "Reverse Purchase Invoice" and "Reversed Sales Invoice" 
related to backport 00187852.50MP36 closed mirurita Openbravo ERP Tax Payment process should properly manage Reverse Purchase/Sales invoices 
Attached Filespng 18384.png (111,825) 2011-08-30 15:50
https://issues.openbravo.com/file_download.php?file_id=4494&type=bug
png

png 18387_1.png (89,183) 2011-08-30 17:58
https://issues.openbravo.com/file_download.php?file_id=4499&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-08-30 15:45psanjuanNew Issue
2011-08-30 15:45psanjuanAssigned To => jonalegriaesarte
2011-08-30 15:45psanjuanOBNetwork customer => No
2011-08-30 15:46psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=2644#r2644
2011-08-30 15:47psanjuanDescription Updatedbug_revision_view_page.php?rev_id=2646#r2646
2011-08-30 15:47psanjuanRelationship addeddepends on 0018386
2011-08-30 15:49psanjuanDescription Updatedbug_revision_view_page.php?rev_id=2647#r2647
2011-08-30 15:49psanjuanSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=2648#r2648
2011-08-30 15:49psanjuanProposed Solution updated
2011-08-30 15:50psanjuanFile Added: 18384.png
2011-08-30 16:01psanjuanProposed Solution updated
2011-08-30 17:58psanjuanFile Added: 18387_1.png
2011-08-31 10:23psanjuanTypedefect => feature request
2011-08-31 10:24psanjuanAssigned Tojonalegriaesarte => psanjuan
2011-08-31 10:25psanjuanAssigned Topsanjuan => dalsasua
2011-09-06 14:01vmromanosStatusnew => scheduled
2011-09-06 14:01vmromanosAssigned Todalsasua => vmromanos
2011-09-06 14:01vmromanosfix_in_branch => pi
2011-09-07 09:57hgbotCheckin
2011-09-07 09:57hgbotNote Added: 0040775
2011-09-07 09:57hgbotStatusscheduled => resolved
2011-09-07 09:57hgbotResolutionopen => fixed
2011-09-07 09:57hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/1a988cf992ee03005cf8705fba5f4af6bcdf6ce2 [^]
2011-09-19 16:43hgbotCheckin
2011-09-19 16:43hgbotNote Added: 0041079
2011-09-19 19:07psanjuanNote Added: 0041094
2011-09-20 12:53psanjuanNote Added: 0041128
2011-09-20 12:53psanjuanStatusresolved => closed
2011-09-20 12:53psanjuanfix_in_branchpi =>
2011-10-17 11:41maiteRelationship addedrelated to 0018785

Notes
(0040775)
hgbot   
2011-09-07 09:57   
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook
Changeset: 1a988cf992ee03005cf8705fba5f4af6bcdf6ce2
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Wed Sep 07 09:57:11 2011 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/1a988cf992ee03005cf8705fba5f4af6bcdf6ce2 [^]

Fixed bug 18387 in module version 1.2.8
Purchase and Sales Invoice Book should properly manage Reverse Purchase/Sales invoices
Incremented Core's dependency from 2.50.19232 (MP27EU1), where the IsReverse flag was created

---
M referencedata/standard/Negative_Credit_Memos_Alert.xml
M src-db/database/model/functions/OBIRB_GENERATE_CODE.xml
M src-db/database/sourcedata/AD_MODULE.xml
M src-db/database/sourcedata/AD_MODULE_DEPENDENCY.xml
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLines.java
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLinesDao.java
---
(0041079)
hgbot   
2011-09-19 16:43   
Repository: erp/pmods/org.openbravo.module.invoicesregisterbook
Changeset: fb6adae8f355db2eec3b0506cea9392d434683b3
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Sep 19 16:45:57 2011 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.invoicesregisterbook/rev/fb6adae8f355db2eec3b0506cea9392d434683b3 [^]

Issue 18387: Negative invoices appear again in the book

---
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLinesDao.java
---
(0041094)
psanjuan   
2011-09-19 19:07   
it is working properly for Reversed Purchase Invoices but it is not working properly for Reversed Sales Invoices as these ones are not marked as "D".
(0041128)
psanjuan   
2011-09-20 12:53   
fixed and working