Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018297Openbravo ERPA. Platformpublic2011-08-17 08:192011-09-01 18:12
Reporteriperdomo 
Assigned Toiperdomo 
PriorityurgentSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.36-gentoo-r5
Product Version 
Target Version3.0MP3Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018297: If the Google API integration is disabled, the G button is still shown in the login page
DescriptionAn instance may want to disable (not show) the login with a Google Account button. If the module is set to disabled (through a template), the button is still shown
Steps To Reproduce* Deactivate the Google APIs Integration module
* Logoff to see the login page, the G button is still shown
Proposed SolutionHide the G button when the module is disabled
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0014678 acknowledged Triage Platform Base DE010 I can only choose the whole pack to disable. However, enabling can be done in a one-by-one basis 
related to defect 00183003.0MP3 closed mtaal Disabled modules cannot be edited in grid mode 
Attached Filesdiff Issue-0018297.diff (538) 2011-08-17 12:01
https://issues.openbravo.com/file_download.php?file_id=4455&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-08-17 08:19iperdomoNew Issue
2011-08-17 08:19iperdomoAssigned To => iperdomo
2011-08-17 08:19iperdomoWeb browser => Google Chrome
2011-08-17 08:19iperdomoModules => Core
2011-08-17 08:19iperdomoOBNetwork customer => No
2011-08-17 08:19iperdomoStatusnew => scheduled
2011-08-17 08:19iperdomofix_in_branch => pi
2011-08-17 08:21hgbotCheckin
2011-08-17 08:21hgbotNote Added: 0040240
2011-08-17 08:21hgbotStatusscheduled => resolved
2011-08-17 08:21hgbotResolutionopen => fixed
2011-08-17 08:21hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b687fd3cba82daf2adc358d722ab4d99e2d1bf5b [^]
2011-08-17 12:00adrianromeroNote Added: 0040251
2011-08-17 12:00adrianromeroStatusresolved => new
2011-08-17 12:00adrianromeroResolutionfixed => open
2011-08-17 12:01adrianromeroFile Added: Issue-0018297.diff
2011-08-17 12:05adrianromeroRelationship addedrelated to 0014678
2011-08-17 12:06adrianromeroRelationship addedrelated to 0018300
2011-08-17 18:11hudsonbotCheckin
2011-08-17 18:11hudsonbotNote Added: 0040283
2011-08-29 08:45iperdomoStatusnew => scheduled
2011-08-29 10:38hgbotCheckin
2011-08-29 10:38hgbotNote Added: 0040527
2011-08-29 10:39hgbotCheckin
2011-08-29 10:39hgbotNote Added: 0040528
2011-08-29 10:39hgbotStatusscheduled => resolved
2011-08-29 10:39hgbotResolutionopen => fixed
2011-08-29 10:39hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/b687fd3cba82daf2adc358d722ab4d99e2d1bf5b [^] => http://code.openbravo.com/erp/devel/pi/rev/784b668c22c733fc23de98fd0933d6ef99d47721 [^]
2011-08-29 11:07hgbotCheckin
2011-08-29 11:07hgbotNote Added: 0040531
2011-08-29 11:07hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/784b668c22c733fc23de98fd0933d6ef99d47721 [^] => http://code.openbravo.com/erp/devel/pi/rev/8bc60787fdd0c73495bc2988390ba076255f65ab [^]
2011-08-30 08:54hgbotCheckin
2011-08-30 08:54hgbotNote Added: 0040548
2011-08-30 13:58hgbotCheckin
2011-08-30 13:58hgbotNote Added: 0040557
2011-08-30 19:38hudsonbotCheckin
2011-08-30 19:38hudsonbotNote Added: 0040564
2011-08-30 19:38hudsonbotCheckin
2011-08-30 19:38hudsonbotNote Added: 0040565
2011-08-30 19:38hudsonbotCheckin
2011-08-30 19:38hudsonbotNote Added: 0040566
2011-08-30 19:38hudsonbotCheckin
2011-08-30 19:38hudsonbotNote Added: 0040568
2011-08-30 19:39hudsonbotCheckin
2011-08-30 19:39hudsonbotNote Added: 0040574
2011-09-01 18:12marvintmStatusresolved => closed

Notes
(0040240)
hgbot   
2011-08-17 08:21   
Repository: erp/devel/pi
Changeset: b687fd3cba82daf2adc358d722ab4d99e2d1bf5b
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Aug 17 08:20:46 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b687fd3cba82daf2adc358d722ab4d99e2d1bf5b [^]

Fixes issue 18297: Hide the G button when the module is disabled

---
M src/org/openbravo/erpCommon/security/Login.java
---
(0040251)
adrianromero   
2011-08-17 12:00   
Reopened. The login page still shows the "G" icon when the Google API integration module is disabled.

Consider the patch attached.
(0040283)
hudsonbot   
2011-08-17 18:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5922b23c1f55 [^]

Maturity status: Test
(0040527)
hgbot   
2011-08-29 10:38   
Repository: erp/devel/pi
Changeset: 89f6f8bf73efec79a940b555b3e5bbf862502c32
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Aug 29 10:36:20 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/89f6f8bf73efec79a940b555b3e5bbf862502c32 [^]

Issue 18297: Added new preference property

---
A modules/org.openbravo.service.integration.google/src-db/database/sourcedata/AD_REF_LIST.xml
---
(0040528)
hgbot   
2011-08-29 10:39   
Repository: erp/devel/pi
Changeset: 784b668c22c733fc23de98fd0933d6ef99d47721
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Aug 29 10:37:35 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/784b668c22c733fc23de98fd0933d6ef99d47721 [^]

Fixes issue 18297: Added new Preference to disable G button
- Activated instances have the posibility to disable the G button in the login
  page

---
M src/org/openbravo/erpCommon/security/Login.java
---
(0040531)
hgbot   
2011-08-29 11:07   
Repository: erp/devel/pi
Changeset: 8bc60787fdd0c73495bc2988390ba076255f65ab
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Aug 29 11:06:45 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8bc60787fdd0c73495bc2988390ba076255f65ab [^]

Fixes issue 18297: Changed the logic to display button
- Show the button always unless the preference is set to N. This avoids the
need to add a new preference by default

---
M src/org/openbravo/erpCommon/security/Login.java
---
(0040548)
hgbot   
2011-08-30 08:54   
Repository: erp/devel/pi
Changeset: a3a20690578a4ebb19e42cdc0dae422a5f822fa9
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Aug 30 08:53:29 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a3a20690578a4ebb19e42cdc0dae422a5f822fa9 [^]

Fixes int-gui-oracle - Build # 255. Related to issue 18297

---
M src/org/openbravo/erpCommon/security/Login.java
---
(0040557)
hgbot   
2011-08-30 13:58   
Repository: erp/devel/pi
Changeset: 395ce0ebf3e4cee7838cda51ce10fb9642e8a81a
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Tue Aug 30 13:56:35 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/395ce0ebf3e4cee7838cda51ce10fb9642e8a81a [^]

Fixes build int-gui-oracle - Build # 255. Related to issue 18297
- The hql fails in Oracle if you use a property clob = value, it works
if you use like

---
M src/org/openbravo/erpCommon/security/Login.java
---
(0040564)
hudsonbot   
2011-08-30 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dfde2574ecaf [^]

Maturity status: Test
(0040565)
hudsonbot   
2011-08-30 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dfde2574ecaf [^]

Maturity status: Test
(0040566)
hudsonbot   
2011-08-30 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dfde2574ecaf [^]

Maturity status: Test
(0040568)
hudsonbot   
2011-08-30 19:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dfde2574ecaf [^]

Maturity status: Test
(0040574)
hudsonbot   
2011-08-30 19:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dfde2574ecaf [^]

Maturity status: Test