Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018150Openbravo ERPA. Platformpublic2011-08-01 16:172011-08-08 09:13
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP1 
Target Version3.0MP2Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018150: Destroy context menu when a listgrid is destroyed
DescriptionAccording to the SC documentation the contextMenu property of a canvas is not destroyed when a canvas is destroyed. This because context menus can be shared. We don't share context menus, so code should be added to explicitly remove context menus to prevent memory leaks.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-08-01 16:17mtaalNew Issue
2011-08-01 16:17mtaalAssigned To => mtaal
2011-08-01 16:17mtaalModules => Core
2011-08-01 16:58hgbotCheckin
2011-08-01 16:58hgbotNote Added: 0039747
2011-08-01 16:58hgbotStatusnew => resolved
2011-08-01 16:58hgbotResolutionopen => fixed
2011-08-01 16:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/19135e59b53249b9a0b351052664ec910889a828 [^]
2011-08-06 05:32hudsonbotCheckin
2011-08-06 05:32hudsonbotNote Added: 0039925
2011-08-08 09:13iperdomoNote Added: 0039980
2011-08-08 09:13iperdomoStatusresolved => closed

Notes
(0039747)
hgbot   
2011-08-01 16:58   
Repository: erp/devel/pi
Changeset: 19135e59b53249b9a0b351052664ec910889a828
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 01 16:57:41 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/19135e59b53249b9a0b351052664ec910889a828 [^]

Fixes issue 18150: Destroy context menu when a listgrid is destroyed
Added explicit destroy of context menu when a grid is destroyed

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0039925)
hudsonbot   
2011-08-06 05:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5744448753e7 [^]

Maturity status: Test
(0039980)
iperdomo   
2011-08-08 09:13   
Tested on pi @ rev cd93116382e9
----
Using Chrome Dev Tools, checking the value of the contextMenu in a Grid

isc_OBStandardView_0.viewGrid
_2

isc_OBStandardView_0.viewGrid.ID
"isc_OBViewGrid_8"

isc_OBStandardView_0.viewGrid.contextMenu
_2

isc_OBStandardView_0.viewGrid.contextMenu.ID
"isc_Menu_4"

isc_Menu_4
_2

isc_Menu_4 === null
false

isc_Menu_4 === null
true