0018145: incorrect error to process bank statement post with multicurrency

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0018145

Openbravo ERP

09. Financial management

public

2011-08-01 14:02

2011-08-01 17:14

Reporter

malsasua

Assigned To

jonalegriaesarte

Priority

high

Severity

minor

Reproducibility

always

Status

closed

Resolution

no change required

Platform

OS Version

Community Appliance

Product Version

2.50MP31

Target Version

2.50MP35

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Google Chrome

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0018145: incorrect error to process bank statement post with multicurrency

Description

if you have a bank statement with a debt payment with transaction date distinct to statement date, and the conversion rate in transaction date is distinct that conversion rate of statement date, when you process it, error is returned

Steps To Reproduce

. conversion rate 15/02/2011 from USD to EUR = 2 / 0.5
. conversion rate 15/03/2011 from USD to EUR = 4 / 0.25
. a bank statement in EUR, with statement date 15/02/2011
. add a debt payments in USD, with transaction date 15/03/2011
. process it
Error is returned

Proposed Solution

replace in c_bankstatement_post :
SELECT COUNT(*),
MAX(bsl.Line)
INTO v_count,
v_line
FROM C_BANKSTATEMENTLINE bsl,
C_BANKSTATEMENT bs,
C_DEBT_PAYMENT dp
WHERE bsl.C_BankStatement_ID=bs.C_BankStatement_ID
AND bsl.C_BankStatement_ID=v_Record_ID
AND bsl.C_Debt_Payment_ID=dp.C_Debt_Payment_ID
AND bsl.C_Currency_ID<>dp.C_Currency_ID
AND
C_Currency_Round(C_Currency_Convert(
(CASE dp.IsReceipt WHEN 'Y' THEN -- If IsReceipt = N, amount*-1
(dp.Amount-coalesce(dp.WriteOffAmt,0)) ELSE(coalesce(dp.WriteOffAmt,0)-dp.Amount)
END), dp.C_Currency_ID, bsl.C_Currency_ID, bs.StatementDate, NULL, bs.AD_Client_ID, bs.AD_Org_ID),bsl.C_Currency_ID, null)
<> C_Currency_Round(bsl.TrxAmt, bsl.C_Currency_ID, null);
by
SELECT COUNT(*),
MAX(bsl.Line)
INTO v_count,
v_line
FROM C_BANKSTATEMENTLINE bsl,
C_BANKSTATEMENT bs,
C_DEBT_PAYMENT dp
WHERE bsl.C_BankStatement_ID=bs.C_BankStatement_ID
AND bsl.C_BankStatement_ID=v_Record_ID
AND bsl.C_Debt_Payment_ID=dp.C_Debt_Payment_ID
AND bsl.C_Currency_ID<>dp.C_Currency_ID
AND
C_Currency_Round(C_Currency_Convert(
(CASE dp.IsReceipt WHEN 'Y' THEN -- If IsReceipt = N, amount*-1
(dp.Amount-coalesce(dp.WriteOffAmt,0)) ELSE(coalesce(dp.WriteOffAmt,0)-dp.Amount)
END), dp.C_Currency_ID, bsl.C_Currency_ID, bsl.ValutaDate, NULL, bs.AD_Client_ID, bs.AD_Org_ID),bsl.C_Currency_ID, null)
<> C_Currency_Round(bsl.TrxAmt, bsl.C_Currency_ID, null);

Additional Information