Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0018056Openbravo ERPZ. Otherspublic2011-07-21 17:282011-09-05 16:22
adrianromero 
mirurita 
highminoralways
closedfixed 
20Community Appliance
 
3.0MP3 
Advanced Payables and Receivables Mngmt
No
0018056: Business partner selector in Add Payment window fires the reload of the results in every change
In every change of the Business Partner Selector field in the Popup Add payment Window it is invoked the server side to reload the results data grid.

The action of reloading this data grid must be executed only when a value is selected or when the field is empty, not for example when the user is typing a value
1) Go to Financial Account || Transactions tab
2) Click on Add Transaction button
3) Click on Add Payment button
4) Enter a value for the business partner selector
5) Type in the selector field and verify that the grid is reloaded in every key press. It must be verified debugging because the returned data in this case is always an empty set of records.
See notes in the related issue 16765
No tags attached.
related to defect 00167653.0MP3 closed adrianromero Selector in manual window: not possible to remove the selected value and fire onchange event 
Issue History
2011-07-21 17:28adrianromeroNew Issue
2011-07-21 17:28adrianromeroAssigned To => adrianromero
2011-07-21 17:28adrianromeroModules => Advanced Payables and Receivables Mngmt
2011-07-21 17:28adrianromeroIssue generated from0016765
2011-07-21 17:28adrianromeroRelationship addedrelated to 0016765
2011-07-21 17:28adrianromeroAssigned Toadrianromero => mirurita
2011-07-21 17:30adrianromeroNote Added: 0039302
2011-08-01 11:05psarobePrioritynormal => high
2011-08-01 11:05psarobeStatusnew => scheduled
2011-08-23 14:29hgbotCheckin
2011-08-23 14:29hgbotNote Added: 0040444
2011-08-23 14:29hgbotStatusscheduled => resolved
2011-08-23 14:29hgbotResolutionopen => fixed
2011-08-23 14:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ff6655a3b32155da0dabf7820c42884f4f313999 [^]
2011-08-23 14:30hgbotCheckin
2011-08-23 14:30hgbotNote Added: 0040445
2011-08-23 14:30hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ff6655a3b32155da0dabf7820c42884f4f313999 [^] => http://code.openbravo.com/erp/devel/pi/rev/0cf02944934fa97979ba7e50f65483e1f7c7ed1a [^]
2011-08-23 14:37adrianromeroNote Added: 0040447
2011-08-24 01:08hudsonbotCheckin
2011-08-24 01:08hudsonbotNote Added: 0040467
2011-08-24 01:08hudsonbotCheckin
2011-08-24 01:08hudsonbotNote Added: 0040468
2011-09-05 10:35hgbotCheckin
2011-09-05 10:35hgbotNote Added: 0040738
2011-09-05 10:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/0cf02944934fa97979ba7e50f65483e1f7c7ed1a [^] => http://code.openbravo.com/erp/devel/pi/rev/7be8369e7657a351b67da2a30ab00b02f617e744 [^]
2011-09-05 11:31miruritaNote Added: 0040741
2011-09-05 11:31miruritaStatusresolved => closed
2011-09-05 16:22hudsonbotCheckin
2011-09-05 16:22hudsonbotNote Added: 0040746

Notes
(0039302)
adrianromero   
2011-07-21 17:30   
This issue must be fixed in coordination with the related issue 16765
(0040444)
hgbot   
2011-08-23 14:29   
Repository: erp/devel/pi
Changeset: ff6655a3b32155da0dabf7820c42884f4f313999
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Aug 18 13:05:42 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ff6655a3b32155da0dabf7820c42884f4f313999 [^]

Fixes issue 0018056: Business partner selector in Add Payment window fires the reload of the results in every change
It has been added a check that only fires the reload of the data when the parameters change

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.html
---
(0040445)
hgbot   
2011-08-23 14:30   
Repository: erp/devel/pi
Changeset: 0cf02944934fa97979ba7e50f65483e1f7c7ed1a
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Aug 23 14:27:58 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0cf02944934fa97979ba7e50f65483e1f7c7ed1a [^]

Fixes issue 0018056: Business partner selector in Add Payment window fires the reload of the results in every change
It has been added a check that only fires the reload of the data when the parameters change in the Payment Method drop down list

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.html
---
(0040447)
adrianromero   
2011-08-23 14:37   
* Testing the issue

Now the reload of the list is not invoked in every keypress. This cannot be noticed from the user perspective. To test it the javascript function loadGridList() and loadPaymentMethodCombo() of the page AddPaymentFromTransaction.html must be debugged to verify that the server side is only invoked when the parameter values change, not in every key typed.

It has to be verified that the server side is invoked when any field that is a parameter of the list changes, for example the dates.

* Other areas affected

No other areas affected
(0040467)
hudsonbot   
2011-08-24 01:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ae0285ee1597 [^]

Maturity status: Test
(0040468)
hudsonbot   
2011-08-24 01:08   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ae0285ee1597 [^]

Maturity status: Test
(0040738)
hgbot   
2011-09-05 10:35   
Repository: erp/devel/pi
Changeset: 7be8369e7657a351b67da2a30ab00b02f617e744
Author: David Alsasua <david.alsasua <at> openbravo.com>
Date: Fri Aug 26 17:50:25 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7be8369e7657a351b67da2a30ab00b02f617e744 [^]

Fixes issue 18056.
Just in case the values of filter elements change, the grid is re-printed

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.html
---
(0040741)
mirurita   
2011-09-05 11:31   
Tested in:
- Add Payment From Transaction
- Add Payment Details
(0040746)
hudsonbot   
2011-09-05 16:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/3629615c7ca1 [^]

Maturity status: Test