Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018030Openbravo ERPA. Platformpublic2011-07-19 12:292011-08-01 14:20
Reporteriperdomo 
Assigned Tomtaal 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.36-gentoo-r5
Product Versionpi 
Target Version3.0MP2Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserApple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018030: When using a modal popup a new tab with the loading bar is shown
DescriptionThe changeset fixing the issue 0016653 makes a new tab appears on modal popups.
Steps To Reproduce* Open process 'Generate Invoices' or any other modal popup.
* A new tab with no information just the loading bar is shown
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00166533.0MP2 closed mtaal Show loading bar when opening a view 
Attached Filesdiff issue18030.diff (17,477) 2011-07-20 18:11
https://issues.openbravo.com/file_download.php?file_id=4373&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-07-19 12:29iperdomoNew Issue
2011-07-19 12:29iperdomoAssigned To => mtaal
2011-07-19 12:29iperdomoWeb browser => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
2011-07-19 12:29iperdomoModules => Core
2011-07-19 12:29iperdomoRelationship addedrelated to 0016653
2011-07-19 15:49hgbotCheckin
2011-07-19 15:49hgbotNote Added: 0039234
2011-07-19 15:49hgbotStatusnew => resolved
2011-07-19 15:49hgbotResolutionopen => fixed
2011-07-19 15:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/99e69a554c6e38a15f3364a2b2242fc312dac56f [^]
2011-07-20 18:11iperdomoNote Added: 0039270
2011-07-20 18:11iperdomoStatusresolved => new
2011-07-20 18:11iperdomoResolutionfixed => open
2011-07-20 18:11iperdomoFile Added: issue18030.diff
2011-07-21 16:45hgbotCheckin
2011-07-21 16:45hgbotNote Added: 0039298
2011-07-21 16:45hgbotStatusnew => resolved
2011-07-21 16:45hgbotResolutionopen => fixed
2011-07-21 16:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/99e69a554c6e38a15f3364a2b2242fc312dac56f [^] => http://code.openbravo.com/erp/devel/pi/rev/573d6f683a8f16bafc9a0eb24b7ecbf2e92deb0d [^]
2011-07-21 17:44iperdomoNote Added: 0039304
2011-07-21 17:44iperdomoStatusresolved => closed
2011-08-01 14:20hudsonbotCheckin
2011-08-01 14:20hudsonbotNote Added: 0039628
2011-08-01 14:20hudsonbotCheckin
2011-08-01 14:20hudsonbotNote Added: 0039651

Notes
(0039234)
hgbot   
2011-07-19 15:49   
Repository: erp/devel/pi
Changeset: 99e69a554c6e38a15f3364a2b2242fc312dac56f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Jul 19 15:49:05 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/99e69a554c6e38a15f3364a2b2242fc312dac56f [^]

Fixes issue 18030: When using a modal popup a new tab with the loading bar is shown
Added a popup parameter to popup windows, for popups no loading bar view is shown

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-application-menu.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/navbar/ob-quick-launch.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-view-manager.js
---
(0039270)
iperdomo   
2011-07-20 18:11   
The issue is still reproducible when the process associated to a button is open in a browser popup instead of a modal popup.

Attached you'll find a diff that you can apply and test.
* Apply the diff
* ant smartbuild -Dlocal=no
* Open the Sales Order windows
* Click on Process Issue 18030
 - A new popup is opened with a string "42"
 - A new large tab is opened without label nor close button
(0039298)
hgbot   
2011-07-21 16:45   
Repository: erp/devel/pi
Changeset: 573d6f683a8f16bafc9a0eb24b7ecbf2e92deb0d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jul 21 16:44:52 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/573d6f683a8f16bafc9a0eb24b7ecbf2e92deb0d [^]

Fixes issue 18030: When using a modal popup a new tab with the loading bar is shown
button popup now passes popup parameter, now correctly removes loading tab if one is there, added extra parameter to prevent loadingtab

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-view-manager.js
---
(0039304)
iperdomo   
2011-07-21 17:44   
Tested on pi @ rev dfe885fd7ad8
(0039628)
hudsonbot   
2011-08-01 14:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^]

Maturity status: Test
(0039651)
hudsonbot   
2011-08-01 14:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^]

Maturity status: Test