Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0018015Openbravo ERPA. Platformpublic2011-07-18 09:292011-08-03 20:45
Reporteriperdomo 
Assigned Toiperdomo 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS Version2.6.36-gentoo-r5
Product Version3.0MP1 
Target Version3.0MP2Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserApple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0018015: Benchmark tool broken due to MainLayout initialization changes
DescriptionOn changeset c1bb8f9891e1 [1] a change to delayed MainLayout initialization was introduced. This change broke the client side benchmark tool.

[1] https://code.openbravo.com/erp/devel/pi/rev/c1bb8f9891e1 [^]
Steps To Reproduce- On 3.0MP1 try to open the client benchmark tool
- Login as System Administrator
- Visit: http://host:port/context/web/org.openbravo.client.kernel/benchmark [^]
- Check for any JavaScript error
Proposed Solution* Use the initialize method before starting to create tabs
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-07-18 09:29iperdomoNew Issue
2011-07-18 09:29iperdomoAssigned To => iperdomo
2011-07-18 09:29iperdomoWeb browser => Apple Safari, Google Chrome, Internet Explorer, Mozilla Firefox
2011-07-18 09:29iperdomoModules => Core
2011-07-18 09:29iperdomoStatusnew => scheduled
2011-07-18 09:29iperdomofix_in_branch => pi
2011-07-18 09:31hgbotCheckin
2011-07-18 09:31hgbotNote Added: 0039138
2011-07-18 09:31hgbotStatusscheduled => resolved
2011-07-18 09:31hgbotResolutionopen => fixed
2011-07-18 09:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/093f7a7b2e41559b88acb6cfbb7ae5b16a229e07 [^]
2011-07-18 11:05mtaalNote Added: 0039147
2011-07-18 11:05mtaalStatusresolved => closed
2011-07-27 17:42iperdomoNote Added: 0039454
2011-07-27 17:42iperdomoStatusclosed => new
2011-07-27 17:42iperdomoResolutionfixed => open
2011-07-28 12:46iperdomoStatusnew => scheduled
2011-07-28 12:49hgbotCheckin
2011-07-28 12:49hgbotNote Added: 0039486
2011-07-28 12:49hgbotStatusscheduled => resolved
2011-07-28 12:49hgbotResolutionopen => fixed
2011-07-28 12:49hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/093f7a7b2e41559b88acb6cfbb7ae5b16a229e07 [^] => http://code.openbravo.com/erp/devel/pi/rev/8ca5a1c79fda53581f94ad16e2f2b7e601e361bf [^]
2011-08-01 14:19hudsonbotCheckin
2011-08-01 14:19hudsonbotNote Added: 0039609
2011-08-01 14:22hudsonbotCheckin
2011-08-01 14:22hudsonbotNote Added: 0039716
2011-08-03 20:45shuehnerNote Added: 0039848
2011-08-03 20:45shuehnerStatusresolved => closed

Notes
(0039138)
hgbot   
2011-07-18 09:31   
Repository: erp/devel/pi
Changeset: 093f7a7b2e41559b88acb6cfbb7ae5b16a229e07
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Mon Jul 18 09:30:46 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/093f7a7b2e41559b88acb6cfbb7ae5b16a229e07 [^]

Fixes issue 18015: Use the MainLayout.initilize() before starting the test
- Added other tags present in index.jsp to mimic the same environment
    (unrelated to the issue)

---
M modules/org.openbravo.client.kernel/web/org.openbravo.client.kernel/benchmark/index.html
---
(0039147)
mtaal   
2011-07-18 11:05   
tested and reviewed
(0039454)
iperdomo   
2011-07-27 17:42   
The benchmark is broken again, tested on revision 8ece2e79d7cc
(0039486)
hgbot   
2011-07-28 12:49   
Repository: erp/devel/pi
Changeset: 8ca5a1c79fda53581f94ad16e2f2b7e601e361bf
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Jul 28 12:48:25 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8ca5a1c79fda53581f94ad16e2f2b7e601e361bf [^]

Fixes issue 18015: Avoid network roundtrip in the test
- Use only Window.create, pure client side performace
- Remove the call to the server on each open tab

---
M modules/org.openbravo.client.kernel/web/org.openbravo.client.kernel/benchmark/index.html
---
(0039609)
hudsonbot   
2011-08-01 14:19   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^]

Maturity status: Test
(0039716)
hudsonbot   
2011-08-01 14:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^]

Maturity status: Test
(0039848)
shuehner   
2011-08-03 20:45   
Tested on pi/pgsql, test working again without js-errors. Also test is changed to not load a view definition from the server to exclude server runtime which could influence the test timing otherwise.