0017970: Enterprise Module Management is not working fine with * organization.

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0017970

Openbravo ERP

01. General setup

public

2011-07-12 14:41

2011-08-23 13:32

Reporter

dalsasua

Assigned To

jonalegriaesarte

Priority

normal

Severity

minor

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Ubuntu 10.10

Product Version

2.50MP31

Target Version

2.50MP31

Fixed in Version

2.50MP33

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Google Chrome, Internet Explorer, Mozilla Firefox

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0017970: Enterprise Module Management is not working fine with * organization.

Description

- Enterprise Module Management provides modules that shouldn't, as are already applied in * organization.
- Furthermore: accounting module shouldn't appear to be applied.

Steps To Reproduce

- As System Admin:
- go to Initial Client Setup
- choose as name 'Cliente'
- do NOT choose any reference data item (datasets). Specially, do NOT activate Initial Setup dataset from core module.
- change role to the new client
- run initial organization setup, and create a new legal entity withOUT acconting, with name Org
- set Org organization as ready
- go to enterprise module management
- apply core dataset to * organization
- go to Module window
- change version for module Core to a higher version number (activating in development flag)
- go to enterprise module management
- choose Org organization
- realize that the core module is provided to be applied
** This is wrong: core dataset has been already applied to * organization, so shouldn't be allowed to apply it to any other organization of the client, as all of them are bellow * organization in the organizational tree.

Proposed Solution

org.openbravo.erpCommon.modules.ModuleReferenceDataOrgTree_data.selectOrg() shouldn't provide the organization, or org.openbravo.erpCommon.modules.ModuleReferenceDataOrgTree.filterAlreadyApplied() should remove it from the data.

diff --git a/src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree_data.xsql b/src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree_data.xsql
--- a/src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree_data.xsql
+++ b/src/org/openbravo/erpCommon/modules/ModuleReferenceDataOrgTree_data.xsql
@@ -53,12 +53,12 @@
             WHERE M.TYPE = 'M'
             AND M.ISACTIVE = 'Y'
             AND 1=1
- AND ((EXISTS (SELECT 1 FROM ad_dataset
+ AND (EXISTS (SELECT 1 FROM ad_dataset
                             WHERE M.ad_module_id = AD_DATASET.ad_module_id
                             AND AD_DATASET.ACCESSLEVEL IN ('3','1')
                             AND AD_DATASET.EXPORTALLOWED = 'Y')
- AND M.HASREFERENCEDATA = 'Y')
- OR M.haschartofaccounts = 'Y')
+ AND M.HASREFERENCEDATA = 'Y'
+ AND M.HASCHARTOFACCOUNTS = 'N')
             AND NOT EXISTS (SELECT 1 FROM AD_CLIENTMODULE CM
                     WHERE CM.ad_module_id = M.ad_module_id
                     AND AD_CLIENT_ID = ?)
@@ -87,6 +87,7 @@
             AND 1=1
             AND M.HASREFERENCEDATA = 'Y'
             AND EXPORTALLOWED = 'Y'
+ AND M.HASCHARTOFACCOUNTS = 'N'
             AND NOT EXISTS (SELECT 1 FROM AD_CLIENTMODULE CM
                             WHERE CM.ad_module_id = M.ad_module_id
                             AND CM.AD_CLIENT_ID = ?
@@ -97,7 +98,7 @@
                             AND (AD_IsOrgIncluded(?, OM.AD_Org_ID, OM.AD_Client_ID)<>-1
                             OR AD_IsOrgIncluded(OM.AD_Org_ID, ?, OM.AD_Client_ID)<>-1)
                             AND OM.VERSION = M.VERSION)
- AND (((? <> '0') AND AD_DATASET.ACCESSLEVEL IN ('1', '3'))
+ AND (((? <> '0') AND AD_DATASET.ACCESSLEVEL IN ('1'))
                 OR ((? = '0') AND AD_DATASET.ACCESSLEVEL IN ('3', '6')))) A
           ORDER BY A.SeqNo
           ]]>

Additional Information