Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017955Openbravo ERPA. Platformpublic2011-07-11 15:452012-03-02 15:35
Reportershuehner 
Assigned Toguilleaer 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP9 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017955: 'Create fields' used on tab having fields already creates duplicates sequence numbers.
DescriptionUsing 'Create fields' to add new fields to an existing tab for newly added columns does assign sequence numbers to the new fields without taking into account sequence numbers of existing fields.

This leads to duplicate sequence numbers.

See example in the attached screenshot.
Steps To ReproduceCreate tab with some fields like shown in attached screenshot (fields of Openbravo Howtos module).
Add some new fields to the underlying table.
Use create fields in the tab to add the 3 new fields to it (n screenshot fields with Openbravo Howtos 2).
See that duplicate sequence numbers where created.
Proposed SolutionAssign new sequence numbers as :last-sequence number used in tab +10
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng 17955.png (49,073) 2011-07-11 15:46
https://issues.openbravo.com/file_download.php?file_id=4319&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-07-11 15:45shuehnerNew Issue
2011-07-11 15:45shuehnerAssigned To => alostale
2011-07-11 15:45shuehnerModules => Core
2011-07-11 15:46shuehnerFile Added: 17955.png
2011-08-05 12:56alostaleStatusnew => scheduled
2011-12-15 09:01alostaleAssigned Toalostale => guilleaer
2011-12-27 12:42guilleaerNote Added: 0044032
2012-02-07 17:46hgbotCheckin
2012-02-07 17:46hgbotNote Added: 0044915
2012-02-07 17:46hgbotStatusscheduled => resolved
2012-02-07 17:46hgbotResolutionopen => fixed
2012-02-07 17:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b25e86b22d004695a2f5b3c8e2604756122e7b48 [^]
2012-02-07 17:49alostaleNote Added: 0044916
2012-02-07 17:49alostaleStatusresolved => new
2012-02-07 17:49alostaleResolutionfixed => open
2012-02-10 09:47hgbotCheckin
2012-02-10 09:47hgbotNote Added: 0044992
2012-02-10 09:47hgbotStatusnew => resolved
2012-02-10 09:47hgbotResolutionopen => fixed
2012-02-10 09:47hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/b25e86b22d004695a2f5b3c8e2604756122e7b48 [^] => http://code.openbravo.com/erp/devel/pi/rev/c8bbab77e3296d5bc283fa1e67617a174c6d26c9 [^]
2012-02-21 10:05alostaleNote Added: 0045296
2012-02-21 10:05alostaleStatusresolved => closed
2012-02-21 10:05alostaleFixed in Version => 3.0MP9
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045771
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045793

Notes
(0044032)
guilleaer   
2011-12-27 12:42   
Test plan:
1. Log in as System Administrator
2. do a search for a table which is showed in a tab. E.G. m_product
3. Annotate the seqNo of the last field of the tab
4. Add one or more columns to the table using "tables and columns" screen.
5. Look for the tab which will show the table in "windows tab and fields" screen. E.G. Window: product, Tab: product
6. Select the tab (Product in this case) and run the process "Create fields". This process should create the new fields.
7. The new field(s) should have a correct seqNo (The last seqNo + 10).

No regressions detected.
(0044915)
hgbot   
2012-02-07 17:46   
Repository: erp/devel/pi
Changeset: b25e86b22d004695a2f5b3c8e2604756122e7b48
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Feb 07 15:57:02 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b25e86b22d004695a2f5b3c8e2604756122e7b48 [^]

Fixed issue 17955: Now sequence numbers are genetared correctly using 'create fields'

---
M src-db/database/model/functions/AD_TAB_IMPORT.xml
---
(0044916)
alostale   
2012-02-07 17:49   
Fix is not working when there is no field in the tab.
(0044992)
hgbot   
2012-02-10 09:47   
Repository: erp/devel/pi
Changeset: c8bbab77e3296d5bc283fa1e67617a174c6d26c9
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Fri Feb 10 08:49:15 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c8bbab77e3296d5bc283fa1e67617a174c6d26c9 [^]

Fixed issue 17955: Now sequence numbers are generated correctly using 'create fields'

---
M src-db/database/model/functions/AD_TAB_IMPORT.xml
---
(0045296)
alostale   
2012-02-21 10:05   
Code reviewed and tested on pi@8e3bca6e8153
(0045771)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045793)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test