Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017857Openbravo ERPA. Platformpublic2011-06-30 19:222012-04-26 11:23
Reportershuehner 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP11 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017857: CSV export of Query List widget uses wrong labels for columns headers
DescriptionThe CSV export of the QueryListWidget is using internal column/property names when exporting the widget instead of the names shown i.e. in the querylistwidget grid itself..

Example internal names used in the csv file
organizationName
documentNo
businessPartnerName

User-visible normal names:
Document Number
Business Partner
Date

Also the order of the seems doesn't correntpond to the order shown in the query list grid.

Probably (not tested) no translation of the column headers is done
Steps To Reproducesee description. Export data of i.e. 'Invoices to collect' query list widget as a csv-file and compare first line of this csv-file with grid shown (on screen) for the widget.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00167473.0MP1 closed marvintm csv export of querylist widget uses wrong quoting for header fields 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-06-30 19:22shuehnerNew Issue
2011-06-30 19:22shuehnerAssigned To => alostale
2011-06-30 19:22shuehnerModules => Core
2011-06-30 19:22shuehnerRelationship addedrelated to 0016747
2011-08-05 13:02alostaleStatusnew => scheduled
2011-08-05 13:02alostalefix_in_branch => pi
2012-04-11 12:46alostaleNote Added: 0047482
2012-04-11 12:46alostaleAssigned Toalostale => migueldejuana
2012-04-12 16:09hgbotCheckin
2012-04-12 16:09hgbotNote Added: 0047532
2012-04-12 16:09hgbotStatusscheduled => resolved
2012-04-12 16:09hgbotResolutionopen => fixed
2012-04-12 16:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a3138b899536313ec220b47b39549ed5943d3bba [^]
2012-04-12 16:15migueldejuanaNote Added: 0047533
2012-04-17 05:31hudsonbotCheckin
2012-04-17 05:31hudsonbotNote Added: 0047642
2012-04-26 11:23alostaleNote Added: 0048001
2012-04-26 11:23alostaleStatusresolved => closed
2012-04-26 11:23alostaleFixed in Version => 3.0MP11

Notes
(0047482)
alostale   
2012-04-11 12:46   
Note that translations should also be taken into account to translate labels.
(0047532)
hgbot   
2012-04-12 16:09   
Repository: erp/devel/pi
Changeset: a3138b899536313ec220b47b39549ed5943d3bba
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Thu Apr 12 16:07:37 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a3138b899536313ec220b47b39549ed5943d3bba [^]

Fixed issue 17857: Exporting QueryListWidget, headers are labels instead of ids
The CSV export of the QueryListWidget was using internal column/property names when exporting the widget. Now is showing the names showed in the querylistwidget grid itself.
The order of the columns in the exported file is ok. It's exporting the whole grid (as same as maximized window).

---
M modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListDataSource.java
M modules/org.openbravo.client.querylist/src/org/openbravo/client/querylist/QueryListUtils.java
---
(0047533)
migueldejuana   
2012-04-12 16:15   
Widget exports the whole grid as same as maximized window. If we want to change this, exporting only the columns showed in the grid of the widget, we have to change QueryListDataSource.java:

Put:

if (queryAliases[i].equals(column.getDisplayExpression())
                && (viewMode.equals("maximized") || viewMode.equals("widget")
                    && column.getIncludeIn().equals("W"))
                || (!isExport && queryAliases[i].equals(column.getLinkExpression())))

Instead of:

if (queryAliases[i].equals(column.getDisplayExpression())
                || (!isExport && queryAliases[i].equals(column.getLinkExpression())))
(0047642)
hudsonbot   
2012-04-17 05:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cedf57621434 [^]

Maturity status: Test
(0048001)
alostale   
2012-04-26 11:23   
Code reviewed and verified on pi@d02dd5df46fe

Tested with base module language as well as with translation.