Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0017846Openbravo ERP09. Financial managementpublic2011-06-30 13:072011-08-10 12:52
psanjuan 
adrianromero 
urgentmajoralways
closedfixed 
20Ubuntu 8.04.1
 
3.0MP2 
Core
No
0017846: Multicurrency - finacc_txn_convert_rate numeric field in the DB is showing more than 6 characters
finacc_txn_convert_rate numeric is showing more than 6 characters.
see screen attached.
finacc_txn_convert_rate_numeric must be cut to show 6 decimals.
No tags attached.
png 17846.png (52,264) 2011-06-30 13:09
https://issues.openbravo.com/file_download.php?file_id=4259&type=bug
png
Issue History
2011-06-30 13:07psanjuanNew Issue
2011-06-30 13:07psanjuanAssigned To => eintelau
2011-06-30 13:07psanjuanModules => Core
2011-06-30 13:09psanjuanFile Added: 17846.png
2011-07-05 11:39psanjuanAssigned Toeintelau => eduardo_Argal
2011-07-07 02:24dmitry_mezentsevAssigned Toeduardo_Argal => shuehner
2011-07-07 02:24dmitry_mezentsevTarget Version => 3.0MP2
2011-07-18 12:40shuehnerAssigned Toshuehner => iperdomo
2011-07-18 12:40shuehnerNote Added: 0039157
2011-07-19 08:53iperdomoStatusnew => scheduled
2011-07-19 08:53iperdomoAssigned Toiperdomo => adrianromero
2011-07-19 08:53iperdomofix_in_branch => pi
2011-07-22 09:51hgbotCheckin
2011-07-22 09:51hgbotNote Added: 0039320
2011-07-22 09:51hgbotStatusscheduled => resolved
2011-07-22 09:51hgbotResolutionopen => fixed
2011-07-22 09:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b67d11a30224f62af69c2add4044370739abf65f [^]
2011-07-22 09:51hgbotCheckin
2011-07-22 09:51hgbotNote Added: 0039321
2011-07-22 09:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/b67d11a30224f62af69c2add4044370739abf65f [^] => http://code.openbravo.com/erp/devel/pi/rev/a89603e590744fc487ea714a85705c6bb9655d00 [^]
2011-07-22 09:51hgbotCheckin
2011-07-22 09:51hgbotNote Added: 0039322
2011-07-22 09:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/a89603e590744fc487ea714a85705c6bb9655d00 [^] => http://code.openbravo.com/erp/devel/pi/rev/56151e1a260f5ce2984fc1b21e903873f69a22f9 [^]
2011-07-22 10:13adrianromeroNote Added: 0039324
2011-08-01 14:21hudsonbotCheckin
2011-08-01 14:21hudsonbotNote Added: 0039661
2011-08-01 14:21hudsonbotCheckin
2011-08-01 14:21hudsonbotNote Added: 0039662
2011-08-01 14:21hudsonbotCheckin
2011-08-01 14:21hudsonbotNote Added: 0039663
2011-08-10 12:52iperdomoNote Added: 0040073
2011-08-10 12:52iperdomoStatusresolved => closed

Notes
(0039157)
shuehner   
2011-07-18 12:40   
note: similar failure case: activate audit trail for c_bpartner. Edit i.e. name or name2 of existing record and see that some unrelated decimal fields change value in the db.
(0039320)
hgbot   
2011-07-22 09:51   
Repository: erp/devel/pi
Changeset: b67d11a30224f62af69c2add4044370739abf65f
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Jul 20 18:41:24 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b67d11a30224f62af69c2add4044370739abf65f [^]

Fixes issue 0017846: Multicurrency - finacc_txn_convert_rate numeric field in the DB is showing more than 6 characters
It has been formatted-parsed the data that comes from callout to fix the number of decimals according the field properties

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0039321)
hgbot   
2011-07-22 09:51   
Repository: erp/devel/pi
Changeset: a89603e590744fc487ea714a85705c6bb9655d00
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Jul 21 15:35:12 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a89603e590744fc487ea714a85705c6bb9655d00 [^]

Fixes issue 0017846: Multicurrency - finacc_txn_convert_rate numeric field in the DB is showing more than 6 characters
It has been formatted-parsed the data that comes from callout to fix the number of decimals according the field properties

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0039322)
hgbot   
2011-07-22 09:51   
Repository: erp/devel/pi
Changeset: 56151e1a260f5ce2984fc1b21e903873f69a22f9
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Jul 22 09:48:20 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/56151e1a260f5ce2984fc1b21e903873f69a22f9 [^]

Fixes issue 0017846: Multicurrency - finacc_txn_convert_rate numeric field in the DB is showing more than 6 characters
Moved var declarations to the begining of the function to follow style guide

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0039324)
adrianromero   
2011-07-22 10:13   
* Testing the issue

Go the the window Conversion Rates, edit any record and change the value Multiply Rate to a value with more than 6 decimals "0.6666666666" and save.

Verify that in the window appears "0.666667" The value has been properly rounded to 6 decimals.

Go to the database and select the data of the table C_CONVERSION_RATE has also the value rounded "0.666667"

* Other areas affected

It has been modified how callout return values are sent to the window, so it affects almost all application. Verify also that most common windows with some callouts also work. For example. Verify that invoice lines can be created properly: When selecting a product price values are populated, when changing the quantity, the total of the line is also properly calculated, etc.
(0039661)
hudsonbot   
2011-08-01 14:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^]

Maturity status: Test
(0039662)
hudsonbot   
2011-08-01 14:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^]

Maturity status: Test
(0039663)
hudsonbot   
2011-08-01 14:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^]

Maturity status: Test
(0040073)
iperdomo   
2011-08-10 12:52   
Tested on pi @ rev 8aee66a7a153