|
Notes |
|
|
|
The problem is WindowTree call is spending a lot of time (in attached Selection_036.png is 2.34s).
Concretely, the time consuming part is checking possible tree cycles by ad_parent_tree pl function.
This function exits recusivity only when exception occurs, the solution is not to wait for exception to occur but correctly exit by detecting the case that would raise exception. |
|
|
|
|
After applying the fix the time is reduced to 21ms.
There is no regression risk on this fix because it is changing the implementation of ad_parent_tree but returning the same result.
Test plan:
* To ensure the current result of ad_parent_tree is the same as it was before:
-create a db function (ad_parent_tree_orig) as it was previously to the fix.
-compare results of new and old function for all menu entries, the result of this query should be 0:
select count(*)
from (select node_id from ad_treenode where ad_tree_id ='10') a
where ad_parent_tree('10', node_id) != ad_parent_tree_orig('10', node_id) |
|
|
|
|
|
Attached export as pi is currently frozen for mp9 |
|
|
|
(0046065)
|
|
hgbot
|
|
2012-03-06 08:45
|
|
Repository: erp/devel/pi
Changeset: 9644db90eb375b62a0680acf6ca8112471b80201
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 01 12:34:27 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9644db90eb375b62a0680acf6ca8112471b80201 [^]
fixed bug 17821: Improved performance in ad_parent_tree function
Proper exit recursivity instead of waiting for an exception to be thrown
---
M src-db/database/model/functions/AD_PARENT_TREE.xml
---
|
|
|
|
|
|
Selection_036.png (8,284) 2012-03-01 12:05
17821.export (1,323) 2012-03-01 12:35