Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017811Openbravo ERPY. DBSourceManagerpublic2011-06-28 13:532011-07-13 11:54
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017811: Function&Trigger-Standardization on pgsql could be made 5-10s faster
Descriptionby removing one translation regex which is not changing anything.


    append(new ByLineTranslation(new ReplacePatTranslation(
        "(.+?)(v_pesos|v_units|v_tens|v_hundreds|v_tenys|v_twentys)(\\[)(.+?)(\\])([^\\)]+?)$",
        "$1$2[$4]$6")));

This regex in the PostgrePLSQLStandardization does not do any changes to the string but takes some (accumulated) 5-10s at runtime (depending on system).

Steps To Reproducen/a
Proposed SolutionRemove the regex as it doesn't do any changes.
Additional Information
TagsNo tags attached.
Relationships
blocks defect 00178103.0MP1 closed shuehner Function&Trigger-Standardization on pgsql could be made 5-10s faster 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-06-28 13:53shuehnerTypedefect => backport
2011-06-28 13:53shuehnerfix_in_branch => 2.50
2011-06-30 15:48hgbotCheckin
2011-06-30 15:48hgbotNote Added: 0038638
2011-06-30 15:48hgbotStatusscheduled => resolved
2011-06-30 15:48hgbotResolutionopen => fixed
2011-06-30 15:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/9d15a8304226f6069cad17b461bcd319cd74da8c [^]
2011-07-01 18:22marvintmStatusresolved => closed
2011-07-04 13:26hgbotCheckin
2011-07-04 13:26hgbotNote Added: 0038744
2011-07-04 13:26hgbotStatusclosed => resolved
2011-07-04 13:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/9d15a8304226f6069cad17b461bcd319cd74da8c [^] => http://code.openbravo.com/erp/stable/2.50/rev/97f5209c1da61cee36615837f7fd8e57a312fc0d [^]
2011-07-13 11:54marvintmStatusresolved => closed

Notes
(0038638)
hgbot   
2011-06-30 15:48   
Repository: erp/devel/dbsm-main
Changeset: 9d15a8304226f6069cad17b461bcd319cd74da8c
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jun 28 13:55:44 2011 +0200
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/9d15a8304226f6069cad17b461bcd319cd74da8c [^]

Fixed 17810, Fixed 17811: Make pgsql function & trigger standardization faster
This removes a regex application which is not changing anything in the data so
can be removed without functional changes. Gains some 5-10s at runtime depending
on system.

---
M src/org/apache/ddlutils/platform/postgresql/PostgrePLSQLStandarization.java
---
(0038744)
hgbot   
2011-07-04 13:26   
Repository: erp/stable/2.50
Changeset: 97f5209c1da61cee36615837f7fd8e57a312fc0d
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jun 28 15:48:27 2011 +0200
URL: http://code.openbravo.com/erp/stable/2.50/rev/97f5209c1da61cee36615837f7fd8e57a312fc0d [^]

Fixed 17809, Fixed 17811: Speed up model loading
- part one: read tables on oracle faster
- part two: function/trigger standardization on pgsql faster

---
M src-db/database/lib/dbsourcemanager.jar
---