Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0017789Openbravo ERPA. Platformpublic2011-06-27 13:512011-07-06 02:43
malsasua 
marvintm 
urgentmajoralways
closedfixed 
20Community Appliance
3.0MP0 
3.0MP1 
OBPS
Core
No
0017789: the number formats in CSV file generated by export grid process is not right
in the CSV file generated to export grid , the numbers can not be included in formules
. go to Invoice (customer)
. run process export to CSV
No tags attached.
Issue History
2011-06-27 13:51malsasuaNew Issue
2011-06-27 13:51malsasuaAssigned To => alostale
2011-06-27 13:51malsasuaModules => Core
2011-06-27 13:51malsasuaOBNetwork customer => Yes
2011-06-28 10:28malsasuaNote Added: 0038553
2011-06-28 15:15malsasuaTarget Version => 3.0MP1
2011-06-29 08:40alostaleStatusnew => scheduled
2011-06-29 08:40alostaleAssigned Toalostale => marvintm
2011-06-29 08:40alostalefix_in_branch => pi
2011-06-29 12:43hgbotCheckin
2011-06-29 12:43hgbotNote Added: 0038582
2011-06-29 12:43hgbotStatusscheduled => resolved
2011-06-29 12:43hgbotResolutionopen => fixed
2011-06-29 12:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5f71b77c16844393cd0e672fd88fde10a57b95bb [^]
2011-06-30 18:00hgbotCheckin
2011-06-30 18:00hgbotNote Added: 0038646
2011-06-30 18:01hgbotCheckin
2011-06-30 18:01hgbotNote Added: 0038647
2011-06-30 18:21hgbotCheckin
2011-06-30 18:21hgbotNote Added: 0038650
2011-07-04 10:29hgbotCheckin
2011-07-04 10:29hgbotNote Added: 0038732
2011-07-05 13:44hgbotCheckin
2011-07-05 13:44hgbotNote Added: 0038779
2011-07-05 15:50hgbotCheckin
2011-07-05 15:50hgbotNote Added: 0038783
2011-07-05 16:16shuehnerNote Added: 0038784
2011-07-05 16:19shuehnerNote Added: 0038785
2011-07-05 16:19shuehnerStatusresolved => closed
2011-07-06 02:41hudsonbotCheckin
2011-07-06 02:41hudsonbotNote Added: 0038821
2011-07-06 02:42hudsonbotCheckin
2011-07-06 02:42hudsonbotNote Added: 0038840
2011-07-06 02:42hudsonbotCheckin
2011-07-06 02:42hudsonbotNote Added: 0038841
2011-07-06 02:42hudsonbotCheckin
2011-07-06 02:42hudsonbotNote Added: 0038842
2011-07-06 02:43hudsonbotCheckin
2011-07-06 02:43hudsonbotNote Added: 0038875
2011-07-06 02:43hudsonbotCheckin
2011-07-06 02:43hudsonbotNote Added: 0038883
2011-07-06 02:43hudsonbotCheckin
2011-07-06 02:43hudsonbotNote Added: 0038885

Notes
(0038553)
malsasua   
2011-06-28 10:28   
. please, check the CSV with Microsoft Excel
(0038582)
hgbot   
2011-06-29 12:43   
Repository: erp/devel/pi
Changeset: 5f71b77c16844393cd0e672fd88fde10a57b95bb
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jun 29 12:42:23 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5f71b77c16844393cd0e672fd88fde10a57b95bb [^]

Fixed issue 17789. Done the following changes to the formatting of CSVs:
- Added the capability to configure the decimal format (for CSVs only) via a preference. This preference overwrites the Format.xml setting in case it is defined.
- Added Property values for this preference, and also for the one which allows the user to change the field separator.
- Done a change so that numeric property values are exported without quotes, so that Excel and similar systems import the file correctly
- If the decimal separator and the field separator are equal, the field separator is changed so that the CSV file is correct

---
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
R modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_PREFERENCE.xml
---
(0038646)
hgbot   
2011-06-30 18:00   
Repository: erp/devel/pi
Changeset: e861861de87cfb76860700f17932b97a74bf1cb3
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Jun 30 17:42:36 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e861861de87cfb76860700f17932b97a74bf1cb3 [^]

Related to issue 17789. Changed encoding of generated CSV files so that they work seamlessly with Excel

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0038647)
hgbot   
2011-06-30 18:01   
Repository: erp/devel/pi
Changeset: 3dc747db65f2af417cc8929fc47a055ad7e28414
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Jun 30 17:57:40 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3dc747db65f2af417cc8929fc47a055ad7e28414 [^]

Related to issue 17789. Changed encoding of generated CSV files so that they work seamlessly with Excel

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0038650)
hgbot   
2011-06-30 18:21   
Repository: erp/devel/pi
Changeset: 55dc67170bd7da6a7d1c2aad8403daf723ec258b
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Jun 30 18:20:22 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/55dc67170bd7da6a7d1c2aad8403daf723ec258b [^]

Related to issue 17789. Added a preference so the user can change the file encoding. Improved other preference descriptions

---
M modules/org.openbravo.service.datasource/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0038732)
hgbot   
2011-07-04 10:29   
Repository: erp/devel/pi
Changeset: c3dd7be39178eef794354f73bb6d0348a5919b7c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jul 04 10:28:33 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c3dd7be39178eef794354f73bb6d0348a5919b7c [^]

Related to issue 17789. The preference for the decimal separator will be correctly used if it is set.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0038779)
hgbot   
2011-07-05 13:44   
Repository: erp/devel/pi
Changeset: 05cdc556ab64ca26036b87a45e1f8101581a07aa
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jul 05 13:42:54 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/05cdc556ab64ca26036b87a45e1f8101581a07aa [^]

Related to issue 17789.
> The correct preference (regarding client, org, user and role) will be picked.
> Also fixed problem in case the decimal separator had more than one char.

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0038783)
hgbot   
2011-07-05 15:50   
Repository: erp/devel/pi
Changeset: 89b11e5682fb9ed3cf30a7954d1f1cc0debb38bf
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Jul 05 15:48:42 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/89b11e5682fb9ed3cf30a7954d1f1cc0debb38bf [^]

Related to issue 17789.
Added window information to preference retrieval to avoid problems in case the user defines the preference linked to a particular window

---
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0038784)
shuehner   
2011-07-05 16:16   
Reviewed+partially test on pi/pgsql/chromium (rev id: 89b11e5682fb). Code changes work as implemented (three new preferences have been added to control: encoding,field-separator,decimal-separator(overrides format.xml for this purpose). + Default encoding changed to iso-8859-1 instead of utf-8. To match what MS-excel seems to expect.
(0038785)
shuehner   
2011-07-05 16:19   
Expected behavior change tested by PSA on windows using ms-excel; working fine
(0038821)
hudsonbot   
2011-07-06 02:41   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^]

Maturity status: Test
(0038840)
hudsonbot   
2011-07-06 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^]

Maturity status: Test
(0038841)
hudsonbot   
2011-07-06 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^]

Maturity status: Test
(0038842)
hudsonbot   
2011-07-06 02:42   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^]

Maturity status: Test
(0038875)
hudsonbot   
2011-07-06 02:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^]

Maturity status: Test
(0038883)
hudsonbot   
2011-07-06 02:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^]

Maturity status: Test
(0038885)
hudsonbot   
2011-07-06 02:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f1c481b1a146 [^]

Maturity status: Test