Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017642Openbravo ERPA. Platformpublic2011-06-14 17:502011-10-12 02:01
Reporterrgoris 
Assigned Tomirurita 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP5Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017642: Customer Card does not appear for Sales role
DescriptionCustomer card is not role dependant but for some roles it cannot be accessed. See PDF attached

http://46.137.53.34 [^] MP0
Steps To ReproduceChoose sales role
Open BP
PRess print button
Error!
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespdf CustomerCard.pdf (322,759) 2011-06-14 17:50
https://issues.openbravo.com/file_download.php?file_id=4201&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-06-14 17:50rgorisNew Issue
2011-06-14 17:50rgorisAssigned To => alostale
2011-06-14 17:50rgorisFile Added: CustomerCard.pdf
2011-06-14 17:50rgorisModules => Core
2011-06-22 19:57dmitry_mezentsevTarget Version3.0MP1 => 3.0MP2
2011-07-19 13:46alostaleNote Added: 0039229
2011-07-19 13:46alostaleStatusnew => feedback
2011-07-19 13:52alostaleNote Edited: 0039229bug_revision_view_page.php?bugnote_id=0039229#r2453
2011-07-19 17:01dmitry_mezentsevNote Added: 0039241
2011-07-20 11:59alostaleAssigned Toalostale => psarobe
2011-07-20 11:59alostaleStatusfeedback => new
2011-08-03 11:34psarobeNote Added: 0039802
2011-08-03 11:35psarobeStatusnew => scheduled
2011-08-03 11:35psarobeTarget Version3.0MP2 => 3.0MP4
2011-08-03 18:41dmitry_mezentsevNote Added: 0039842
2011-09-15 12:52dalsasuaAssigned Topsarobe => mirurita
2011-09-30 10:13jonalegriaesarteNote Added: 0041394
2011-09-30 10:13jonalegriaesarteTarget Version3.0MP4 => 3.0MP5
2011-10-03 09:52hgbotCheckin
2011-10-03 09:52hgbotNote Added: 0041444
2011-10-03 09:52hgbotStatusscheduled => resolved
2011-10-03 09:52hgbotResolutionopen => fixed
2011-10-03 09:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/24587ac048e3e193ede55274354ed48000628991 [^]
2011-10-03 10:02hgbotCheckin
2011-10-03 10:02hgbotNote Added: 0041445
2011-10-03 10:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/24587ac048e3e193ede55274354ed48000628991 [^] => http://code.openbravo.com/erp/devel/pi/rev/c2792d8279d7acf395242c97b18695b0bbb1bca2 [^]
2011-10-03 10:10miruritaNote Added: 0041448
2011-10-10 16:03maiteNote Added: 0041569
2011-10-10 16:03maiteStatusresolved => closed
2011-10-12 02:00hudsonbotCheckin
2011-10-12 02:00hudsonbotNote Added: 0041744
2011-10-12 02:01hudsonbotCheckin
2011-10-12 02:01hudsonbotNote Added: 0041745

Notes
(0039229)
alostale   
2011-07-19 13:46   
(edited on: 2011-07-19 13:52)
It is working as designed: Customer Card is printed by a process (Bpartner print), in order to execute this process is not enough to have access to the window that invokes it but also to explicitly have access to it. In this case, the role you are using has not access to it.

This happens for the two kind of processes/reports that can be launched from tabs:

-Action buttons, executed from right toolbar buttons.
-Print processes, executed from print left toolbar icon.

Should we change this desing? If so, following which approach? I see the following solutions:

1. Do nothing. Leave as it is now, which is the current design.
2. Behave in the same way as now but regarding access do not display the button because you don't have access, if we implement this one, should it also be applied for action buttons or just print ones? The problem (benefit??) of this implementation is that user is not aware of this capability that otherwise could ask administrator for access.
3. Treat this concrete report as an exception giving access not directly but inheriting it from BP window. Why should this one be different? Note it changes existent privileges on this case (see #4)
4. Inherit access from tab: granting access to the tab would grant access to the process. Again deciding which kind of buttons is applicable to. Note that this would be a huge change in the way security is implemented and it might make sense cases where access to the tab is granted but not to its processes.
(0039241)
dmitry_mezentsev   
2011-07-19 17:01   
I vote for the option 1. Makes sense for me to have different permissions for window access and for related actions.

But to fix the issue we need then to add access for the Procurement, Sales, Finance, Company Executive roles included into Openbravo 3 Dataset and also to sample data access to this button (process).
(0039802)
psarobe   
2011-08-03 11:34   
Please Dmitry create another issue for the roles datasets
(0039842)
dmitry_mezentsev   
2011-08-03 18:41   
Pablo,

You mean you would like to have 2 issues? One for Sample Data, another - for the Core Roles Dataset?
(0041394)
jonalegriaesarte   
2011-09-30 10:13   
Due to the load with other issues we were not able to research this one for MP4, are planning MP5 for it now.
(0041444)
hgbot   
2011-10-03 09:52   
Repository: erp/devel/pi
Changeset: 24587ac048e3e193ede55274354ed48000628991
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Fri Sep 30 14:34:22 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/24587ac048e3e193ede55274354ed48000628991 [^]

Fixes issue 17642: sampledata (F&B) grant access to Bpartner print process.
Granted access to the following roles:
- F&B España, S.A. - Finance & HR
- F&B US, Inc. - Finance & HR
- F&B US, Inc. - Sales
- F&B España, S.A. - Sales
- Company Executive - Spain

---
M referencedata/sampledata/F_B_International_Group.xml
---
(0041445)
hgbot   
2011-10-03 10:02   
Repository: erp/devel/pi
Changeset: c2792d8279d7acf395242c97b18695b0bbb1bca2
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Mon Oct 03 10:00:25 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c2792d8279d7acf395242c97b18695b0bbb1bca2 [^]

Fixes issue 17642: v3 roles dataset grant access to Bpartner print process.
Finance, Sales, Company Executive, Purchase Management

---
M modules/org.openbravo.v3.datasets/referencedata/standard/V3_Roles.xml
---
(0041448)
mirurita   
2011-10-03 10:10   
After granting access to the roles the Partner Card is showing an error in case the partner has multicurrency payments

For example, if you try with Moon Light Restaurants, Co.

ERROR: @NoConversionRate@ (USD-$) @to@ (EUR-€) @ForDate@ '18-08-2010', @Client@ 'System' @And@ @ACCS_AD_ORG_ID_D@ '*'. Where: PL/pgSQL function "c_currency_convert" line 3 at RETURN PL/pgSQL function "c_currency_convert" line 3 at RETURN

The process is trying to get a conversion rate defined for Client 0 and Org 0.
As in the F&B, there are not conversion rates defined for system it is failing.
It should look first for the client and org specific and finally for the system conversion rates.
(0041569)
maite   
2011-10-10 16:03   
verified
(0041744)
hudsonbot   
2011-10-12 02:00   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0041745)
hudsonbot   
2011-10-12 02:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test