Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017636Openbravo ERPA. Platformpublic2011-06-14 12:002011-12-30 14:01
Reporterrgoris 
Assigned Todbaz 
PriorityurgentSeveritymajorReproducibilityrandom
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017636: [KS] No KS for pressing confirmation or Cancel button in popups (lightboxes)
DescriptionNormally you should be able to tab to a button and by pressing the Space bar, you execute the button action. THis does not always work in the process lightbox dialogs.
Steps To ReproduceIn grid view:

Get a completed "Sales Invoice"
Ctrl-alt-shift-R for Reactivate
Try to confirm the dialog using the keyboard (does not work)

Try to cancel using ESC (does not work)
Proposed Solution
Additional Information
TagsOB3-Reviewed
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-06-14 12:00rgorisNew Issue
2011-06-14 12:00rgorisAssigned To => dbaz
2011-06-14 12:00rgorisModules => Core
2011-06-14 12:00rgorisOBNetwork customer => No
2011-06-18 10:01rgorisStatusnew => scheduled
2011-06-22 15:16rgorisPriorityhigh => urgent
2011-06-28 21:40dbazTarget Version3.0MP1 => 3.0MP2
2011-06-30 15:01rgorisDescription Updatedbug_revision_view_page.php?rev_id=2325#r2325
2011-06-30 15:01rgorisSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=2327#r2327
2011-06-30 15:02rgorisSummary[KS] No KS for pressing confirmation button in popups (lightboxes) => [KS] No KS for pressing confirmation or Cancel button in popups (lightboxes)
2011-06-30 15:02rgorisSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=2328#r2328
2011-07-20 12:27dbazTarget Version3.0MP2 => 3.0MP3
2011-08-31 13:46dbazTarget Version3.0MP3 =>
2011-10-28 20:56iciordiaTag Attached: OB3-Reviewed
2011-12-07 20:05rgorisNote Added: 0043741
2011-12-28 21:41dbazNote Added: 0044061
2011-12-28 21:52dbazReproducibilityalways => random
2011-12-28 21:52dbazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3002#r3002
2011-12-28 21:54hgbotCheckin
2011-12-28 21:54hgbotNote Added: 0044062
2011-12-28 21:54hgbotStatusscheduled => resolved
2011-12-28 21:54hgbotResolutionopen => fixed
2011-12-28 21:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/05ba1ff752909cf831f42096dd5369afb86b87e0 [^]
2011-12-29 11:02iperdomoNote Added: 0044070
2011-12-29 11:02iperdomoStatusresolved => closed
2011-12-30 14:01hudsonbotCheckin
2011-12-30 14:01hudsonbotNote Added: 0044082

Notes
(0043741)
rgoris   
2011-12-07 20:05   
Only happens in grid view. Once again here are the steps:

grid
select row
ctrl+alt+shift+r
arrow key down
tab (nothing happens)
(0044061)
dbaz   
2011-12-28 21:41   
The real problem is that, once loaded the popup, the focus goes to the hidden menu frame
(0044062)
hgbot   
2011-12-28 21:54   
Repository: erp/devel/pi
Changeset: 05ba1ff752909cf831f42096dd5369afb86b87e0
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Dec 28 21:54:06 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/05ba1ff752909cf831f42096dd5369afb86b87e0 [^]

Fixed issue 17636: now hidden menu frame doesn't get the focus automatically

---
M web/js/utils.js
---
(0044070)
iperdomo   
2011-12-29 11:02   
Code reviewed. Using isWindowInMDIPage global variable in generated code to identify if the the popup is redered inside a "modal dialog".

Tested in pi @ rev a590790e573b

- Create a new sales invoice
- Add a line
- Change the header to grid mode
- Use CTRL+SHFT+ALT+C to complete
- Move using the TAB key and place the focus in the OK button, hit SPACE key
- Use CTRL+SHFT+ALT+R to reactivate
- Move using the TAB key and place the focus in the OK button, hit SPACE key
- Repeat the flow 5+ times
(0044082)
hudsonbot   
2011-12-30 14:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/90c08638786e [^]

Maturity status: Test