Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0017609Openbravo ERPA. Platformpublic2011-06-10 19:342022-02-01 08:05
shuehner 
Triage Platform Base 
normalminorhave not tried
acknowledgedopen 
5
 
 
Core
No
0017609: Code-review for issue: 16639
This issue list some things found while doing code-review for 16639:

a.) New column 'ISEXCLUDEAUDIT' in table ad_column is missing standard boolean constraint
b.) Help text for same new column mentions 'Y' value in a boolean column. Not understable by user, as char(1) with Y,N is technical low-level detail.
c.) SL_TableAudit callout, why does code-path for excluding-columns also check and modify SessionInfo.setAuditActive at all? Excluding individual columns does not change global audit state.
d.) AuditTrailPopup.java, in code showing list of excluded columns, add ' ' space after , do make reading list with more than one element easier
e.) I AuditTrailPopup.java, extend utility function: getExcludeAuditColumnNames as the three places calling them look exactly identical. I.e. Let it return final translated string to be passed into the xmlEngine parameter.
N/A
OB3-Reviewed
has duplicate design defect 0031425 acknowledged Triage Platform Base many boolean columns incorrectly defined in AD and DB 
related to feature request 0016639 closed thirumalaik Exclude column from audit 
Issue History
2011-06-10 19:34shuehnerNew Issue
2011-06-10 19:34shuehnerAssigned To => alostale
2011-06-10 19:34shuehnerModules => Core
2011-06-10 19:34shuehnerRelationship addedrelated to 0016639
2011-06-14 06:02thirumalaikIssue Monitored: thirumalaik
2011-06-22 19:41dmitry_mezentsevTarget Version3.0MP1 => 3.0MP3
2011-07-26 17:28alostaleStatusnew => scheduled
2011-08-05 10:37alostaleAssigned Toalostale => thirumalaik
2011-09-01 15:52alostaleTarget Version3.0MP3 => 3.0MP4
2011-09-27 10:30iperdomoTarget Version3.0MP4 =>
2011-10-28 20:31iciordiaTag Attached: OB3-Reviewed
2011-10-28 20:31iciordiaAssigned Tothirumalaik => alostale
2015-03-11 15:31alostaleStatusscheduled => feedback
2015-03-11 15:32alostaleStatusfeedback => new
2015-03-17 14:37alostaleAssigned Toalostale => platform
2015-11-11 11:02alostaleRelationship addedhas duplicate 0031425
2015-11-11 11:03alostaleStatusnew => acknowledged
2022-02-01 08:05alostaleAssigned Toplatform => Triage Platform Base

There are no notes attached to this issue.