Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0017594Openbravo ERPY. DBSourceManagerpublic2011-06-10 12:002011-07-14 15:54
maite 
marvintm 
highminorhave not tried
closedfixed 
5
2.50MP30 
 
Core
No
0017594: The validation of modules done on export.database shows errors which belong to a module in the core module
If a module adds a column to a core table, then the validation done on export.database does show a validation error (if one exists) in the core module for this column instead of in the module.

Example where the 347 module module adds a new field to m_product (from core)

+++++++++++++++++++++++++++++++++++++++++++++++++++
Warnings for Validation type: NOT_PART_OF_FOREIGN_KEY
+++++++++++++++++++++++++++++++++++++++++++++++++++
Foreign Key Column M_PRODUCT.EM_Aeat347_Regioncode is not part of a foreign key constraint.
No tags attached.
depends on defect 00111373.0MP2 closed marvintm The validation of modules done on export.database shows errors which belong to a module in the core module 
Issue History
2011-06-10 12:00maiteNew Issue
2011-06-10 12:00maiteAssigned To => marvintm
2011-06-10 12:00maiteModules => Core
2011-06-10 12:00maiteIssue generated from0011137
2011-06-10 12:01maiteRelationship addeddepends on 0011137
2011-07-11 16:14hgbotCheckin
2011-07-11 16:14hgbotNote Added: 0038982
2011-07-11 16:14hgbotStatusnew => resolved
2011-07-11 16:14hgbotResolutionopen => fixed
2011-07-11 16:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/stable/2.50/rev/eb0bd3712933e5ef3a7b47a0420e26707d4d9aa7 [^]
2011-07-14 15:54shuehnerNote Added: 0039064
2011-07-14 15:54shuehnerStatusresolved => closed

Notes
(0038982)
hgbot   
2011-07-11 16:14   
Repository: erp/stable/2.50
Changeset: eb0bd3712933e5ef3a7b47a0420e26707d4d9aa7
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Jul 11 16:12:53 2011 +0200
URL: http://code.openbravo.com/erp/stable/2.50/rev/eb0bd3712933e5ef3a7b47a0420e26707d4d9aa7 [^]

Fixed issue 17594. Validation for foreign keys will now be correct.

---
M src/org/openbravo/service/system/DatabaseValidator.java
---
(0039064)
shuehner   
2011-07-14 15:54   
Reviewed/tested on pi/pgsql (rev: 2de13e5d42cf). Review: code-change fine restricting validation to the properties really present in the module which is being currently validated. Only lightly tested but code-change and file being changed same as in pi.