Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017586Openbravo ERP01. General setuppublic2011-06-09 23:322011-07-05 17:54
Reporterplujan 
Assigned Tomarvintm 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP1Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017586: First time you try to save a Fiscal Year, it does not get saved
DescriptionWhen creating a Fiscal Calendar, on Fiscal Year tab, if I click Save button, it does not actually do anything. Only when clicking a second time the record gets saved.

Error detected by automated test.
Steps To Reproduce1. Using QAAdmin go to Fiscal Calendar window
2. Create a new Fiscal Calendar and save
3. Create a new Fiscal Year. Save. The record is not saved. Information banner still says "New"
4. Save again. Now the record is saved.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0017587 closed alostale The first time you try to save a fiscal calendar year, nothing happens 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-06-09 23:32plujanNew Issue
2011-06-09 23:32plujanAssigned To => dalsasua
2011-06-09 23:32plujanModules => Core
2011-06-10 08:17elopioRelationship addedhas duplicate 0017587
2011-06-10 11:11plujanAssigned Todalsasua => marvintm
2011-06-10 16:02hgbotCheckin
2011-06-10 16:02hgbotNote Added: 0038251
2011-06-10 16:02hgbotStatusnew => resolved
2011-06-10 16:02hgbotResolutionopen => fixed
2011-06-10 16:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/578d1875c1b5061f8f9ec100bdf4055aaed49ca8 [^]
2011-06-10 16:22marvintmNote Added: 0038252
2011-06-10 17:16shuehnerNote Added: 0038255
2011-06-10 17:16shuehnerTarget Version3.0MP0 => 3.0MP1
2011-06-22 11:43hudsonbotCheckin
2011-06-22 11:43hudsonbotNote Added: 0038443
2011-06-22 13:01hgbotCheckin
2011-06-22 13:01hgbotNote Added: 0038479
2011-07-05 17:54shuehnerNote Added: 0038789
2011-07-05 17:54shuehnerStatusresolved => closed

Notes
(0038251)
hgbot   
2011-06-10 16:02   
Repository: erp/devel/pi
Changeset: 578d1875c1b5061f8f9ec100bdf4055aaed49ca8
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Jun 10 15:57:45 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/578d1875c1b5061f8f9ec100bdf4055aaed49ca8 [^]

Fixed issue 17586. The save action will take place correctly after the callouts are executed.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0038252)
marvintm   
2011-06-10 16:22   
Important note: a backport for mp0 is not needed, as the changeset which broke it wasn't backported to the mp0 branch.

This issue was related to the fix for the following issue:

https://issues.openbravo.com/view.php?id=16940 [^]

The changeset for it was reverted, and therefore this problem no longer happens.
(0038255)
shuehner   
2011-06-10 17:16   
Setting target version to MP1 matching explanation of marvintm in comment (38252).
(0038443)
hudsonbot   
2011-06-22 11:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/abb438586c0e [^]

Maturity status: Test
(0038479)
hgbot   
2011-06-22 13:01   
Repository: erp/devel/pi
Changeset: 3d645f1ae35c81d70537001c1944e726d9e3c2d4
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jun 22 13:00:11 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3d645f1ae35c81d70537001c1944e726d9e3c2d4 [^]

Fixed issue 16940. Validation will not be done if there is a FIC call pending.
With this change, if the user clicks on the save button while there is a FIC call in progress, the validation will not be done at that point. However, the validation will be done in the subsequent call to the saveRow() method, and therefore, it will still interrupt the save action if some field value is incorrect. This fixes the problem of the user pressing save when callouts are being executed, it still preserves the behaviour of the save action being posponed if the last changed field triggers a callout (see issue 17586), and still triggers validation in every possible save action.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0038789)
shuehner   
2011-07-05 17:54   
reviewed+test on pi/pgsql/chromium (rev id: 89b11e5682fb). Tested together with 16940. Both problems described cannot be reproduce anymore. Enabled/disabled state of toolbar buttons is now again independent of the inFicCall in progress or not. However if validations are not being done while a fic-call is in progress as the fic-result processing will only set the values which should be validated. Validation will be done on real save (if save was pressed while fic-call is being in progress as described in 16940 issue)).