Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017550Openbravo ERPA. Platformpublic2011-06-07 21:122011-06-08 17:03
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP0Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017550: Required/mandatory is not checked for selector items and not checked when saving in grid editing
DescriptionWhen tabbing through selector or comboboxed the system does not check if a field is required. This is done when saving the form and not earlier.

In grid editing the required/mandatory fields are not checked, instead a low level (not-null constraint violation) is shown in grid editing.

To reproduce, go to sales order, press new in grid and press save without setting the business partner.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-06-07 21:12mtaalNew Issue
2011-06-07 21:12mtaalAssigned To => mtaal
2011-06-07 21:12mtaalModules => Core
2011-06-07 21:25hgbotCheckin
2011-06-07 21:25hgbotNote Added: 0038159
2011-06-07 21:25hgbotStatusnew => resolved
2011-06-07 21:25hgbotResolutionopen => fixed
2011-06-07 21:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1fb4dd7c202bef6689af32eaf7ab3eefecb4b50a [^]
2011-06-08 11:53marvintmStatusresolved => closed
2011-06-08 12:02hgbotCheckin
2011-06-08 12:02hgbotNote Added: 0038166
2011-06-08 17:03hgbotCheckin
2011-06-08 17:03hgbotNote Added: 0038173

Notes
(0038159)
hgbot   
2011-06-07 21:25   
Repository: erp/devel/pi
Changeset: 1fb4dd7c202bef6689af32eaf7ab3eefecb4b50a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Jun 07 21:25:26 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1fb4dd7c202bef6689af32eaf7ab3eefecb4b50a [^]

Fixes issue 17550: Required/mandatory is not checked for selector items and not checked when saving in grid editing
Set required property on grid fields, enable validate on blur (also for selector items)

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-grid.js.ftl
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0038166)
hgbot   
2011-06-08 12:02   
Repository: erp/devel/pi
Changeset: 91b60d2f2a1a4ba0bee98e4265cd42fba6e87f3b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 08 12:01:48 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/91b60d2f2a1a4ba0bee98e4265cd42fba6e87f3b [^]

Related to issue 17550: Required/mandatory is not checked for selector items and not checked when saving in grid editing
Solves jslint error, prevents validation of filter column

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/UIDefinition.java
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0038173)
hgbot   
2011-06-08 17:03   
Repository: erp/devel/pi
Changeset: eb5d4d933b758379c55f014ad9e23783da99ee0b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jun 08 17:01:45 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/eb5d4d933b758379c55f014ad9e23783da99ee0b [^]

Fixes issue 17555: Selecting a BP in the grid causes the address field to be marked as erroneous
Related to issue 17550: Required/mandatory is not checked for selector items and not checked when saving in grid editing
Various changes to handle empty values in selector and combo box items
When a user clears a value using the keyboard then until now not FIC call was executed, this has been repaired
The clearing of the value is handled through the changed event
The clearing of the value of a selector/combo also needs to clear the identifier value, otherwise in grid editing the old identifier value is shown
When clearing a value old display values in the valuemap where lost, resulting in the db id to be shown, this has also been solved
ob-formitem-fk: make sure that the identifier value in the grid editing is also displayed
ob-formitem-list-filter: prevent validation in the filter editor
ob-formitem-list: do validation when exiting or changing a field, not necessary to do that in blur then, also execute change
ob-selector-item.js: when clearing the value call the setValueFromRecord with null, also set the grid edit values to prevent old identifier from showing
ob-view-form: undo now also restores the valuemap, before when undoing the database id was shown for combos, also validate field items which have changed during a fic call, clear errors in the grid if validation solves an error

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-fk.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list-filter.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-list.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---