Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0017537 | Openbravo ERP | 00. Application dictionary | public | 2011-06-07 12:12 | 2012-04-23 12:18 |
|
| Reporter | pandeeswari | |
| Assigned To | guilleaer | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 20 | OS Version | Community Appliance |
| Product Version | 3.0RC7 | |
| Target Version | 3.0MP10 | Fixed in Version | 3.0MP11 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0017537: Remove Deletable Records Option is not working in RC7 new UI |
| Description | I unchecked deletable records check box in Tables and Columns for c_bpartner table. I compiled using smartbuild and deployed. When I opened the Business Partner window in new UI, delete button is still visible and working. In classic UI it is invisible. |
| Steps To Reproduce | 1. Uncheck deletable records check box in Tables and Columns for any table, I tried in c_bpartner table.
2. Compile and deploy.(I tried both smartbuild and compile.complete.deploy)
3. Open the corresponding window in new UI, delete button will be still visible and working. In classic UI it will be invisible. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  BusinessPartnerNewUI.png (55,435) 2011-06-07 12:12
https://issues.openbravo.com/file_download.php?file_id=4166&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2011-06-07 12:12 | pandeeswari | New Issue | |
| 2011-06-07 12:12 | pandeeswari | Assigned To | => alostale |
| 2011-06-07 12:12 | pandeeswari | File Added: BusinessPartnerNewUI.png | |
| 2011-06-07 12:12 | pandeeswari | Modules | => Core |
| 2011-06-09 11:23 | pandeeswari | Issue Monitored: pandeeswari | |
| 2011-08-05 13:00 | alostale | Status | new => scheduled |
| 2011-08-05 13:00 | alostale | fix_in_branch | => pi |
| 2011-12-01 05:31 | shankarb | Assigned To | alostale => shankarb |
| 2011-12-01 05:31 | shankarb | fix_in_branch | pi => |
| 2012-03-21 17:55 | szapata | Note Added: 0046611 | |
| 2012-03-21 17:59 | szapata | Issue Monitored: szapata | |
| 2012-03-22 14:35 | VictorVillar | Resolution time | => 1335564000 |
| 2012-03-22 14:35 | VictorVillar | Priority | normal => urgent |
| 2012-03-22 14:35 | VictorVillar | Severity | trivial => major |
| 2012-03-22 14:35 | VictorVillar | Target Version | => 3.0MP10 |
| 2012-03-22 14:43 | VictorVillar | Assigned To | shankarb => jonalegriaesarte |
| 2012-03-22 14:43 | VictorVillar | Issue Monitored: networkb | |
| 2012-03-22 15:43 | VictorVillar | Assigned To | jonalegriaesarte => alostale |
| 2012-03-23 08:52 | alostale | Assigned To | alostale => guilleaer |
| 2012-03-23 08:52 | alostale | Assigned To | guilleaer => migueldejuana |
| 2012-03-26 13:20 | alostale | Assigned To | migueldejuana => guilleaer |
| 2012-03-28 13:32 | hgbot | Checkin | |
| 2012-03-28 13:32 | hgbot | Note Added: 0046829 | |
| 2012-03-28 13:32 | hgbot | Status | scheduled => resolved |
| 2012-03-28 13:32 | hgbot | Resolution | open => fixed |
| 2012-03-28 13:32 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/14aebcd3205248ced2227e79412430793fcad22d [^] |
| 2012-03-28 17:31 | guilleaer | Note Added: 0046850 | |
| 2012-03-30 12:17 | marvintm | Status | resolved => closed |
| 2012-03-30 12:17 | marvintm | Fixed in Version | => 3.0MP10 |
| 2012-04-02 06:12 | hudsonbot | Checkin | |
| 2012-04-02 06:12 | hudsonbot | Note Added: 0047259 | |
| 2012-04-16 18:10 | szapata | Note Added: 0047597 | |
| 2012-04-16 18:10 | szapata | Status | closed => new |
| 2012-04-16 18:10 | szapata | Resolution | fixed => open |
| 2012-04-16 18:10 | szapata | Fixed in Version | 3.0MP10 => |
| 2012-04-17 18:10 | guilleaer | Status | new => scheduled |
| 2012-04-17 18:10 | guilleaer | fix_in_branch | => pi |
| 2012-04-17 18:11 | guilleaer | Note Added: 0047679 | |
| 2012-04-17 18:11 | guilleaer | Status | scheduled => resolved |
| 2012-04-17 18:11 | guilleaer | Fixed in Version | => 3.0MP11 |
| 2012-04-17 18:11 | guilleaer | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/14aebcd3205248ced2227e79412430793fcad22d [^] => 98819a044ef6377b84f4cb74a291fd377b31607f |
| 2012-04-17 18:11 | guilleaer | Resolution | open => fixed |
| 2012-04-17 18:13 | guilleaer | Note Added: 0047680 | |
| 2012-04-23 12:18 | AugustoMauch | Note Added: 0047874 | |
| 2012-04-23 12:18 | AugustoMauch | Status | resolved => closed |
|
Notes |
|
|
(0046611)
|
|
szapata
|
|
2012-03-21 17:55
|
|
|
And even more, if you press the visible button you can delete records. |
|
|
|
(0046829)
|
|
hgbot
|
|
2012-03-28 13:32
|
|
Repository: erp/devel/pi
Changeset: 14aebcd3205248ced2227e79412430793fcad22d
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Mar 28 13:21:37 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/14aebcd3205248ced2227e79412430793fcad22d [^]
Fixed issue 17537: records of undeleatable tables cant be deleted
---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/templates/ob-view-tab.js.ftl
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewTab.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
|
|
|
|
|
Test plan:
1. Logged as system administrator, set one table E.g c_bpartner as no deleteable using the tables and columns window.
2. Change you role to F&B international group admin
3. Open the Business partners window
4. Try to delete one row using the toolbar or the context menu or the shortcut (ctrl+supr). It shouldn't be possible
This fix is not risky |
|
|
|
|
|
|
|
(0047597)
|
|
szapata
|
|
2012-04-16 18:10
|
|
If you try deleting with the Supr. key you can delete a record. So I think the issue is not fixed.
On the other hand, I think that this functionality should be set at Tab level instead of table level. Is very common to have several tabs pointing the same table and it would be interesting to have the flexibility o add records but not delete in some tabs and allow create and delete from other tabs. So, the approach would be to create a few new UI Patterns:
- Create Only
- Delete Only
- Edit and delete Only
Best Regards. |
|
|
|
|
Repository: erp/devel/pi
Changeset: 98819a044ef6377b84f4cb74a291fd377b31607f
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Apr 17 18:01:26 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/98819a044ef6377b84f4cb74a291fd377b31607f [^] [^]
Fixed issue 15537: records of undeleatable tables cant be deleted using supr shortcut.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
--- |
|
|
|
|
Test plan:
Repeat the steps to reproduce and try to delete the line using SUPR.
This fix is not risky |
|
|
|
|
|
Code reviewed and verified in pi@4c5f3e0c2556. |
|