Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017441Openbravo ERPA. Platformpublic2011-05-31 17:452012-04-02 06:11
Reportershuehner 
Assigned Toguilleaer 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP10 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017441: 'No data in grid. Create One' still shown when tab is writable in general but current user/role has only readonly access
DescriptionIssue 17254 fixed the case in which the tab is marked as SR or RO in AD. But does not yet take into account the access of current role to the tab as that info is processed later then needed (only in setWindowSettings) which is too late for the following two uses:
- context menu shown in empty grid
- 'Create one' versus just no data in grid on empty grid
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0017440 closed guilleaer Recent list shows '*' to create new for Tabs which have UIpattern 'read only' or 'single record' 
related to defect 00168413.0MP0 closed shuehner It is possible to click New in Audit Trail 
related to design defect 0020057 acknowledged Triage Platform Base When the menu is being generated, the code doesn't check the defined windows access rights for the role of the current user. 
related to defect 00287613.0PR15Q2 closed inigosanchez Navigate to read only logic tab does not work an empty tab is displayed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-05-31 17:45shuehnerNew Issue
2011-05-31 17:45shuehnerAssigned To => alostale
2011-05-31 17:45shuehnerModules => Core
2011-05-31 17:51shuehnerRelationship addedrelated to 0016841
2011-05-31 18:14shuehnerNote Added: 0037841
2011-06-02 07:09thirumalaikIssue Monitored: thirumalaik
2011-08-05 10:09alostaleRelationship addedrelated to 0017440
2011-08-05 10:10alostaleStatusnew => scheduled
2011-08-05 10:10alostaleAssigned Toalostale => thirumalaik
2011-08-05 10:10alostalefix_in_branch => pi
2012-03-14 16:41alostaleAssigned Tothirumalaik => guilleaer
2012-03-20 11:26guilleaerRelationship addedrelated to 0020057
2012-03-20 18:23hgbotCheckin
2012-03-20 18:23hgbotNote Added: 0046573
2012-03-20 18:23hgbotStatusscheduled => resolved
2012-03-20 18:23hgbotResolutionopen => fixed
2012-03-20 18:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bc316c32fa2b4f182b4c296a21ac8269476e31c1 [^]
2012-03-21 09:05guilleaerNote Added: 0046576
2012-03-21 11:58hgbotCheckin
2012-03-21 11:58hgbotNote Added: 0046586
2012-03-23 14:57alostaleNote Added: 0046697
2012-03-23 14:57alostaleStatusresolved => closed
2012-03-23 14:57alostaleFixed in Version => 3.0MP10
2012-04-02 06:11hudsonbotCheckin
2012-04-02 06:11hudsonbotNote Added: 0047177
2012-04-02 06:11hudsonbotCheckin
2012-04-02 06:11hudsonbotNote Added: 0047184
2015-02-19 10:07inigosanchezRelationship addedrelated to 0028761

Notes
(0037841)
shuehner   
2011-05-31 18:14   
Note one idea is to perhaps add writable flag to OB.Accessibleentities (from application-dynamic.js) which is already loaded. That way the info could be reused also to fix 17440.
(0046573)
hgbot   
2012-03-20 18:23   
Repository: erp/devel/pi
Changeset: bc316c32fa2b4f182b4c296a21ac8269476e31c1
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Mar 20 18:22:28 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/bc316c32fa2b4f182b4c296a21ac8269476e31c1 [^]

Fixed issue 17441: 'Create one' is not shown when the user role has readonly access

When user try to use one window which has been defined as readonly using the role windows access rights, the 'create one' message is not shown. Also, the right click of the mouse has been disabled to avoid the creation of new lines.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0046576)
guilleaer   
2012-03-21 09:05   
Test plan:
1. Logged as F&B International Group Admin - F&B International Group
2. Go to role window and set one window as Non editable for a specific role. E.g (Return to vendor)
3. Using this role, go to the window
4. If data doesn't exists, yo should see the message without the text "create one" (probably you will need to remove the filter before the message is shown) and the right click of the mouse should be disabled.
5. Using another window with data and defined as Non Editable (E.g. Role) you should be able to use the right click in cells without the 'new line' options


This fix is not risky
(0046586)
hgbot   
2012-03-21 11:58   
Repository: erp/devel/pi
Changeset: 60a3b45a21d4891259504c2e2d3be331d0910893
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Mar 21 11:57:13 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/60a3b45a21d4891259504c2e2d3be331d0910893 [^]

Related to issue 17441: Preventing a wrong disabling of context menu in editable grids

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0046697)
alostale   
2012-03-23 14:57   
core reviewed and verified on pi@5acb2f2f3505
(0047177)
hudsonbot   
2012-04-02 06:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047184)
hudsonbot   
2012-04-02 06:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test