Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0017397Openbravo ERPA. Platformpublic2011-05-27 11:242011-06-01 12:06
rgoris 
mtaal 
urgentmajorhave not tried
closedfixed 
5
 
3.0MP0 
Core
No
0017397: Grid Editing: cannot cancel editing of rows
Edit mode in rows cannot be canceled. See video.
No tags attached.
? GridEditIssue.mp4 (1,292,972) 2011-05-27 11:24
https://issues.openbravo.com/file_download.php?file_id=4118&type=bug
png Capture.PNG (55,804) 2011-06-01 09:47
https://issues.openbravo.com/file_download.php?file_id=4142&type=bug
png
Issue History
2011-05-27 11:24rgorisNew Issue
2011-05-27 11:24rgorisAssigned To => alostale
2011-05-27 11:24rgorisFile Added: GridEditIssue.mp4
2011-05-27 11:24rgorisModules => Core
2011-05-27 11:25rgorisAssigned Toalostale => mtaal
2011-05-27 11:25rgorisTarget Version => 3.0MP0
2011-05-30 11:15rgorisStatusnew => scheduled
2011-05-30 11:15rgorisNote Added: 0037692
2011-05-30 11:15rgorisfix_in_branch => pi
2011-05-30 11:45dmitry_mezentsevNote Added: 0037704
2011-05-30 13:10mtaalNote Added: 0037721
2011-05-31 08:45hgbotCheckin
2011-05-31 08:45hgbotNote Added: 0037762
2011-05-31 08:45hgbotStatusscheduled => resolved
2011-05-31 08:45hgbotResolutionopen => fixed
2011-05-31 08:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/696fc38dd3e9471df130c956f18b820433062741 [^]
2011-05-31 21:36hudsonbotCheckin
2011-05-31 21:36hudsonbotNote Added: 0037851
2011-06-01 09:47rgorisFile Added: Capture.PNG
2011-06-01 09:49rgorisNote Added: 0037866
2011-06-01 09:49rgorisStatusresolved => new
2011-06-01 09:49rgorisResolutionfixed => open
2011-06-01 09:49rgorisStatusnew => scheduled
2011-06-01 10:08mtaalNote Added: 0037868
2011-06-01 10:08mtaalStatusscheduled => resolved
2011-06-01 10:08mtaalResolutionopen => fixed
2011-06-01 12:06rgorisStatusresolved => closed

Notes
(0037692)
rgoris   
2011-05-30 11:15   
Still persists as of today.
(0037704)
dmitry_mezentsev   
2011-05-30 11:45   
I also saw it (in Purchase Invoice, Sales Invoice). The thing is that pressing Edit on next row does not actually puts it into the edit mode (no fields are selected to be edited).

At the same time for example in the Sales Order window I cannot reproduce it, it works correctly.

Interesting thing here is that, for example, for Purchase Order from the videos Edit Button should not appear at all because it is already processed and all the fields are read-only (if you switch to the Form view - you cannot edit document).
(0037721)
mtaal   
2011-05-30 13:10   
I think that's also what goes 'wrong' here. The row is in edit mode but you can't edit any of the fields. So therefore it gives this impression. Maybe the solution is to give a warning if none of the form fields are editable and then go back to non-edit state.

The 'problem' is that we don't know if the fields are editable until we actually open/start the form. So therefore the edit button is shown. It is a feature request for MP1 to support non-editable taking into account the state of the object.

The video shows also a real error (that's what the issue is for), that you can have multiple rows in edit mode and cancel does not work.
(0037762)
hgbot   
2011-05-31 08:45   
Repository: erp/devel/pi
Changeset: 696fc38dd3e9471df130c956f18b820433062741
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue May 31 08:44:52 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/696fc38dd3e9471df130c956f18b820433062741 [^]

Fixes issue 17397: Grid Editing: cannot cancel editing of rows

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0037851)
hudsonbot   
2011-05-31 21:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b7e7d64488f5 [^]

Maturity status: Test
(0037866)
rgoris   
2011-06-01 09:49   
Problem persists in today´s live build. It was pushed last night so it should have been visible by now. Please check, i also added another screenshot.
(0037868)
mtaal   
2011-06-01 10:08   
live build is from 30th of may so does not contain the solution:
http://builds.openbravo.com/job/int-full-pgsql/2074/ [^]