Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017378Openbravo ERPA. Platformpublic2011-05-26 14:142011-06-02 10:27
Reporterpsarobe 
Assigned Toiperdomo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP0Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017378: Refresh button must be disabled when editing a record either in the grid or in the form
DescriptionRight now when you are editing (or new) the grid or the form the button Refresh button is enabled and when pressing it the behaviour is not correct. It tries to save the record, etc

We have decided to disable when editing a record since it makes no sense to refresh the data
Steps To Reproduce1. Go to Product window
2. Edit a product in grid view. Button Refresh should be disabled
3. Edit a product in form view. Button Refresh should be disabled
4. Click new in form view. Button Refresh should be disabled
5. Click new in grid view. Button Refresh should be disabled
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-05-26 14:14psarobeNew Issue
2011-05-26 14:14psarobeAssigned To => iperdomo
2011-05-26 14:14psarobeModules => Core
2011-05-26 18:16iperdomoStatusnew => scheduled
2011-05-26 18:16iperdomofix_in_branch => pi
2011-05-27 18:46hgbotCheckin
2011-05-27 18:46hgbotNote Added: 0037680
2011-05-27 18:46hgbotStatusscheduled => resolved
2011-05-27 18:46hgbotResolutionopen => fixed
2011-05-27 18:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e99d7f19209a184a080bfa516d6c3dc46420241e [^]
2011-05-31 09:44hudsonbotCheckin
2011-05-31 09:44hudsonbotNote Added: 0037790
2011-06-02 10:27marvintmNote Added: 0037905
2011-06-02 10:27marvintmStatusresolved => closed

Notes
(0037680)
hgbot   
2011-05-27 18:46   
Repository: erp/devel/pi
Changeset: e99d7f19209a184a080bfa516d6c3dc46420241e
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Fri May 27 18:45:40 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e99d7f19209a184a080bfa516d6c3dc46420241e [^]

Fixes issue 17378: Disable reload button when editing and in new state

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0037790)
hudsonbot   
2011-05-31 09:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ea275e03a164 [^]

Maturity status: Test
(0037905)
marvintm   
2011-06-02 10:27   
The fix is correct, although it's not exactly done as what the issue proposed. The important thing is that the refresh button will not be active if its action would trigger autosave. Therefore:

- When creating a new record (in form or grid view) the button is disabled.
- When editing an existing record (in form or grid view), the button is enabled if the user hasn't done any change (because refreshing would be harmless in this case). If the user does any change, the button is disabled (because clicking it in this case would trigger autosave).