Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017133Openbravo ERPA. Platformpublic2011-05-12 10:412011-11-02 13:01
Reportermtaal 
Assigned Tomtaal 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP5Fixed in Version3.0MP5 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017133: There are cases where the grid columns do not take the complete size of the window
DescriptionSee the attached screenshot. The current logic only selects string or foreign key fields are potential autoexpand canditates, but there are several tabs where there is no string or foreign key field. In that case a different approach needs to be followed.
Even nicer, instead of expanding one field is to expand all columns to fill the horizontal space.
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00170553.0MP2 closed mtaal Different auto-width settings for yes/no columns in a grid 
Attached Filespng 598834.png (66,405) 2011-05-12 10:41
https://issues.openbravo.com/file_download.php?file_id=3982&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-05-12 10:41mtaalNew Issue
2011-05-12 10:41mtaalAssigned To => mtaal
2011-05-12 10:41mtaalFile Added: 598834.png
2011-05-12 10:41mtaalModules => Core
2011-05-16 08:57alostaleStatusnew => scheduled
2011-05-23 13:25mtaalTarget Version3.0MP0 => 3.0MP1
2011-06-22 19:57dmitry_mezentsevTarget Version3.0MP1 => 3.0MP2
2011-07-19 17:03hgbotCheckin
2011-07-19 17:03hgbotNote Added: 0039242
2011-07-19 17:03hgbotStatusscheduled => resolved
2011-07-19 17:03hgbotResolutionopen => fixed
2011-07-19 17:03hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a55fbb9b468e655fc105f7d5c4197445e521d9d6 [^]
2011-08-01 14:20hudsonbotCheckin
2011-08-01 14:20hudsonbotNote Added: 0039633
2011-08-02 15:50marvintmNote Added: 0039783
2011-08-02 15:50marvintmStatusresolved => new
2011-08-02 15:50marvintmResolutionfixed => open
2011-08-02 15:58marvintmNote Added: 0039784
2011-08-03 11:46psarobePrioritynormal => urgent
2011-08-03 11:46psarobeStatusnew => scheduled
2011-08-03 11:46psarobeTarget Version3.0MP2 => 3.0MP3
2011-08-08 11:10mtaalRelationship addedrelated to 0017055
2011-08-31 09:42mtaalTarget Version3.0MP3 => 3.0MP4
2011-09-11 02:19hgbotCheckin
2011-09-11 02:19hgbotNote Added: 0040871
2011-09-18 12:48mtaalTarget Version3.0MP4 => 3.0MP5
2011-10-12 01:57hudsonbotCheckin
2011-10-12 01:57hudsonbotNote Added: 0041629
2011-10-27 06:40mtaalNote Added: 0042128
2011-10-27 06:40mtaalStatusscheduled => resolved
2011-10-27 06:40mtaalFixed in Version => 3.0MP5
2011-10-27 06:40mtaalResolutionopen => fixed
2011-11-02 13:01marvintmStatusresolved => closed

Notes
(0039242)
hgbot   
2011-07-19 17:03   
Repository: erp/devel/pi
Changeset: a55fbb9b468e655fc105f7d5c4197445e521d9d6
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Jul 19 17:02:55 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a55fbb9b468e655fc105f7d5c4197445e521d9d6 [^]

Fixes issue 17133: There are cases where the grid columns do not take the complete size of the window
If there is no autoexpand field visible then divide the space among all fields

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0039633)
hudsonbot   
2011-08-01 14:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cf2afed6e8ef [^]

Maturity status: Test
(0039783)
marvintm   
2011-08-02 15:50   
I've been able to reproduce the issue by hiding all the fields in the Sales Order Lines tab, except:

- Line no
- Order date
- Invoice date

Dates and numbers seem not to be expanded. Only if I add a string or fk column it is autoexpanded. I understand that this was meant to be changed...
(0039784)
marvintm   
2011-08-02 15:58   
One thing I've later noticed is that if you close the window and open it again, the fields are expanded so that they fill all the available space. So it seems that the only problem is that the header needs to be "refreshed" after the user shows or hides a column.
(0040871)
hgbot   
2011-09-11 02:19   
Repository: erp/devel/pi
Changeset: e3c3258bdf45268f876230eb5ff8efb0770de0bf
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Sep 09 19:41:25 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e3c3258bdf45268f876230eb5ff8efb0770de0bf [^]

Related to issue 17133: There are cases where the grid columns do not take the complete size of the window

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-grid-styles.js
---
(0041629)
hudsonbot   
2011-10-12 01:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9bd2b5c2d982 [^]

Maturity status: Test
(0042128)
mtaal   
2011-10-27 06:40   
Hi Antonio,
I retested this issue and you are right, the date column does not get auto resized while hiding columns, and if the window gets re-opened it correctly resizes.

But in my opinion the remaining topic (that the date column does not automatically resize while hiding all other columns) is soo small that it can be neglected. Especially because when re-opening the window it is corrected.

Therefore resolving the issue, let me know if you don't agree then we can discuss.

gr. Martin