Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0017003Openbravo ERP04. Warehouse managementpublic2011-05-04 15:022011-06-13 10:45
Reporteradrianromero 
Assigned Todalsasua 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionpiFixed in Version3.0MP0 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0017003: M_INOUT_CREATE, Products are not taken in the correct order. Movements between bins modifies the FIFO order.
DescriptionSelection of products for Shipments is based in the CREATED field of the M_STORAGE_DETAIL as done in the related issue 15796. This is not the correct order in all cases because movements between bins modifies the order the product is took.

A best option instead of the CREATED field of the table M_STORAGE_DETAIL is the CREATED field of the table M_ATTRIBUTESETINSTANCE because this record is created when goods are created and are not modified when goods are moved from one bin to another...

Steps To ReproduceCreate a new product, stocked and with an attributeset that has lot and with a price.

Create and complete an Income Shipment with the following details:
Org: F&B España - Región Norte
Warehouse: España Región Norte
Product: The new created product.
Lot: 0
Bin: RN-1-0-0
Movement Quantity: 100

Create and complete another Income Shipment with the following details:
Org: F&B España - Región Norte
Warehouse: España Región Norte
Product: The new created product.
Lot: 1
Bin: RN-2-0-0
Movement Quantity: 100

After this verify that the stock for the new created product is:
Lot #0 RN-1-0-0 100 units
Lot #1 RN-2-0-0 100 units

Create and complete a goods movement with the following details:
Org: F&B España - Región Norte
Product: The new created product.
Lot: 0
Bin: RN-1-0-0
Movement Quantity: 100
New Storage Bin: RN-0-0-0

After this verify that the stock for the new created product is:
Lot #0 RN-0-0-0 100 units
Lot #1 RN-2-0-0 100 units

Create a sales order with the following details:
Org: F&B España - Región Norte
Product: The new created product.
Quantity: 100

Go to Sales Management || Transactions || Create Shipments from Orders
Select the order created and process.

Now you can see the stock is:
Lot #0 RN-0-0-0 100 units
Lot #1 RN-2-0-0 99 units

It has been taken first the second lot of goods instead of the first becouse of the movement. The right option to follow a FIFO approach is to take the the first lot of goods.
Proposed SolutionAs explained in the description to use the CREATED field of the table M_ATTRIBUTESETINSTANCE

When fixing this issue verify also that issue 15796 still works properly.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0015796 closed adrianromero M_INOUT_CREATE - Products are taken in random order for Goods Shipment etc. 
related to feature request 0003428pi closed dmiguelez LIFO and FIFO costing 
depends on backport 0017004pi closed adrianromero M_INOUT_CREATE, Products are not taken in the correct order. Movements between bins modifies the FIFO order. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-05-04 15:02adrianromeroNew Issue
2011-05-04 15:02adrianromeroAssigned To => adrianromero
2011-05-04 15:02adrianromeroModules => Core
2011-05-04 15:03adrianromeroRelationship addedrelated to 0015796
2011-05-04 15:04adrianromeroStatusnew => scheduled
2011-05-04 15:04adrianromerofix_in_branch => pi
2011-05-04 18:14hgbotCheckin
2011-05-04 18:14hgbotNote Added: 0036367
2011-05-04 18:14hgbotStatusscheduled => resolved
2011-05-04 18:14hgbotResolutionopen => fixed
2011-05-04 18:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/8bc0a5ac9d5ecd170f4ff6528c6cb9d0b5ee17f1 [^]
2011-05-04 18:31adrianromeroNote Added: 0036370
2011-05-04 18:43adrianromeroRelationship addedrelated to 0003428
2011-05-12 13:29hudsonbotCheckin
2011-05-12 13:29hudsonbotNote Added: 0036816
2011-06-03 10:57dalsasuaAssigned Toadrianromero => dalsasua
2011-06-13 10:45jonalegriaesarteNote Added: 0038282
2011-06-13 10:45jonalegriaesarteStatusresolved => closed
2011-06-13 10:45jonalegriaesarteFixed in Version => 3.0MP0

Notes
(0036367)
hgbot   
2011-05-04 18:14   
Repository: erp/devel/pi
Changeset: 8bc0a5ac9d5ecd170f4ff6528c6cb9d0b5ee17f1
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed May 04 17:37:20 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8bc0a5ac9d5ecd170f4ff6528c6cb9d0b5ee17f1 [^]

Fixes issue 0017003: M_INOUT_CREATE, Products are not taken in the correct order. Movements between bins modifies the FIFO order.
It has been modified the sentence that gets the bin to priorityze by the CREATED field of the M_ATTRIBUTESETINSTANCE table

---
M src-db/database/model/functions/M_INOUT_CREATE.xml
M src-db/database/model/functions/M_PRODUCTION_RUN.xml
---
(0036370)
adrianromero   
2011-05-04 18:31   
The solution implemented uses the created field of the attribute set instance table to establish priorities of bin used. With this solution products with instantiables attributes will work using the date wne the attribute has been created. It has to be taken into account that it will not be used the date of the shipment nor any other date.


* Testing the issue

Kindly follow the steps to test and verify no that at the end the stock is:

Lot #0 RN-0-0-0 99 units
Lot #1 RN-2-0-0 100 units

So independently of the movement of bin of the Lot #0 of goods it has been selected this because its attribute set instance has been created.

Verify also that the case described in issue 15796 continues working properly

Verify also that in BOM productions the order of products taken is the same as in M_INOUT_CREATE. To test this create a new product for BOM production that has in his list the created product, and verify that when executing a BOM production the product used is also the same as in the shipments creation, the Lot #0

* Other areas affected.

No other areas affected appart from the window Create Shipment from Orders and Bill of Material Production
(0036816)
hudsonbot   
2011-05-12 13:29   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c40e579fcd38 [^]

Maturity status: Test
(0038282)
jonalegriaesarte   
2011-06-13 10:45   
Verified