Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016947Openbravo ERPA. Platformpublic2011-04-29 15:162011-05-31 09:44
Reporterrgoris 
Assigned Tomtaal 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP0Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016947: OPTIMIZE-15: Splitter bar does not work in all states
DescriptionThe horizontal splitter bar between parent and child levels can normally be dragged up and down. However in some cases this is not possible:

Situation 1: Splitter bar is filled entirely with tabs. Now it´s tricky to grab the bar without accidentally activating another tab.
Situation 2: Child level is maximized. Now, the user´s natural reaction is to drag the bar down in order to view the header level again. This is not possible. I have observed users doing it (i.e. Paolo in his demo for Bob)and consider this is a severe usability issue.
Steps To Reproduce(1) Open as many tabs as needed to fill the entire splitter bar. Now try to move the bar up or down.
(2) Maximize a child level so that the parent is collapsed. Now try to drag (or click) the splitter bar to pull it down.
Proposed Solution(1) Allow the user to grab the splitter bar at the green horizontal line. A "double arrow" mouse cursor should appear when hovering over it.
(2) Single click (on release) on the splitter bar (gray area or horizontal green line) when in expanded state should expand the collapsed level.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00173453.0MP0 closed mtaal Third level tabs are not shown when selected 
related to defect 0020226 closed rgoris Windows with three levels: Financial account. First tab expands when it shouldn't 
Attached Filespng grab1.png (92,916) 2011-04-29 15:16
https://issues.openbravo.com/file_download.php?file_id=3916&type=bug
png

png grab2.png (43,724) 2011-04-29 15:16
https://issues.openbravo.com/file_download.php?file_id=3917&type=bug
png

? capture-3.mp4 (631,708) 2011-05-25 10:49
https://issues.openbravo.com/file_download.php?file_id=4099&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-04-29 15:16rgorisNew Issue
2011-04-29 15:16rgorisAssigned To => alostale
2011-04-29 15:16rgorisFile Added: grab1.png
2011-04-29 15:16rgorisModules => Core
2011-04-29 15:16rgorisTarget Version => 3.0RC7
2011-04-29 15:16rgorisFile Added: grab2.png
2011-05-02 10:36alostaleStatusnew => scheduled
2011-05-02 10:36alostaleAssigned Toalostale => iperdomo
2011-05-02 10:36alostalefix_in_branch => pi
2011-05-06 19:30dmitry_mezentsevAssigned Toiperdomo => mtaal
2011-05-06 19:32dmitry_mezentsevNote Added: 0036535
2011-05-09 20:49iciordiaTarget Version3.0RC7 => 3.0MP0
2011-05-09 20:49iciordiafix_in_branchpi =>
2011-05-17 09:15iperdomoPriorityurgent => normal
2011-05-17 09:16iperdomoPrioritynormal => urgent
2011-05-24 19:08hgbotCheckin
2011-05-24 19:08hgbotNote Added: 0037406
2011-05-24 19:08hgbotStatusscheduled => resolved
2011-05-24 19:08hgbotResolutionopen => fixed
2011-05-24 19:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7f3e03aa0b1cd20e226c330baf18286503ecf20d [^]
2011-05-25 10:38alostaleRelationship addedrelated to 0017345
2011-05-25 10:49rgorisFile Added: capture-3.mp4
2011-05-25 10:49rgorisNote Added: 0037413
2011-05-25 10:50rgorisStatusresolved => new
2011-05-25 10:50rgorisResolutionfixed => open
2011-05-25 10:50rgorisStatusnew => scheduled
2011-05-25 10:50rgorisfix_in_branch => pi
2011-05-25 12:09hgbotCheckin
2011-05-25 12:09hgbotNote Added: 0037416
2011-05-25 12:09hgbotStatusscheduled => resolved
2011-05-25 12:09hgbotResolutionopen => fixed
2011-05-25 12:09hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/7f3e03aa0b1cd20e226c330baf18286503ecf20d [^] => http://code.openbravo.com/erp/devel/pi/rev/0f8274676fcfc6120e551ca337b866fc0c19f04a [^]
2011-05-26 07:46hudsonbotCheckin
2011-05-26 07:46hudsonbotNote Added: 0037549
2011-05-26 07:46hudsonbotCheckin
2011-05-26 07:46hudsonbotNote Added: 0037551
2011-05-26 11:52rgorisNote Added: 0037590
2011-05-26 11:52rgorisStatusresolved => new
2011-05-26 11:52rgorisResolutionfixed => open
2011-05-26 14:25hgbotCheckin
2011-05-26 14:25hgbotNote Added: 0037600
2011-05-26 14:25hgbotStatusnew => resolved
2011-05-26 14:25hgbotResolutionopen => fixed
2011-05-26 14:25hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/0f8274676fcfc6120e551ca337b866fc0c19f04a [^] => http://code.openbravo.com/erp/devel/pi/rev/39c8f7954afa98c751d543d71565ec5ee775c58b [^]
2011-05-27 10:24rgorisStatusresolved => closed
2011-05-31 09:44hudsonbotCheckin
2011-05-31 09:44hudsonbotNote Added: 0037768
2012-04-27 09:49migueldejuanaRelationship addedrelated to 0020226

Notes
(0036535)
dmitry_mezentsev   
2011-05-06 19:32   
Rob, Martin,

The proposal after review of all the issues is to fix 2nd point in this issue for RC7 (as it is really annoying) and 1st one - leave it for MP0.
(0037406)
hgbot   
2011-05-24 19:08   
Repository: erp/devel/pi
Changeset: 7f3e03aa0b1cd20e226c330baf18286503ecf20d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue May 24 19:07:34 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7f3e03aa0b1cd20e226c330baf18286503ecf20d [^]

Fixes issue 16947: OPTIMIZE-15: Splitter bar does not work in all states

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-tab.js
---
(0037413)
rgoris   
2011-05-25 10:49   
Works great but there is still a little glitch, see video attached.
(0037416)
hgbot   
2011-05-25 12:09   
Repository: erp/devel/pi
Changeset: 0f8274676fcfc6120e551ca337b866fc0c19f04a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed May 25 12:06:44 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0f8274676fcfc6120e551ca337b866fc0c19f04a [^]

Fixes issue 16947: OPTIMIZE-15: Splitter bar does not work in all states, Fixes issue 17345: Third level tabs are not shown when selected

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/ob-tab.js
M src/index.jsp
---
(0037549)
hudsonbot   
2011-05-26 07:46   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/728387046be6 [^]

Maturity status: Test
(0037551)
hudsonbot   
2011-05-26 07:46   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/728387046be6 [^]

Maturity status: Test
(0037590)
rgoris   
2011-05-26 11:52   
Almost there. There is one part that does not behave ideally:

Grand child tab is maximized (e.g. Line Tax in a sales order)
Click on lines tab -> expands (good)
Now click on lines tab again -> maximizes (pushes the Line Tax tab to the bottom). This last step should move the Lines tab to the middle instead, so it behaves the same at all times.

Only a double click should maximize a level.
Perhaps the solution is to remove the memory of previous state. So summarizing behavior will be as follows.
- Single click on a tab when the level above it is collapsed: expand the collapsed level
- Single click on a tab when it is collapsed: expand it
- Single click on a tab when it is collapsed and also the level above it is collapsed: expand its own level. Now another single click would also expand the level above.
(0037600)
hgbot   
2011-05-26 14:25   
Repository: erp/devel/pi
Changeset: 39c8f7954afa98c751d543d71565ec5ee775c58b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu May 26 14:24:50 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/39c8f7954afa98c751d543d71565ec5ee775c58b [^]

Fixes issue 16947: OPTIMIZE-15: Splitter bar does not work in all states

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-tab.js
---
(0037768)
hudsonbot   
2011-05-31 09:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ea275e03a164 [^]

Maturity status: Test