Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016940Openbravo ERPA. Platformpublic2011-04-29 12:002011-07-05 17:54
Reporterelopio 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP1Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016940: It is possible to click the save button while callouts are loading data
DescriptionIt is possible to click the save button while callouts are loading data. If that data is required for the record, an error will appear:

Error
One or more fields contain illegal values, check the errors for each field.

And this is confusing, because when you check what fields you missed, all of them are already filled.
Steps To ReproduceLog in with Openbravo user.
Switch to QA Testing role.
Go to Sales Management > Transactions > Sales Order
Click the new in form button
Open the business partner selector pop up.
Quickly, select Creditor and immediately click the save button.
Proposed SolutionI think that the best solution would be that, if the save button is clicked while data is being loaded, it will wait for all the data to arrive and then save the record.

Alternatively, while data is being loaded the save button could be disabled. The advantage with this approach is that you are not allowed to save data that you haven't seen and might be erroneus.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Ekrankopio.png (52,258) 2011-04-29 12:00
https://issues.openbravo.com/file_download.php?file_id=3914&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-04-29 12:00elopioNew Issue
2011-04-29 12:00elopioAssigned To => alostale
2011-04-29 12:00elopioFile Added: Ekrankopio.png
2011-04-29 12:00elopioModules => Core
2011-05-02 10:58alostaleTarget Version => 3.0RC7
2011-05-02 10:59alostaleStatusnew => scheduled
2011-05-02 10:59alostaleAssigned Toalostale => marvintm
2011-05-02 10:59alostalefix_in_branch => pi
2011-05-05 17:33dmitry_mezentsevNote Added: 0036408
2011-05-05 17:33dmitry_mezentsevTarget Version3.0RC7 => 3.0MP0
2011-05-05 17:33dmitry_mezentsevfix_in_branchpi =>
2011-05-23 16:41plujanTarget Version3.0MP0 => 3.0MP1
2011-06-09 12:40hgbotCheckin
2011-06-09 12:40hgbotNote Added: 0038193
2011-06-09 12:40hgbotStatusscheduled => resolved
2011-06-09 12:40hgbotResolutionopen => fixed
2011-06-09 12:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1419d0a02aafd18cd1381c3da1af9eca46976fb5 [^]
2011-06-10 10:04hgbotCheckin
2011-06-10 10:04hgbotNote Added: 0038213
2011-06-10 16:00marvintmNote Added: 0038250
2011-06-10 16:00marvintmStatusresolved => new
2011-06-10 16:00marvintmResolutionfixed => open
2011-06-22 11:43hudsonbotCheckin
2011-06-22 11:43hudsonbotNote Added: 0038431
2011-06-22 11:43hudsonbotCheckin
2011-06-22 11:43hudsonbotNote Added: 0038436
2011-06-22 13:01hgbotCheckin
2011-06-22 13:01hgbotNote Added: 0038480
2011-06-22 13:01hgbotStatusnew => resolved
2011-06-22 13:01hgbotResolutionopen => fixed
2011-06-22 13:01hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/1419d0a02aafd18cd1381c3da1af9eca46976fb5 [^] => http://code.openbravo.com/erp/devel/pi/rev/3d645f1ae35c81d70537001c1944e726d9e3c2d4 [^]
2011-07-05 17:54shuehnerNote Added: 0038790
2011-07-05 17:54shuehnerStatusresolved => closed

Notes
(0036408)
dmitry_mezentsev   
2011-05-05 17:33   
Does not fit RC7
(0038193)
hgbot   
2011-06-09 12:40   
Repository: erp/devel/pi
Changeset: 1419d0a02aafd18cd1381c3da1af9eca46976fb5
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Jun 09 12:38:00 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1419d0a02aafd18cd1381c3da1af9eca46976fb5 [^]

Fixed issue 16940. Save buttons will be disabled while there is a FIC request going on

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0038213)
hgbot   
2011-06-10 10:04   
Repository: erp/devel/pi
Changeset: 73fa229509e130151fa2c614bad4ea4d586767fc
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Jun 10 10:02:09 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/73fa229509e130151fa2c614bad4ea4d586767fc [^]

Related to issue 16940. Two changes:
- Fixed JSLint issue
- Improved the previous change so that it also works in grid mode.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0038250)
marvintm   
2011-06-10 16:00   
The fix has been reverted, as it was incorrect in some cases. Check issue:

https://issues.openbravo.com/view.php?id=17586 [^]


The main problem is that the action() event of the Save button is not executed if the FIC call is ongoing, as the button was disabled when the blur() event happens as the field (which had a callout associated with it) lost its focus.

A different solution must be found.
(0038431)
hudsonbot   
2011-06-22 11:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/abb438586c0e [^]

Maturity status: Test
(0038436)
hudsonbot   
2011-06-22 11:43   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/abb438586c0e [^]

Maturity status: Test
(0038480)
hgbot   
2011-06-22 13:01   
Repository: erp/devel/pi
Changeset: 3d645f1ae35c81d70537001c1944e726d9e3c2d4
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Jun 22 13:00:11 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3d645f1ae35c81d70537001c1944e726d9e3c2d4 [^]

Fixed issue 16940. Validation will not be done if there is a FIC call pending.
With this change, if the user clicks on the save button while there is a FIC call in progress, the validation will not be done at that point. However, the validation will be done in the subsequent call to the saveRow() method, and therefore, it will still interrupt the save action if some field value is incorrect. This fixes the problem of the user pressing save when callouts are being executed, it still preserves the behaviour of the save action being posponed if the last changed field triggers a callout (see issue 17586), and still triggers validation in every possible save action.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0038790)
shuehner   
2011-07-05 17:54   
reviewed+test on pi/pgsql/chromium (rev id: 89b11e5682fb). Tested together with 17586. Both problems described cannot be reproduce anymore. Enabled/disabled state of toolbar buttons is now again independent of the inFicCall in progress or not. However if validations are not being done while a fic-call is in progress as the fic-result processing will only set the values which should be validated. Validation will be done on real save (if save was pressed while fic-call is being in progress as described in 16940 issue)).