Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016887Openbravo ERP09. Financial managementpublic2011-04-26 01:382011-11-04 13:58
Reporterpjuvara 
Assigned Toalostale 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0RC6.1 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016887: It is not possible to submit the Balance Sheet and P&L report twice
DescriptionOnce you enter the parameters for the Balance Sheet report and press the PDF button, the report is generated.

If you go back to the report submission form, modify one of the parameters and press PDF again, nothing happens.

Users are forced to refresh the form, which means loosing all the parameters that they just entered.
Steps To Reproduce
Proposed Solution
Additional Information
Tagssoho
Relationships
depends on backport 0016889 closed alostale It is not possible to submit the Balance Sheet and P&L report twice 
has duplicate defect 00170493.0MP0 closed dalsasua The Balance Sheet can be executed only once 
Attached Files? ChromeIssue.ogv (2,744,336) 2011-10-31 12:46
https://issues.openbravo.com/file_download.php?file_id=4692&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-04-26 01:38pjuvaraNew Issue
2011-04-26 01:38pjuvaraAssigned To => dalsasua
2011-04-26 01:38pjuvaraModules => Core
2011-04-26 01:38pjuvaraTag Attached: soho
2011-04-26 09:45dalsasuaNote Added: 0036074
2011-04-26 09:51dalsasuaStatusnew => scheduled
2011-04-26 09:51dalsasuaNote Added: 0036075
2011-04-26 09:51dalsasuafix_in_branch => pi
2011-04-26 11:23dalsasuaAssigned Todalsasua => alostale
2011-05-06 14:15adrianromeroRelationship addedhas duplicate 0017049
2011-10-24 12:32alostaleNote Added: 0042058
2011-10-24 12:35hgbotCheckin
2011-10-24 12:35hgbotNote Added: 0042059
2011-10-24 12:35hgbotStatusscheduled => resolved
2011-10-24 12:35hgbotResolutionopen => fixed
2011-10-24 12:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e5af0079aa01a78c9a21b549db25fdc875afb354 [^]
2011-10-31 12:46pjuvaraFile Added: ChromeIssue.ogv
2011-10-31 12:48pjuvaraNote Added: 0042407
2011-10-31 13:02alostaleNote Added: 0042410
2011-10-31 13:02alostaleStatusresolved => new
2011-10-31 13:02alostaleResolutionfixed => open
2011-10-31 13:25alostaleNote Added: 0042411
2011-10-31 13:38hgbotCheckin
2011-10-31 13:38hgbotNote Added: 0042412
2011-10-31 13:38hgbotStatusnew => resolved
2011-10-31 13:38hgbotResolutionopen => fixed
2011-10-31 13:38hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/e5af0079aa01a78c9a21b549db25fdc875afb354 [^] => http://code.openbravo.com/erp/devel/pi/rev/620dc540f85a6161c784566c5fc68c579553e2c8 [^]
2011-11-03 18:08iperdomoNote Added: 0042508
2011-11-03 18:08iperdomoStatusresolved => closed
2011-11-04 13:56hudsonbotCheckin
2011-11-04 13:56hudsonbotNote Added: 0042551
2011-11-04 13:58hudsonbotCheckin
2011-11-04 13:58hudsonbotNote Added: 0042613

Notes
(0036074)
dalsasua   
2011-04-26 09:45   
I've tried to reproduce, and in FF4 it works fine always, while in Chrome it just print the report the first click in the button...
(0036075)
dalsasua   
2011-04-26 09:51   
Same happens in 2.50 (always using Chrome browser)
(0042058)
alostale   
2011-10-24 12:32   
The problem seems to be caused by this chrome issue [1].

Solution is not to open the pdf in _blank target, benefits:
-It can be opened multiple times
-pdf is not opened in a blank new tab but directly downloaded

[1] https://code.google.com/p/chromium/issues/detail?id=16528 [^]
(0042059)
hgbot   
2011-10-24 12:35   
Repository: erp/devel/pi
Changeset: e5af0079aa01a78c9a21b549db25fdc875afb354
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Oct 24 12:34:40 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e5af0079aa01a78c9a21b549db25fdc875afb354 [^]

fixed bug 16887: It is not possible to submit the Balance Sheet and P&L report twice

  Do not use _blank target to open the pdf file, this causes not to be possible to open it
  several times in chrome and opens a new blank tab. Using a new hidden iframe so the pdf
  file is directly downloaded without creating a new tab.

---
M src/org/openbravo/erpCommon/ad_reports/GeneralAccountingReports.html
---
(0042407)
pjuvara   
2011-10-31 12:48   
The issue does not seem to be fixed.

It works fine in Firefox (tab is not open, file downloads correctly and opens as many times as you want) but no file is generated in Chrome.

See attached video.

This happens in live builds as well based on PI (video taken from there).
(0042410)
alostale   
2011-10-31 13:02   
I'm able to reproduce the problem in Google Chrome 15.0.874.106 but not in Chromium 14.0.835.202
(0042411)
alostale   
2011-10-31 13:25   
The problem can be workarounded in Chrome by openening about:plugins and disabling Chrome PDF Viewer.

The problem is when it is enabled (by default) it renders the pdf within the hidden frame instead of downloading it.
(0042412)
hgbot   
2011-10-31 13:38   
Repository: erp/devel/pi
Changeset: 620dc540f85a6161c784566c5fc68c579553e2c8
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Oct 31 13:37:14 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/620dc540f85a6161c784566c5fc68c579553e2c8 [^]

fixed bug 16887: Fixed pdf download in Chrome with PDF viewer plugin enabled

  File is forced as attachment

---
M src-core/src/org/openbravo/base/HttpBaseServlet.java
---
(0042508)
iperdomo   
2011-11-03 18:08   
Tested in pi @ rev a5c64b5081f5
(0042551)
hudsonbot   
2011-11-04 13:56   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test
(0042613)
hudsonbot   
2011-11-04 13:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d10da320df2a [^]

Maturity status: Test