Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0016882Openbravo ERP01. General setuppublic2011-04-25 15:042011-05-12 13:28
Reporterpjuvara 
Assigned ToAinhoaPagola 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0RC7Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0016882: Incorrect configuration of currency conversion rates window
DescriptionThe currency conversion rates window has the following incorrect configurations (from most offending to least offending):

1) The field of first focus is "Valid from Date"; it should be "To Currency" instead (this makes entering data **really** painful.

2) "Currency" is always defaulted to "EUR". Instead, it should be defaulted to the base currency of the client. This affects users' perception of Openbravo as a global solution able to be localized (not matter what you do, it works in euros...)

3) Label capitalization:
"Valid From Date" and "Valid To Date" instead of "Valid from Date" and "Valid to Date".
"Multiply Rate By" and "Divide Rate By" instead of "Multiply Rate by" and "Divide Rate by".

4) Window Layout in three rows instead of two
A more effective layout would be:
Organization - Active
Currency - To Currency
Valid From Date - Valid To Date - Multiply Rate By - Divide Rate By
Steps To Reproduce
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0016945 closed AinhoaPagola Incorrect configuration of currency conversion rates window 
related to defect 0016881 closed mtaal Not possible to save currency conversion rates in form view 
Attached Files? Conversion Rates (65,138) 2011-04-25 15:04
https://issues.openbravo.com/file_download.php?file_id=3897&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-04-25 15:04pjuvaraNew Issue
2011-04-25 15:04pjuvaraAssigned To => adrianromero
2011-04-25 15:04pjuvaraFile Added: Conversion Rates
2011-04-25 15:04pjuvaraModules => Core
2011-04-25 15:04pjuvaraRelationship addedrelated to 0016881
2011-04-28 11:31adrianromeroStatusnew => scheduled
2011-04-28 11:31adrianromerofix_in_branch => pi
2011-04-28 11:41adrianromeroTarget Version3.0RC6.1 => 3.0RC7
2011-04-28 11:41adrianromerofix_in_branchpi =>
2011-04-28 11:45adrianromeroPrioritynormal => immediate
2011-04-29 08:47dalsasuaAssigned Toadrianromero => ioritzCia
2011-04-29 13:09AinhoaPagolaAssigned ToioritzCia => AinhoaPagola
2011-04-29 13:18AinhoaPagolaNote Added: 0036214
2011-04-29 15:02AinhoaPagolaNote Added: 0036229
2011-04-29 15:02AinhoaPagolaStatusscheduled => acknowledged
2011-04-29 15:03AinhoaPagolaStatusacknowledged => scheduled
2011-04-29 15:03AinhoaPagolafix_in_branch => pi
2011-05-02 17:04hgbotCheckin
2011-05-02 17:04hgbotNote Added: 0036281
2011-05-02 17:04hgbotStatusscheduled => resolved
2011-05-02 17:04hgbotResolutionopen => fixed
2011-05-02 17:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e92864eaa9dd4869a839a78cceb798ff85dd7471 [^]
2011-05-02 17:07AinhoaPagolaNote Added: 0036282
2011-05-06 13:16adrianromeroNote Added: 0036504
2011-05-06 13:16adrianromeroStatusresolved => closed
2011-05-12 13:28hudsonbotCheckin
2011-05-12 13:28hudsonbotNote Added: 0036799

Notes
(0036214)
AinhoaPagola   
2011-04-29 13:18   
A few comments:

* Note that if the labels are capitalized for this window, this change will affect every other window using the same elements. I understand this capitalization is desired for every window using these labels.

* The same configuration errors are present in the "Conversion Rates" tab in "Currency" window. This is being fixes as well.
(0036229)
AinhoaPagola   
2011-04-29 15:02   
Changed to create backport to 2.50
(0036281)
hgbot   
2011-05-02 17:04   
Repository: erp/devel/pi
Changeset: e92864eaa9dd4869a839a78cceb798ff85dd7471
Author: Ainhoa Pagola <ainhoa.pagola <at> openbravo.com>
Date: Mon May 02 16:55:21 2011 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e92864eaa9dd4869a839a78cceb798ff85dd7471 [^]

Fixes issue 16882. Configuration of currency conversion rates window changed

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
---
(0036282)
AinhoaPagola   
2011-05-02 17:07   
* Resolution:

1) Focus:
- Currency window - Conversion Rate tab: First focus set to "To Currency"
- Conversion Rate window: First focus set to "Currency"

2) As the default is set in a column basis, and both windows use the same table, the default has been set for both, "Currency" and "To Currency" fields.
- Currency window - Conversion Rate tab: As Currency is linked to the parent, it only affects "To Currency" field.
- Conversion Rate window: Both will be defaulted to the clients base currency, assuming that the user will probably set one of these fields to that value.

Note that the base currency of the client has been used as default value and not the currency defined in the accounting schema. @$C_currency_id@ session value stores the currency of the accounting schema of the organization.

3) Labels changed. As the element has been changed, other fields linked to the same element have been changed.

4) Window Layout changed in both window/tabs.

* Testing the issue
Make sure the above configuration is present.
Test with "F&B International Group" client (try changing it's base currency)
Create a new client as well.

* Other areas affected
None.
(0036504)
adrianromero   
2011-05-06 13:16   
Verified
(0036799)
hudsonbot   
2011-05-12 13:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/c40e579fcd38 [^]

Maturity status: Test